cubistore/web
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

use SHA-256 instead of SHA-1 for hasing jar
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse source
This commit is contained in:
eater 2019-11-23 09:59:35 +01:00
parent eb1cbef43b
commit d16ccd468c
Signed by: eater
GPG key ID: AD2560A0F84F0759
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/Service/FDroidRepoService.php
View file

@ -100,26 +100,26 @@ class FDroidRepoService
$zip = new ZipArchive(); $zip = new ZipArchive();
$zipPath = tempnam(sys_get_temp_dir(), 'zip'); $zipPath = tempnam(sys_get_temp_dir(), 'zip');
$zip->open($zipPath, ZipArchive::CREATE); $zip->open($zipPath, ZipArchive::CREATE);
$fileDigest = sha1($contents, true); $fileDigest = hash('sha256', $contents, true);
$fileHeader = 'Name: ' . $file . "\n"; $fileHeader = 'Name: ' . $file . "\n";
$fileHeader .= 'SHA1-Digest: ' . base64_encode($fileDigest) . "\n\n"; $fileHeader .= 'SHA-256-Digest: ' . base64_encode($fileDigest) . "\n\n";
$fileHeaderDigest = sha1($fileHeader, true); $fileHeaderDigest = hash('sha256', $fileHeader, true);
$manifest = "Manifest-Version: 1.0\n"; $manifest = "Manifest-Version: 1.0\n";
$manifest .= "Created-By: CubiStore\n\n"; $manifest .= "Created-By: CubiStore\n\n";
$manifestHeaderDigest = sha1($manifest, true); $manifestHeaderDigest = hash('sha256', $manifest, true);
$manifest .= $fileHeader; $manifest .= $fileHeader;
$manifestDigest = sha1($manifest, true); $manifestDigest = hash('sha256', $manifest, true);
$fileManifest = "Signature-Version: 1.0\n"; $fileManifest = "Signature-Version: 1.0\n";
$fileManifest .= "SHA1-Digest-Manifest-Main-Attributes: " . base64_encode($manifestHeaderDigest) . "\n"; $fileManifest .= "SHA-256-Digest-Manifest-Main-Attributes: " . base64_encode($manifestHeaderDigest) . "\n";
$fileManifest .= "SHA1-Digest-Manifest: " . base64_encode($manifestDigest) . "\n"; $fileManifest .= "SHA-256-Digest-Manifest: " . base64_encode($manifestDigest) . "\n";
$fileManifest .= "Created-By: CubiStore\n\n"; $fileManifest .= "Created-By: CubiStore\n\n";
$fileManifest .= "Name: " . $file . "\n"; $fileManifest .= "Name: " . $file . "\n";
$fileManifest .= "SHA1-Digest: " . base64_encode($fileHeaderDigest) . "\n\n"; $fileManifest .= "SHA-256-Digest: " . base64_encode($fileHeaderDigest) . "\n\n";
$zip->addFromString('META-INF/MANIFEST.MF', $manifest); $zip->addFromString('META-INF/MANIFEST.MF', $manifest);
$zip->addFromString('META-INF/1.SF', $fileManifest); $zip->addFromString('META-INF/1.SF', $fileManifest);