From 1c7b94e94f27df9d8d078db7178109650ccb4cfd Mon Sep 17 00:00:00 2001
From: Miroslav Puda <pakanek@gmail.com>
Date: Mon, 27 May 2013 16:08:58 +0200
Subject: [PATCH] Switching in nextCastStyle() is now based on enum
 CastingStyle.

---
 apps/openmw/mwmechanics/enchanting.cpp | 49 +++++++++++++++++---------
 1 file changed, 32 insertions(+), 17 deletions(-)

diff --git a/apps/openmw/mwmechanics/enchanting.cpp b/apps/openmw/mwmechanics/enchanting.cpp
index c7a67e7cb..25aa0ea64 100644
--- a/apps/openmw/mwmechanics/enchanting.cpp
+++ b/apps/openmw/mwmechanics/enchanting.cpp
@@ -100,38 +100,53 @@ namespace MWMechanics
     
     void Enchanting::nextCastStyle()
     {
-        mCastStyle++;
         if (itemEmpty())
         {
-            mCastStyle = 0;
+            mCastStyle = ESM::CS_WhenUsed;
             return;
         }
-        if ((mObjectType == typeid(ESM::Armor).name())||(mObjectType == typeid(ESM::Clothing).name()))
-        {
-            int soulConstAmount = MWBase::Environment::get().getWorld()->getStore().get<ESM::GameSetting>().find ("iSoulAmountForConstantEffect")->getInt();
+
+        const bool powerfulSoul = getGemCharge() >= \
+        		MWBase::Environment::get().getWorld()->getStore().get<ESM::GameSetting>().find ("iSoulAmountForConstantEffect")->getInt();
+        if ((mObjectType == typeid(ESM::Armor).name()) || (mObjectType == typeid(ESM::Clothing).name()))
+        { // Armor or Clothing
             switch(mCastStyle)
             {
-                case 1:
-                    mCastStyle = 2;
-                case 3:
-                    if(getGemCharge()<soulConstAmount)
-                        mCastStyle=2;
-                case 4:
-                    mCastStyle = 2;
+                case ESM::CS_WhenUsed:
+                    if (powerfulSoul)
+                        mCastStyle = ESM::CS_ConstantEffect;
+                    return;
+                default: // takes care of Constant effect too
+                    mCastStyle = ESM::CS_WhenUsed;
+                    return;
             }
         }
         else if(mObjectType == typeid(ESM::Weapon).name())
-        {
+        { // Weapon
             switch(mCastStyle)
             {
-                case 3:
-                    mCastStyle = 1;
+                case ESM::CS_WhenStrikes:
+                	mCastStyle = ESM::CS_WhenUsed;
+                	return;
+                case ESM::CS_WhenUsed:
+                	if (powerfulSoul)
+                		mCastStyle = ESM::CS_ConstantEffect;
+                	else
+                		mCastStyle = ESM::CS_WhenStrikes;
+                	return;
+                default: // takes care of Constant effect too
+                	mCastStyle = ESM::CS_WhenStrikes;
+                	return;
             }
         }
         else if(mObjectType == typeid(ESM::Book).name())
-        {
-            mCastStyle=0;
+        { // Scroll or Book
+            mCastStyle = ESM::CS_CastOnce;
+            return;
         }
+
+        // Fail case
+        mCastStyle = ESM::CS_CastOnce;
     }
 
 	/*