From 3cc32b641ae6ff1ba06599b84940aaad1c3f529a Mon Sep 17 00:00:00 2001
From: MiroslavR <miroslavr256@gmail.com>
Date: Tue, 23 Dec 2014 20:44:25 +0100
Subject: [PATCH] Fix some memory leaks

---
 apps/launcher/utils/profilescombobox.cpp         |  6 +++---
 apps/launcher/utils/textinputdialog.cpp          |  6 +++---
 .../contentselector/model/contentmodel.cpp       | 16 ++++++++++++----
 .../contentselector/model/contentmodel.hpp       |  1 +
 .../contentselector/view/contentselector.cpp     |  2 +-
 5 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/apps/launcher/utils/profilescombobox.cpp b/apps/launcher/utils/profilescombobox.cpp
index c14330724..7df89098e 100644
--- a/apps/launcher/utils/profilescombobox.cpp
+++ b/apps/launcher/utils/profilescombobox.cpp
@@ -47,13 +47,13 @@ void ProfilesComboBox::setEditEnabled(bool editable)
 
 void ProfilesComboBox::slotTextChanged(const QString &text)
 {
-    QPalette *palette = new QPalette();
-    palette->setColor(QPalette::Text,Qt::red);
+    QPalette palette;
+    palette.setColor(QPalette::Text,Qt::red);
 
     int index = findText(text);
 
     if (text.isEmpty() || (index != -1 && index != currentIndex())) {
-        lineEdit()->setPalette(*palette);
+        lineEdit()->setPalette(palette);
     } else {
         lineEdit()->setPalette(QApplication::palette());
     }
diff --git a/apps/launcher/utils/textinputdialog.cpp b/apps/launcher/utils/textinputdialog.cpp
index b47fdb6e6..385d086fd 100644
--- a/apps/launcher/utils/textinputdialog.cpp
+++ b/apps/launcher/utils/textinputdialog.cpp
@@ -59,13 +59,13 @@ void Launcher::TextInputDialog::setOkButtonEnabled(bool enabled)
     QPushButton *okButton = mButtonBox->button(QDialogButtonBox::Ok);
     okButton->setEnabled(enabled);
 
-    QPalette *palette = new QPalette();
-    palette->setColor(QPalette::Text, Qt::red);
+    QPalette palette;
+    palette.setColor(QPalette::Text, Qt::red);
 
     if (enabled) {
         mLineEdit->setPalette(QApplication::palette());
     } else {
         // Existing profile name, make the text red
-        mLineEdit->setPalette(*palette);
+        mLineEdit->setPalette(palette);
     }
 }
diff --git a/components/contentselector/model/contentmodel.cpp b/components/contentselector/model/contentmodel.cpp
index 0d4f2365a..7af8b8cef 100644
--- a/components/contentselector/model/contentmodel.cpp
+++ b/components/contentselector/model/contentmodel.cpp
@@ -21,6 +21,12 @@ ContentSelectorModel::ContentModel::ContentModel(QObject *parent) :
     uncheckAll();
 }
 
+ContentSelectorModel::ContentModel::~ContentModel()
+{
+    qDeleteAll(mFiles);
+    mFiles.clear();
+}
+
 void ContentSelectorModel::ContentModel::setEncoding(const QString &encoding)
 {
     mEncoding = encoding;
@@ -444,7 +450,9 @@ void ContentSelectorModel::ContentModel::addFiles(const QString &path)
     foreach (const QString &path, dir.entryList())
     {
         QFileInfo info(dir.absoluteFilePath(path));
-        EsmFile *file = new EsmFile(path);
+
+        if (item(info.absoluteFilePath()) != 0)
+            continue;
 
         try {
             ESM::ESMReader fileReader;
@@ -453,6 +461,8 @@ void ContentSelectorModel::ContentModel::addFiles(const QString &path)
             fileReader.setEncoder(&encoder);
             fileReader.open(dir.absoluteFilePath(path).toStdString());
 
+            EsmFile *file = new EsmFile(path);
+
             foreach (const ESM::Header::MasterData &item, fileReader.getGameFiles())
                 file->addGameFile(QString::fromStdString(item.name));
 
@@ -462,10 +472,8 @@ void ContentSelectorModel::ContentModel::addFiles(const QString &path)
             file->setFilePath       (info.absoluteFilePath());
             file->setDescription(decoder->toUnicode(fileReader.getDesc().c_str()));
 
-
             // Put the file in the table
-            if (item(file->filePath()) == 0)
-                addFile(file);
+            addFile(file);
 
         } catch(std::runtime_error &e) {
             // An error occurred while reading the .esp
diff --git a/components/contentselector/model/contentmodel.hpp b/components/contentselector/model/contentmodel.hpp
index 7b2000b51..80b509489 100644
--- a/components/contentselector/model/contentmodel.hpp
+++ b/components/contentselector/model/contentmodel.hpp
@@ -21,6 +21,7 @@ namespace ContentSelectorModel
         Q_OBJECT
     public:
         explicit ContentModel(QObject *parent = 0);
+        ~ContentModel();
 
         void setEncoding(const QString &encoding);
 
diff --git a/components/contentselector/view/contentselector.cpp b/components/contentselector/view/contentselector.cpp
index e9599de49..c8085937c 100644
--- a/components/contentselector/view/contentselector.cpp
+++ b/components/contentselector/view/contentselector.cpp
@@ -24,7 +24,7 @@ ContentSelectorView::ContentSelector::ContentSelector(QWidget *parent) :
 
 void ContentSelectorView::ContentSelector::buildContentModel()
 {
-    mContentModel = new ContentSelectorModel::ContentModel();
+    mContentModel = new ContentSelectorModel::ContentModel(this);
 }
 
 void ContentSelectorView::ContentSelector::buildGameFileView()