Fixed binding controls to A on joystick

apps/openmw/mwinput/inputmanagerimp.cpp

@@ -740,13 +740,16 @@ namespace MWInput
         if (arg.button == SDL_CONTROLLER_BUTTON_A || arg.button == SDL_CONTROLLER_BUTTON_B) // We'll pretend that A is left click and B is right click
         {
             guiMode = MWBase::Environment::get().getWindowManager()->isGuiMode();
-            guiMode = MyGUI::InputManager::getInstance().injectMousePress(mMouseX, mMouseY, sdlButtonToMyGUI((arg.button == SDL_CONTROLLER_BUTTON_B) ? SDL_BUTTON_RIGHT : SDL_BUTTON_LEFT)) && guiMode;
+            if(!mInputBinder->detectingBindingState())
-            if (MyGUI::InputManager::getInstance ().getMouseFocusWidget () != 0)
             {
-                MyGUI::Button* b = MyGUI::InputManager::getInstance ().getMouseFocusWidget ()->castType<MyGUI::Button>(false);
+                guiMode = MyGUI::InputManager::getInstance().injectMousePress(mMouseX, mMouseY, sdlButtonToMyGUI((arg.button == SDL_CONTROLLER_BUTTON_B) ? SDL_BUTTON_RIGHT : SDL_BUTTON_LEFT)) && guiMode;
-                if (b && b->getEnabled())
+                if (MyGUI::InputManager::getInstance ().getMouseFocusWidget () != 0)
                 {
-                    MWBase::Environment::get().getSoundManager ()->playSound ("Menu Click", 1.f, 1.f);
+                    MyGUI::Button* b = MyGUI::InputManager::getInstance ().getMouseFocusWidget ()->castType<MyGUI::Button>(false);
+                    if (b && b->getEnabled())
+                    {
+                        MWBase::Environment::get().getSoundManager ()->playSound ("Menu Click", 1.f, 1.f);
+                    }
                 }
             }
         }

extern/oics/ICSInputControlSystem_joystick.cpp

@@ -180,11 +180,6 @@ namespace ICS
                     }
                 }
 			}
-			else if(mDetectingBindingListener)
-			{
-				mDetectingBindingListener->joystickButtonBindingDetected(this,
-					mDetectingBindingControl, evt.button, mDetectingBindingDirection);
-			}
 		}
 	}
 
@@ -192,11 +187,19 @@ namespace ICS
 	{
 		if(mActive)
 		{
-            ControlsButtonBinderMapType::const_iterator it = mControlsJoystickButtonBinderMap.find(evt.button);
+            if(!mDetectingBindingControl)
-            if(it != mControlsJoystickButtonBinderMap.end())
             {
-                it->second.control->setChangingDirection(Control::STOP);
+                ControlsButtonBinderMapType::const_iterator it = mControlsJoystickButtonBinderMap.find(evt.button);
+                if(it != mControlsJoystickButtonBinderMap.end())
+                {
+                    it->second.control->setChangingDirection(Control::STOP);
+                }
             }
+            else if(mDetectingBindingListener)
+			{
+				mDetectingBindingListener->joystickButtonBindingDetected(this,
+					mDetectingBindingControl, evt.button, mDetectingBindingDirection);
+			}
 		}
 	}