Rank condition should always fail if NPC is not in a faction

12 years ago · baa7a9160c
parent a7092ef2d7
commit baa7a9160c
1 changed files with 5 additions and 0 deletions
--- a/apps/openmw/mwdialogue/filter.cpp
+++ b/apps/openmw/mwdialogue/filter.cpp
@ -73,6 +73,11 @@ bool MWDialogue::Filter::testActor (const ESM::DialInfo& info) const
        if (iter->second < info.mData.mRank)
            return false;
    }
+    else if (info.mData.mRank != -1)
+    {
+        // if there is a rank condition, but the NPC is not in a faction, always fail
+        return false;
+    }

    // Gender
    if (!isCreature)