[Server] Improve Player::sendToLoaded()

apps/openmw-mp/Player.cpp

@@ -295,22 +295,25 @@ void Player::forEachLoaded(std::function<void(Player *pl, Player *other)> func)
     }
 }
 
-void Player::sendToLoaded(mwmp::PlayerPacket *myPacket)
+void Player::sendToLoaded(mwmp::PlayerPacket &myPacket)
 {
-    std::list <Player*> plList;
-
-    for (auto &cell : cells)
-        for (auto &pl : *cell)
-            plList.push_back(pl);
+    static std::set<Player*> plList;
+    static CellController::TContainer *addrCells = nullptr;
 
-    plList.sort();
-    plList.unique();
+    if (addrCells != &cells)
+    {
+        addrCells = &cells;
+        plList.clear();
+        for (auto &cell : cells)
+            for (auto &pl : *cell)
+                plList.insert(pl);
+    }
 
-    for (auto pl : plList)
+    for (auto &pl : plList)
     {
         if (pl == this) continue;
-        myPacket->setPlayer(this);
-        myPacket->Send(pl->guid);
+        myPacket.setPlayer(this);
+        myPacket.Send(pl->guid);
     }
 }
 

apps/openmw-mp/Player.hpp

@@ -66,7 +66,7 @@ public:
     virtual ~Player();
 
     CellController::TContainer *getCells();
-    void sendToLoaded(mwmp::PlayerPacket *myPacket);
+    void sendToLoaded(mwmp::PlayerPacket &myPacket);
 
     void forEachLoaded(std::function<void(Player *pl, Player *other)> func);
 

apps/openmw-mp/processors/player/ProcessorPlayerAnimFlags.hpp

@@ -21,7 +21,7 @@ namespace mwmp
         {
             DEBUG_PRINTF(strPacketID.c_str());
 
-            player->sendToLoaded(&packet);
+            player->sendToLoaded(packet);
         }
     };
 }

apps/openmw-mp/processors/player/ProcessorPlayerAnimPlay.hpp

@@ -17,7 +17,7 @@ namespace mwmp
         {
             DEBUG_PRINTF(strPacketID.c_str());
 
-            player->sendToLoaded(&packet);
+            player->sendToLoaded(packet);
         }
     };
 }

apps/openmw-mp/processors/player/ProcessorPlayerAttack.hpp

@@ -25,7 +25,7 @@ namespace mwmp
 
             if (!player->creatureStats.mDead)
             {
-                player->sendToLoaded(&packet);
+                player->sendToLoaded(packet);
             }
         }
     };

apps/openmw-mp/processors/player/ProcessorPlayerAttribute.hpp

@@ -23,7 +23,7 @@ namespace mwmp
             {
                 //myPacket->Send(player, true);
 
-                player->sendToLoaded(&packet);
+                player->sendToLoaded(packet);
 
                 Networking::get().getState().getEventCtrl().Call<CoreEvent::ON_PLAYER_ATTRIBUTE>(player);
             }

apps/openmw-mp/processors/player/ProcessorPlayerEquipment.hpp

@@ -21,7 +21,7 @@ namespace mwmp
         {
             DEBUG_PRINTF(strPacketID.c_str());
 
-            player->sendToLoaded(&packet);
+            player->sendToLoaded(packet);
 
             Networking::get().getState().getEventCtrl().Call<CoreEvent::ON_PLAYER_EQUIPMENT>(player);
         }

apps/openmw-mp/processors/player/ProcessorPlayerPosition.hpp

@@ -22,7 +22,7 @@ namespace mwmp
             //DEBUG_PRINTF(strPacketID);
             if (!player->creatureStats.mDead)
             {
-                player->sendToLoaded(&packet);
+                player->sendToLoaded(packet);
             }
         }
     };

apps/openmw-mp/processors/player/ProcessorPlayerSkill.hpp

@@ -22,7 +22,7 @@ namespace mwmp
             if (!player->creatureStats.mDead)
             {
                 //myPacket->Send(player, true);
-                player->sendToLoaded(&packet);
+                player->sendToLoaded(packet);
 
                 Networking::get().getState().getEventCtrl().Call<CoreEvent::ON_PLAYER_SKILL>(player);
             }

apps/openmw-mp/processors/player/ProcessorPlayerSpeech.hpp

@@ -17,7 +17,7 @@ namespace mwmp
         {
             DEBUG_PRINTF(strPacketID.c_str());
 
-            player->sendToLoaded(&packet);
+            player->sendToLoaded(packet);
         }
     };
 }

apps/openmw-mp/processors/player/ProcessorPlayerStatsDynamic.hpp

@@ -21,7 +21,7 @@ namespace mwmp
         {
             DEBUG_PRINTF(strPacketID.c_str());
 
-            player->sendToLoaded(&packet);
+            player->sendToLoaded(packet);
         }
     };
 }