From e3d3380c8ce1612f579f175972ffe79e00060df1 Mon Sep 17 00:00:00 2001
From: scrawl <scrawl@baseoftrash.de>
Date: Mon, 7 Dec 2015 22:41:55 +0100
Subject: [PATCH] Remove return value for in-place toLowerStr

---
 apps/essimporter/converter.hpp  |  2 +-
 components/misc/stringops.hpp   | 10 +++++-----
 components/nifosg/nifloader.cpp |  2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/apps/essimporter/converter.hpp b/apps/essimporter/converter.hpp
index 8194f2b43..550b7c0ae 100644
--- a/apps/essimporter/converter.hpp
+++ b/apps/essimporter/converter.hpp
@@ -381,7 +381,7 @@ public:
         bool isDeleted = false;
 
         faction.load(esm, isDeleted);
-        std::string id = Misc::StringUtils::toLower(faction.mId);
+        std::string id = Misc::StringUtils::lowerCase(faction.mId);
 
         for (std::map<std::string, int>::const_iterator it = faction.mReactions.begin(); it != faction.mReactions.end(); ++it)
         {
diff --git a/components/misc/stringops.hpp b/components/misc/stringops.hpp
index ce27d5fb2..2fd997285 100644
--- a/components/misc/stringops.hpp
+++ b/components/misc/stringops.hpp
@@ -94,22 +94,22 @@ public:
     }
 
     /// Transforms input string to lower case w/o copy
-    static std::string &toLower(std::string &inout) {
+    static void toLower(std::string &inout) {
         for (unsigned int i=0; i<inout.size(); ++i)
             inout[i] = toLower(inout[i]);
-        return inout;
     }
 
-    static std::string &toLowerStr(std::string &inout)
+    static void toLowerStr(std::string &inout)
     {
-        return toLower(inout);
+        toLower(inout);
     }
 
     /// Returns lower case copy of input string
     static std::string lowerCase(const std::string &in)
     {
         std::string out = in;
-        return toLower(out);
+        toLower(out);
+        return out;
     }
 };
 
diff --git a/components/nifosg/nifloader.cpp b/components/nifosg/nifloader.cpp
index c2629194d..0489e07e6 100644
--- a/components/nifosg/nifloader.cpp
+++ b/components/nifosg/nifloader.cpp
@@ -254,7 +254,7 @@ namespace
                     nextpos = std::distance(str.begin(), ++last);
                 }
                 std::string result = str.substr(pos, nextpos-pos);
-                textkeys.insert(std::make_pair(tk->list[i].time, Misc::StringUtils::toLower(result)));
+                textkeys.insert(std::make_pair(tk->list[i].time, Misc::StringUtils::lowerCase(result)));
 
                 pos = nextpos;
             }