forked from teamnwah/openmw-tes3coop
91f4967614
This bug would cause the player to jump when jump was assigned to Space and they closed a dialog with Space. I tested vanilla MW for behaviour and found that Jump was the only basic input which MW does not allow when closing dialogs (i.e. if Space is assigned to move forward, MW will move you forward after closing the dialog). There were two reasons for the bug: 1) OpenMW GUI does not consume UI events 2) Jump occurs so long as key is down (not only on first key down) To minimally fix the bug, I made it so that keypress events can be consumed by the GUI and not passed along to the player control input manager (1). However, if the player holds space, they will still jump (as the subsequent key held events will be captured and cause a jump). Unfortunately, there is no idiomatic way that I could find in the OpenMW input manager to perform events only on key down. Instead, I introduced a variable which tracks whether the jump key has been pressed for the first time within the current frame (2). Note: I was initially concerned that limiting the jump event to KeyDown and not Key Hold would cause issues with swimming, levitating, or variable height jumping. However, after a bunch of testing in vanilla MW and exploration of the OpenMW codebase I could find nothing suggesting the need to capture the jump key being held. |
||
|---|---|---|
| .. | ||
| mwbase | ||
| mwclass | ||
| mwdialogue | ||
| mwgui | ||
| mwinput | ||
| mwmechanics | ||
| mwrender | ||
| mwscript | ||
| mwsound | ||
| mwstate | ||
| mwworld | ||
| CMakeLists.txt | ||
| crashcatcher.cpp | ||
| doc.hpp | ||
| engine.cpp | ||
| engine.hpp | ||
| main.cpp | ||