mirror/async-std
2
0
Fork 1
mirror of https://github.com/async-rs/async-std.git synced 2025-04-02 22:46:42 +00:00
Code Issues Releases Wiki Activity

Changing task::block_on to park after a single poll (#684)

Browse source 
This was previously discussed in #605 and others as a source of high
CPU load when sleeping tasks because of the overhead created by
retrying a future in short succession.
This commit is contained in:
Katharina Fey 2020-01-20 20:40:01 +01:00 committed by Stjepan Glavina
parent d283352a9a
commit 81aa6d152a
1 changed files with 1 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/task/block_on.rs
View file

@ -3,7 +3,6 @@ use std::future::Future;
use std::mem::{self, ManuallyDrop}; use std::mem::{self, ManuallyDrop};
use std::sync::Arc; use std::sync::Arc;
use std::task::{RawWaker, RawWakerVTable}; use std::task::{RawWaker, RawWakerVTable};
use std::thread;
use crossbeam_utils::sync::Parker; use crossbeam_utils::sync::Parker;
use kv_log_macro::trace; use kv_log_macro::trace;
@ -125,7 +124,6 @@ where
let waker = unsafe { ManuallyDrop::new(Waker::from_raw(RawWaker::new(ptr, &VTABLE))) }; let waker = unsafe { ManuallyDrop::new(Waker::from_raw(RawWaker::new(ptr, &VTABLE))) };
let cx = &mut Context::from_waker(&waker); let cx = &mut Context::from_waker(&waker);
let mut step = 0;
loop { loop {
if let Poll::Ready(t) = future.as_mut().poll(cx) { if let Poll::Ready(t) = future.as_mut().poll(cx) {
// Save the parker for the next invocation of `block`. // Save the parker for the next invocation of `block`.
@ -133,14 +131,7 @@ where
return t; return t;
} }
// Yield a few times or park the current thread. arc_parker.park();
if step < 3 {
thread::yield_now();
step += 1;
} else {
arc_parker.park();
step = 0;
}
} }
}) })
} }