|
|
|
#include "shortcuteventhandler.hpp"
|
|
|
|
|
|
|
|
#include <algorithm>
|
|
|
|
#include <cassert>
|
|
|
|
|
|
|
|
#include <QEvent>
|
|
|
|
#include <QKeyEvent>
|
|
|
|
#include <QMouseEvent>
|
|
|
|
#include <QWidget>
|
|
|
|
|
|
|
|
#include "shortcut.hpp"
|
|
|
|
|
|
|
|
namespace CSMPrefs
|
|
|
|
{
|
|
|
|
ShortcutEventHandler::ShortcutEventHandler(QObject* parent)
|
|
|
|
: QObject(parent)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
void ShortcutEventHandler::addShortcut(Shortcut* shortcut)
|
|
|
|
{
|
|
|
|
// Enforced by shortcut class
|
|
|
|
QWidget* widget = static_cast<QWidget*>(shortcut->parent());
|
|
|
|
|
|
|
|
// Check if widget setup is needed
|
|
|
|
ShortcutMap::iterator shortcutListIt = mWidgetShortcuts.find(widget);
|
|
|
|
if (shortcutListIt == mWidgetShortcuts.end())
|
|
|
|
{
|
|
|
|
// Create list
|
|
|
|
shortcutListIt = mWidgetShortcuts.insert(std::make_pair(widget, ShortcutList())).first;
|
|
|
|
|
|
|
|
// Check if widget has a parent with shortcuts, unfortunately it is not typically set yet
|
|
|
|
updateParent(widget);
|
|
|
|
|
|
|
|
// Intercept widget events
|
|
|
|
widget->installEventFilter(this);
|
|
|
|
connect(widget, SIGNAL(destroyed()), this, SLOT(widgetDestroyed()));
|
|
|
|
}
|
|
|
|
|
|
|
|
// Add to list
|
|
|
|
shortcutListIt->second.push_back(shortcut);
|
|
|
|
}
|
|
|
|
|
|
|
|
void ShortcutEventHandler::removeShortcut(Shortcut* shortcut)
|
|
|
|
{
|
|
|
|
// Enforced by shortcut class
|
|
|
|
QWidget* widget = static_cast<QWidget*>(shortcut->parent());
|
|
|
|
|
|
|
|
ShortcutMap::iterator shortcutListIt = mWidgetShortcuts.find(widget);
|
|
|
|
if (shortcutListIt != mWidgetShortcuts.end())
|
|
|
|
{
|
Some PVS-Studio and cppcheck fixes
cppcheck:
[apps/esmtool/record.cpp:697]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1126]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1138]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/niftest/niftest.cpp:36]: (performance) Function parameter 'filename' should be passed by reference.
[apps/niftest/niftest.cpp:41]: (performance) Function parameter 'filename' should be passed by reference.
[apps/opencs/model/prefs/boolsetting.cpp:25]: (warning) Possible leak in public function. The pointer 'mWidget' is not deallocated before it is allocated.
[apps/opencs/model/prefs/shortcuteventhandler.cpp:52]: (warning) Return value of std::remove() ignored. Elements remain in container.
[apps/openmw/mwstate/quicksavemanager.cpp:5]: (performance) Variable 'mSaveName' is assigned in constructor body. Consider performing initialization in initialization list.
PVS-Studio:
apps/opencs/model/filter/parser.cpp 582 warn V560 A part of conditional expression is always true: allowPredefined.
apps/opencs/view/world/referencecreator.cpp 67 warn V547 Expression '!errors.empty()' is always false.
apps/opencs/view/world/referencecreator.cpp 74 warn V547 Expression '!errors.empty()' is always false.
apps/opencs/view/doc/loader.cpp 170 warn V560 A part of conditional expression is always true: !completed.
apps/opencs/view/doc/loader.cpp 170 warn V560 A part of conditional expression is always true: !error.empty().
apps/opencs/model/tools/pathgridcheck.cpp 32 err V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 32, 34.
apps/opencs/model/world/refidadapterimp.cpp 1376 err V547 Expression 'subColIndex < 3' is always true.
apps/openmw/mwgui/widgets.hpp 318 warn V703 It is odd that the 'mEnableRepeat' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:318, MyGUI_ScrollBar.h:179.
apps/openmw/mwgui/widgets.hpp 319 warn V703 It is odd that the 'mRepeatTriggerTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:319, MyGUI_ScrollBar.h:180.
apps/openmw/mwgui/widgets.hpp 320 warn V703 It is odd that the 'mRepeatStepTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:320, MyGUI_ScrollBar.h:181
apps/openmw/mwmechanics/actors.cpp 1425 warn V547 Expression '!detected' is always true.
apps/openmw/mwmechanics/character.cpp 2155 err V547 Expression 'mode == 0' is always true.
apps/openmw/mwmechanics/character.cpp 1192 warn V592 The expression was enclosed by parentheses twice: ((expression)). One pair of parentheses is unnecessary or misprint is present.
apps/openmw/mwmechanics/character.cpp 521 warn V560 A part of conditional expression is always true: (idle == mIdleState).
apps/openmw/mwmechanics/pathfinding.cpp 317 err V547 Expression 'mPath.size() >= 2' is always true.
apps/openmw/mwscript/interpretercontext.cpp 409 warn V560 A part of conditional expression is always false: rank > 9.
apps/openmw/mwgui/windowbase.cpp 28 warn V560 A part of conditional expression is always true: !visible.
apps/openmw/mwgui/journalwindow.cpp 561 warn V547 Expression '!mAllQuests' is always false.
apps/openmw/mwgui/referenceinterface.cpp 18 warn V571 Recurring check. The '!mPtr.isEmpty()' condition was already verified in line 16.
apps/openmw/mwworld/scene.cpp 463 warn V547 Expression 'adjustPlayerPos' is always true.
apps/openmw/mwworld/worldimp.cpp 409 err V766 An item with the same key '"sCompanionShare"' has already been added.
apps/openmw/mwworld/cellstore.cpp 691 warn V519 The 'state.mWaterLevel' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 689, 691.
apps/openmw/mwworld/weather.cpp 1125 warn V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1123, 1125.
apps/openmw/mwworld/weather.cpp 1137 warn V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1135, 1137.
apps/wizard/unshield/unshieldworker.cpp 475 warn V728 An excessive check can be simplified. The '(A && B) || (!A && !B)' expression is equivalent to the 'bool(A) == bool(B)' expression.
apps/wizard/installationpage.cpp 163 warn V735 Possibly an incorrect HTML. The "</p" closing tag was encountered, while the "</span" tag was expected.
components/fontloader/fontloader.cpp 427 err V547 Expression 'i == 1' is always true.
components/nifosg/nifloader.cpp 282 warn V519 The 'created' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 278, 282.
components/esm/loadregn.cpp 119 err V586 The 'clear' function is called twice for deallocation of the same resource. Check lines: 112, 119.
components/esm/cellref.cpp 178 warn V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 175, 178.
components/esmterrain/storage.cpp 235 warn V560 A part of conditional expression is always true: colStart == 0.
components/esmterrain/storage.cpp 237 warn V560 A part of conditional expression is always true: rowStart == 0.
7 years ago
|
|
|
shortcutListIt->second.erase(std::remove(shortcutListIt->second.begin(), shortcutListIt->second.end(), shortcut), shortcutListIt->second.end());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
bool ShortcutEventHandler::eventFilter(QObject* watched, QEvent* event)
|
|
|
|
{
|
|
|
|
// Process event
|
|
|
|
if (event->type() == QEvent::KeyPress)
|
|
|
|
{
|
|
|
|
QWidget* widget = static_cast<QWidget*>(watched);
|
|
|
|
QKeyEvent* keyEvent = static_cast<QKeyEvent*>(event);
|
|
|
|
unsigned int mod = (unsigned int) keyEvent->modifiers();
|
|
|
|
unsigned int key = (unsigned int) keyEvent->key();
|
|
|
|
|
|
|
|
if (!keyEvent->isAutoRepeat())
|
|
|
|
return activate(widget, mod, key);
|
|
|
|
}
|
|
|
|
else if (event->type() == QEvent::KeyRelease)
|
|
|
|
{
|
|
|
|
QWidget* widget = static_cast<QWidget*>(watched);
|
|
|
|
QKeyEvent* keyEvent = static_cast<QKeyEvent*>(event);
|
|
|
|
unsigned int mod = (unsigned int) keyEvent->modifiers();
|
|
|
|
unsigned int key = (unsigned int) keyEvent->key();
|
|
|
|
|
|
|
|
if (!keyEvent->isAutoRepeat())
|
|
|
|
return deactivate(widget, mod, key);
|
|
|
|
}
|
|
|
|
else if (event->type() == QEvent::MouseButtonPress)
|
|
|
|
{
|
|
|
|
QWidget* widget = static_cast<QWidget*>(watched);
|
|
|
|
QMouseEvent* mouseEvent = static_cast<QMouseEvent*>(event);
|
|
|
|
unsigned int mod = (unsigned int) mouseEvent->modifiers();
|
|
|
|
unsigned int button = (unsigned int) mouseEvent->button();
|
|
|
|
|
|
|
|
return activate(widget, mod, button);
|
|
|
|
}
|
|
|
|
else if (event->type() == QEvent::MouseButtonRelease)
|
|
|
|
{
|
|
|
|
QWidget* widget = static_cast<QWidget*>(watched);
|
|
|
|
QMouseEvent* mouseEvent = static_cast<QMouseEvent*>(event);
|
|
|
|
unsigned int mod = (unsigned int) mouseEvent->modifiers();
|
|
|
|
unsigned int button = (unsigned int) mouseEvent->button();
|
|
|
|
|
|
|
|
return deactivate(widget, mod, button);
|
|
|
|
}
|
|
|
|
else if (event->type() == QEvent::FocusOut)
|
|
|
|
{
|
|
|
|
QWidget* widget = static_cast<QWidget*>(watched);
|
|
|
|
ShortcutMap::iterator shortcutListIt = mWidgetShortcuts.find(widget);
|
|
|
|
|
|
|
|
// Deactivate in case events are missed
|
|
|
|
for (ShortcutList::iterator it = shortcutListIt->second.begin(); it != shortcutListIt->second.end(); ++it)
|
|
|
|
{
|
|
|
|
Shortcut* shortcut = *it;
|
|
|
|
|
|
|
|
shortcut->setPosition(0);
|
|
|
|
shortcut->setModifierStatus(false);
|
|
|
|
|
|
|
|
if (shortcut->getActivationStatus() == Shortcut::AS_Regular)
|
|
|
|
{
|
|
|
|
shortcut->setActivationStatus(Shortcut::AS_Inactive);
|
|
|
|
shortcut->signalActivated(false);
|
|
|
|
}
|
|
|
|
else if (shortcut->getActivationStatus() == Shortcut::AS_Secondary)
|
|
|
|
{
|
|
|
|
shortcut->setActivationStatus(Shortcut::AS_Inactive);
|
|
|
|
shortcut->signalSecondary(false);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else if (event->type() == QEvent::FocusIn)
|
|
|
|
{
|
|
|
|
QWidget* widget = static_cast<QWidget*>(watched);
|
|
|
|
updateParent(widget);
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
void ShortcutEventHandler::updateParent(QWidget* widget)
|
|
|
|
{
|
|
|
|
QWidget* parent = widget->parentWidget();
|
|
|
|
while (parent)
|
|
|
|
{
|
|
|
|
ShortcutMap::iterator parentIt = mWidgetShortcuts.find(parent);
|
|
|
|
if (parentIt != mWidgetShortcuts.end())
|
|
|
|
{
|
|
|
|
mChildParentRelations.insert(std::make_pair(widget, parent));
|
|
|
|
updateParent(parent);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check next
|
|
|
|
parent = parent->parentWidget();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
bool ShortcutEventHandler::activate(QWidget* widget, unsigned int mod, unsigned int button)
|
|
|
|
{
|
|
|
|
std::vector<std::pair<MatchResult, Shortcut*> > potentials;
|
|
|
|
bool used = false;
|
|
|
|
|
|
|
|
while (widget)
|
|
|
|
{
|
|
|
|
ShortcutMap::iterator shortcutListIt = mWidgetShortcuts.find(widget);
|
|
|
|
assert(shortcutListIt != mWidgetShortcuts.end());
|
|
|
|
|
|
|
|
// Find potential activations
|
|
|
|
for (ShortcutList::iterator it = shortcutListIt->second.begin(); it != shortcutListIt->second.end(); ++it)
|
|
|
|
{
|
|
|
|
Shortcut* shortcut = *it;
|
|
|
|
|
|
|
|
if (!shortcut->isEnabled())
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (checkModifier(mod, button, shortcut, true))
|
|
|
|
used = true;
|
|
|
|
|
|
|
|
if (shortcut->getActivationStatus() != Shortcut::AS_Inactive)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
int pos = shortcut->getPosition();
|
|
|
|
int lastPos = shortcut->getLastPosition();
|
|
|
|
MatchResult result = match(mod, button, shortcut->getSequence()[pos]);
|
|
|
|
|
|
|
|
if (result == Matches_WithMod || result == Matches_NoMod)
|
|
|
|
{
|
|
|
|
if (pos < lastPos && (result == Matches_WithMod || pos > 0))
|
|
|
|
{
|
|
|
|
shortcut->setPosition(pos+1);
|
|
|
|
}
|
|
|
|
else if (pos == lastPos)
|
|
|
|
{
|
|
|
|
potentials.push_back(std::make_pair(result, shortcut));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Move on to parent
|
|
|
|
WidgetMap::iterator widgetIt = mChildParentRelations.find(widget);
|
|
|
|
widget = (widgetIt != mChildParentRelations.end()) ? widgetIt->second : 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Only activate the best match; in exact conflicts, this will favor the first shortcut added.
|
|
|
|
if (!potentials.empty())
|
|
|
|
{
|
|
|
|
std::sort(potentials.begin(), potentials.end(), ShortcutEventHandler::sort);
|
|
|
|
Shortcut* shortcut = potentials.front().second;
|
|
|
|
|
|
|
|
if (shortcut->getModifierStatus() && shortcut->getSecondaryMode() == Shortcut::SM_Replace)
|
|
|
|
{
|
|
|
|
shortcut->setActivationStatus(Shortcut::AS_Secondary);
|
|
|
|
shortcut->signalSecondary(true);
|
|
|
|
shortcut->signalSecondary();
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
shortcut->setActivationStatus(Shortcut::AS_Regular);
|
|
|
|
shortcut->signalActivated(true);
|
|
|
|
shortcut->signalActivated();
|
|
|
|
}
|
|
|
|
|
|
|
|
used = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return used;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool ShortcutEventHandler::deactivate(QWidget* widget, unsigned int mod, unsigned int button)
|
|
|
|
{
|
|
|
|
const int KeyMask = 0x01FFFFFF;
|
|
|
|
|
|
|
|
bool used = false;
|
|
|
|
|
|
|
|
while (widget)
|
|
|
|
{
|
|
|
|
ShortcutMap::iterator shortcutListIt = mWidgetShortcuts.find(widget);
|
|
|
|
assert(shortcutListIt != mWidgetShortcuts.end());
|
|
|
|
|
|
|
|
for (ShortcutList::iterator it = shortcutListIt->second.begin(); it != shortcutListIt->second.end(); ++it)
|
|
|
|
{
|
|
|
|
Shortcut* shortcut = *it;
|
|
|
|
|
|
|
|
if (checkModifier(mod, button, shortcut, false))
|
|
|
|
used = true;
|
|
|
|
|
|
|
|
int pos = shortcut->getPosition();
|
|
|
|
MatchResult result = match(0, button, shortcut->getSequence()[pos] & KeyMask);
|
|
|
|
|
|
|
|
if (result != Matches_Not)
|
|
|
|
{
|
|
|
|
shortcut->setPosition(0);
|
|
|
|
|
|
|
|
if (shortcut->getActivationStatus() == Shortcut::AS_Regular)
|
|
|
|
{
|
|
|
|
shortcut->setActivationStatus(Shortcut::AS_Inactive);
|
|
|
|
shortcut->signalActivated(false);
|
|
|
|
used = true;
|
|
|
|
}
|
|
|
|
else if (shortcut->getActivationStatus() == Shortcut::AS_Secondary)
|
|
|
|
{
|
|
|
|
shortcut->setActivationStatus(Shortcut::AS_Inactive);
|
|
|
|
shortcut->signalSecondary(false);
|
|
|
|
used = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Move on to parent
|
|
|
|
WidgetMap::iterator widgetIt = mChildParentRelations.find(widget);
|
|
|
|
widget = (widgetIt != mChildParentRelations.end()) ? widgetIt->second : 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
return used;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool ShortcutEventHandler::checkModifier(unsigned int mod, unsigned int button, Shortcut* shortcut, bool activate)
|
|
|
|
{
|
|
|
|
if (!shortcut->isEnabled() || !shortcut->getModifier() || shortcut->getSecondaryMode() == Shortcut::SM_Ignore ||
|
|
|
|
shortcut->getModifierStatus() == activate)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
MatchResult result = match(mod, button, shortcut->getModifier());
|
|
|
|
bool used = false;
|
|
|
|
|
|
|
|
if (result != Matches_Not)
|
|
|
|
{
|
|
|
|
shortcut->setModifierStatus(activate);
|
|
|
|
|
|
|
|
if (shortcut->getSecondaryMode() == Shortcut::SM_Detach)
|
|
|
|
{
|
|
|
|
if (activate)
|
|
|
|
{
|
|
|
|
shortcut->signalSecondary(true);
|
|
|
|
shortcut->signalSecondary();
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
shortcut->signalSecondary(false);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else if (!activate && shortcut->getActivationStatus() == Shortcut::AS_Secondary)
|
|
|
|
{
|
|
|
|
shortcut->setActivationStatus(Shortcut::AS_Inactive);
|
|
|
|
shortcut->setPosition(0);
|
|
|
|
shortcut->signalSecondary(false);
|
|
|
|
used = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return used;
|
|
|
|
}
|
|
|
|
|
|
|
|
ShortcutEventHandler::MatchResult ShortcutEventHandler::match(unsigned int mod, unsigned int button,
|
|
|
|
unsigned int value)
|
|
|
|
{
|
|
|
|
if ((mod | button) == value)
|
|
|
|
{
|
|
|
|
return Matches_WithMod;
|
|
|
|
}
|
|
|
|
else if (button == value)
|
|
|
|
{
|
|
|
|
return Matches_NoMod;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
return Matches_Not;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
bool ShortcutEventHandler::sort(const std::pair<MatchResult, Shortcut*>& left,
|
|
|
|
const std::pair<MatchResult, Shortcut*>& right)
|
|
|
|
{
|
|
|
|
if (left.first == Matches_WithMod && right.first == Matches_NoMod)
|
|
|
|
return true;
|
|
|
|
else
|
|
|
|
return left.second->getPosition() >= right.second->getPosition();
|
|
|
|
}
|
|
|
|
|
|
|
|
void ShortcutEventHandler::widgetDestroyed()
|
|
|
|
{
|
|
|
|
QWidget* widget = static_cast<QWidget*>(sender());
|
|
|
|
|
|
|
|
mWidgetShortcuts.erase(widget);
|
|
|
|
mChildParentRelations.erase(widget);
|
|
|
|
}
|
|
|
|
}
|