mirror/openmw-tes3mp
1
0
Fork 1
mirror of https://github.com/TES3MP/openmw-tes3mp.git synced 2025-04-01 01:36:44 +00:00
Code Issues Releases Wiki Activity

Generally speaking, you should never compare iterators from two different compilers

Browse source 
http://stackoverflow.com/questions/4657513/comparing-iterators-from-different-containers
It seems like this was just an overlook that happened to work on most systems. I was not able to thoroughly test this change, but it fixed an issue I was having in VC10.
It's possible the prev.end() was a copy paste error that was meant to be new.end() anyways.
This commit is contained in:
Xethik 2013-09-20 21:38:10 -04:00
parent 58bb0b8773
commit 094e4d93b7
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
apps/openmw/mwmechanics/magiceffects.cpp
View file

@ -151,8 +151,7 @@ namespace MWMechanics
for (Collection::const_iterator iter (prev.begin()); iter!=prev.end(); ++iter) for (Collection::const_iterator iter (prev.begin()); iter!=prev.end(); ++iter)
{ {
Collection::const_iterator other = now.mCollection.find (iter->first); Collection::const_iterator other = now.mCollection.find (iter->first);
if (other==now.end())
if (other==prev.end())
{ {
result.add (iter->first, EffectParam() - iter->second); result.add (iter->first, EffectParam() - iter->second);
} }