Even more -Wall fixes - and added -Wall to test makefiles to actually catch them...

input/tests/Makefile

@@ -1,4 +1,4 @@
-GCC=g++
+GCC=g++ -Wall
 
 all: sdl_driver_test ois_driver_test evtlist_test
 

rend2d/tests/Makefile

@@ -1,4 +1,4 @@
-GCC=g++
+GCC=g++ -Wall
 
 all: sdl_test
 

sound/sources/ffmpeg_source.cpp

@@ -97,8 +97,8 @@ size_t FFMpegSource::read(void *data, size_t length)
 
   // First, copy over any stored data we might be sitting on
   {
-    int s = storage.size();
+    size_t s = storage.size();
-    int copy = s;
+    size_t copy = s;
     if(s)
       {
         // Make sure there's room
@@ -111,6 +111,7 @@ size_t FFMpegSource::read(void *data, size_t length)
         left -= copy;
 
         // Is there anything left in the storage?
+        assert(s>= copy);
         s -= copy;
         if(s)
           {
@@ -133,7 +134,7 @@ size_t FFMpegSource::read(void *data, size_t length)
         break;
 
       // We only allow one stream per file at the moment
-      assert(StreamNum == packet.stream_index);
+      assert((int)StreamNum == packet.stream_index);
 
       // Decode the packet
       int len = AVCODEC_MAX_AUDIO_FRAME_SIZE;
@@ -151,7 +152,7 @@ size_t FFMpegSource::read(void *data, size_t length)
       if(len > 0)
         {
           // copy = how many bytes do we copy now
-          int copy = len;
+          size_t copy = len;
           if(copy > left)
             copy = left;
 

sound/sources/ffmpeg_source.hpp

@@ -18,7 +18,7 @@ class FFMpegSource : public SampleSource
 {
   AVFormatContext *FmtCtx;
   AVCodecContext *CodecCtx;
-  int StreamNum;
+  unsigned int StreamNum;
 
   std::vector<uint8_t> storage;
 

sound/tests/Makefile

@@ -1,4 +1,4 @@
-GCC=g++ -I../
+GCC=g++ -I../ -Wall
 
 all: audiere_source_test ffmpeg_source_test openal_output_test openal_audiere_test openal_ffmpeg_test
 

stream/tests/Makefile

@@ -1,4 +1,4 @@
-GCC=g++ -I../
+GCC=g++ -I../ -Wall
 
 all: ogre_client_test audiere_client_test memory_server_test buffer_filter_test file_server_test slice_filter_test file_write_test
 

vfs/clients/ogre_archive.hpp

@@ -22,7 +22,9 @@ class MangleArchive : public Ogre::Archive
  public:
   MangleArchive(VFSPtr _vfs, const std::string &name,
                 const std::string &archType = "Mangle")
-    : vfs(_vfs), Ogre::Archive(name, archType) {}
+    : Ogre::Archive(name, archType)
+    , vfs(_vfs)
+  {}
 
   bool isCaseSensitive() const { return vfs->isCaseSensitive; }
 

vfs/tests/Makefile

@@ -1,4 +1,4 @@
-GCC=g++ -I../
+GCC=g++ -I../ -Wall
 
 all: dummy_test ogre_client_test ogre_resource_test ogre_server_test physfs_server_test
 

vfs/tests/dummy_test.cpp

@@ -17,7 +17,7 @@ void print(FileInfoPtr inf) { print(*inf); }
 
 void print(FileInfoList &lst)
 {
-  for(int i=0; i<lst.size(); i++)
+  for(unsigned i=0; i<lst.size(); i++)
     print(lst[i]);
 }
 void print(FileInfoListPtr lst) { print(*lst); }