From 41606a67e4bad4184841ac2f492f309fa2f233a5 Mon Sep 17 00:00:00 2001
From: Marek Kochanowicz <sirherrbatka@gmail.com>
Date: Sat, 15 Feb 2014 20:49:09 +0100
Subject: [PATCH] implemented whitelist of allowed types in the scripts

---
 apps/opencs/view/world/scriptedit.cpp | 41 +++++++++++++++++++++++----
 apps/opencs/view/world/scriptedit.hpp |  5 ++++
 2 files changed, 41 insertions(+), 5 deletions(-)

diff --git a/apps/opencs/view/world/scriptedit.cpp b/apps/opencs/view/world/scriptedit.cpp
index 4eb652add..20b76ad72 100644
--- a/apps/opencs/view/world/scriptedit.cpp
+++ b/apps/opencs/view/world/scriptedit.cpp
@@ -1,25 +1,51 @@
 #include "scriptedit.hpp"
 
-#include <vector>
-
 #include <QDragEnterEvent>
 
 #include "../../model/world/universalid.hpp"
 #include "../../model/world/tablemimedata.hpp"
 
 CSVWorld::ScriptEdit::ScriptEdit (QWidget* parent) :
-QTextEdit(parent)
+    QTextEdit (parent)
 {
-
+    mAllowedTypes <<CSMWorld::UniversalId::Type_Journal
+                  <<CSMWorld::UniversalId::Type_JournalInfo
+                  <<CSMWorld::UniversalId::Type_Global
+                  <<CSMWorld::UniversalId::Type_Sound
+                  <<CSMWorld::UniversalId::Type_Spell
+                  <<CSMWorld::UniversalId::Type_Cell
+                  <<CSMWorld::UniversalId::Type_Referenceable
+                  <<CSMWorld::UniversalId::Type_Activator
+                  <<CSMWorld::UniversalId::Type_Potion
+                  <<CSMWorld::UniversalId::Type_Apparatus
+                  <<CSMWorld::UniversalId::Type_Armor
+                  <<CSMWorld::UniversalId::Type_Book
+                  <<CSMWorld::UniversalId::Type_Clothing
+                  <<CSMWorld::UniversalId::Type_Container
+                  <<CSMWorld::UniversalId::Type_Creature
+                  <<CSMWorld::UniversalId::Type_Door
+                  <<CSMWorld::UniversalId::Type_Ingredient
+                  <<CSMWorld::UniversalId::Type_CreatureLevelledList
+                  <<CSMWorld::UniversalId::Type_ItemLevelledList
+                  <<CSMWorld::UniversalId::Type_Light
+                  <<CSMWorld::UniversalId::Type_Lockpick
+                  <<CSMWorld::UniversalId::Type_Miscellaneous
+                  <<CSMWorld::UniversalId::Type_Npc
+                  <<CSMWorld::UniversalId::Type_Probe
+                  <<CSMWorld::UniversalId::Type_Repair
+                  <<CSMWorld::UniversalId::Type_Static
+                  <<CSMWorld::UniversalId::Type_Weapon;
 }
 
 void CSVWorld::ScriptEdit::dragEnterEvent (QDragEnterEvent* event)
 {
+    setTextCursor (cursorForPosition (event->pos()));
     event->acceptProposedAction();
 }
 
 void CSVWorld::ScriptEdit::dragMoveEvent (QDragMoveEvent* event)
 {
+    setTextCursor (cursorForPosition (event->pos()));
     event->accept();
 }
 
@@ -27,11 +53,16 @@ void CSVWorld::ScriptEdit::dropEvent (QDropEvent* event)
 {
     const CSMWorld::TableMimeData* mime = dynamic_cast<const CSMWorld::TableMimeData*> (event->mimeData());
 
+    setTextCursor (cursorForPosition (event->pos()));
+
     std::vector<CSMWorld::UniversalId> records (mime->getData());
 
     for (std::vector<CSMWorld::UniversalId>::iterator it = records.begin(); it != records.end(); ++it)
     {
-        insertPlainText (QString::fromStdString (it->getId()));
+        if (mAllowedTypes.contains (it->getType()))
+        {
+            insertPlainText (QString::fromStdString (it->getId() + " "));
+        }
     }
 }
 // kate: indent-mode cstyle; indent-width 4; replace-tabs on; 
diff --git a/apps/opencs/view/world/scriptedit.hpp b/apps/opencs/view/world/scriptedit.hpp
index 6df4acc5f..5355b57ce 100644
--- a/apps/opencs/view/world/scriptedit.hpp
+++ b/apps/opencs/view/world/scriptedit.hpp
@@ -2,6 +2,9 @@
 #define SCRIPTEDIT_H
 
 #include <qtextedit.h>
+#include <QVector>
+
+#include "../../model/world/universalid.hpp"
 
 class QWidget;
 
@@ -14,6 +17,8 @@ namespace CSVWorld
             ScriptEdit (QWidget* parent);
 
         private:
+            QVector<CSMWorld::UniversalId::Type> mAllowedTypes;
+
             void dragEnterEvent (QDragEnterEvent* event);
 
             void dropEvent (QDropEvent* event);