[General] Add comments to false-positive PVS messages

apps/openmw-mp/processors/ObjectProcessor.cpp

@@ -31,7 +31,7 @@ bool ObjectProcessor::Process(RakNet::Packet &packet, BaseObjectList &objectList
             if (!processor.second->avoidReading)
                 myPacket->Read();
 
-            if (objectList.isValid) // -V547
+            if (objectList.isValid) // -V547 (PVS Studio false-positive warning)
                 processor.second->Do(*myPacket, *player, objectList);
             else
                 LOG_MESSAGE_SIMPLE(Log::LOG_ERROR, "Received %s that failed integrity check and was ignored!", processor.second->strPacketID.c_str());

apps/openmw-mp/processors/WorldstateProcessor.cpp

@@ -28,7 +28,7 @@ bool WorldstateProcessor::Process(RakNet::Packet &packet, BaseWorldstate &worlds
             if (!processor.second->avoidReading)
                 myPacket->Read();
 
-            if (worldstate.isValid) // -V547
+            if (worldstate.isValid) // -V547 (PVS Studio false-positive warning)
                 processor.second->Do(*myPacket, *player, worldstate);
             else
                 LOG_MESSAGE_SIMPLE(Log::LOG_ERROR, "Received %s that failed integrity check and was ignored!", processor.second->strPacketID.c_str());

apps/openmw/mwmp/MechanicsHelper.cpp

@@ -146,14 +146,11 @@ mwmp::Target MechanicsHelper::getTarget(const MWWorld::Ptr& ptr)
         {
             MWWorld::CellRef *ptrRef = &ptr.getCellRef();
 
-            if (ptrRef)
+            target.isPlayer = false;
-            {
+            target.refId = ptrRef->getRefId();
-                target.isPlayer = false;
+            target.refNum = ptrRef->getRefNum().mIndex;
-                target.refId = ptrRef->getRefId();
+            target.mpNum = ptrRef->getMpNum();
-                target.refNum = ptrRef->getRefNum().mIndex;
+            target.name = ptr.getClass().getName(ptr);
-                target.mpNum = ptrRef->getMpNum();
-                target.name = ptr.getClass().getName(ptr);
-            }
         }
     }
 

apps/openmw/mwmp/RecordHelper.cpp

@@ -453,8 +453,6 @@ void RecordHelper::overrideArmorRecord(const mwmp::ArmorRecord& record)
         ESM::Armor finalData = *baseData;
         finalData.mId = recordData.mId;
 
-        finalData.mParts.mParts.at(0);
-
         if (record.baseOverrides.hasName)
             finalData.mName = recordData.mName;
 

apps/openmw/mwmp/processors/ActorProcessor.cpp

@@ -36,7 +36,7 @@ bool ActorProcessor::Process(RakNet::Packet &packet, ActorList &actorList)
                 myPacket->Read();
             }
 
-            if (actorList.isValid)
+            if (actorList.isValid) // -V547 (PVS Studio false-positive warning)
                 processor.second->Do(*myPacket, actorList);
             else
                 LOG_MESSAGE_SIMPLE(Log::LOG_ERROR, "Received %s that failed integrity check and was ignored!", processor.second->strPacketID.c_str());

apps/openmw/mwmp/processors/ObjectProcessor.cpp

@@ -31,7 +31,7 @@ bool ObjectProcessor::Process(RakNet::Packet &packet, ObjectList &objectList)
             if (!request && !processor.second->avoidReading)
                 myPacket->Read();
 
-            if (objectList.isValid)
+            if (objectList.isValid) // -V547 (PVS Studio false-positive warning)
                 processor.second->Do(*myPacket, objectList);
             else
                 LOG_MESSAGE_SIMPLE(Log::LOG_ERROR, "Received %s that failed integrity check and was ignored!", processor.second->strPacketID.c_str());

apps/openmw/mwmp/processors/WorldstateProcessor.cpp

@@ -31,7 +31,7 @@ bool WorldstateProcessor::Process(RakNet::Packet &packet, Worldstate &worldstate
             if (!request && !processor.second->avoidReading)
                 myPacket->Read();
 
-            if (worldstate.isValid)
+            if (worldstate.isValid) // -V547 (PVS Studio false-positive warning)
                 processor.second->Do(*myPacket, worldstate);
             else
                 LOG_MESSAGE_SIMPLE(Log::LOG_ERROR, "Received %s that failed integrity check and was ignored!", processor.second->strPacketID.c_str());

apps/openmw/mwmp/processors/player/ProcessorPlayerCellState.hpp

@@ -11,7 +11,7 @@ namespace mwmp
         ProcessorPlayerCellState()
         {
             BPP_INIT(ID_PLAYER_CELL_STATE)
-            avoidReading = true;
+            avoidReading = true; // -V519 (PVS Studio false-positive warning)
         }
 
         virtual void Do(PlayerPacket &packet, BasePlayer *player)

apps/openmw/mwmp/processors/player/ProcessorPlayerDeath.hpp

@@ -16,7 +16,7 @@ namespace mwmp
         ProcessorPlayerDeath()
         {
             BPP_INIT(ID_PLAYER_DEATH)
-            avoidReading = true;
+            avoidReading = true; // -V519 (PVS Studio false-positive warning)
         }
 
         virtual void Do(PlayerPacket &packet, BasePlayer *player)

apps/openmw/mwmp/processors/player/ProcessorUserDisconnected.hpp

@@ -18,7 +18,7 @@ namespace mwmp
         ProcessorUserDisconnected()
         {
             BPP_INIT(ID_USER_DISCONNECTED)
-            avoidReading = true;
+            avoidReading = true; // -V519 (PVS Studio false-positive warning)
         }
 
         virtual void Do(PlayerPacket &packet, BasePlayer *player)