fix gender selection update, main model visibility and couple of crashes

apps/openmw/mwgui/charactercreation.cpp

@@ -461,10 +461,10 @@ void CharacterCreation::onRaceDialogBack()
     if (mRaceDialog)
     {
         const ESM::NPC &data = mRaceDialog->getResult();
-        mPlayerRaceId = data.mId;
+        mPlayerRaceId = data.mRace;
         if (!mPlayerRaceId.empty()) {
             MWBase::Environment::get().getMechanicsManager()->setPlayerRace(
-                data.mId,
+                data.mRace,
                 data.isMale(),
                 data.mHead,
                 data.mHair

apps/openmw/mwgui/race.cpp

@@ -5,6 +5,7 @@
 
 #include <boost/algorithm/string.hpp>
 #include <boost/lexical_cast.hpp>
+#include <boost/format.hpp>
 
 #include "../mwworld/esmstore.hpp"
 
@@ -108,6 +109,8 @@ void RaceDialog::open()
     MWBase::Environment::get().getWorld ()->setupExternalRendering (*mPreview);
     mPreview->update (0);
 
+    setRaceId(mPreview->getPrototype().mRace);
+
     mPreviewImage->setImageTexture ("CharacterHeadPreview");
 }
 
@@ -174,11 +177,21 @@ void RaceDialog::onHeadRotate(MyGUI::ScrollBar*, size_t _position)
 void RaceDialog::onSelectPreviousGender(MyGUI::Widget*)
 {
     mGenderIndex = wrap(mGenderIndex - 1, 2);
+
+    mFaceIndex = 0;
+    mHairIndex = 0;
+
+    updatePreview();
 }
 
 void RaceDialog::onSelectNextGender(MyGUI::Widget*)
 {
     mGenderIndex = wrap(mGenderIndex + 1, 2);
+
+    mFaceIndex = 0;
+    mHairIndex = 0;
+
+    updatePreview();
 }
 
 void RaceDialog::onSelectPreviousFace(MyGUI::Widget*)
@@ -215,6 +228,18 @@ void RaceDialog::onSelectRace(MyGUI::ListBox* _sender, size_t _index)
 
     mCurrentRaceId = *raceId;
 
+    mFaceIndex = 0;
+    mHairIndex = 0;
+
+    updatePreview();
+    updateSkills();
+    updateSpellPowers();
+}
+
+// update widget content
+
+void RaceDialog::updatePreview()
+{
     ESM::NPC record = mPreview->getPrototype();
     record.mRace = mCurrentRaceId;
     record.setIsMale(mGenderIndex == 0);
@@ -222,27 +247,21 @@ void RaceDialog::onSelectRace(MyGUI::ListBox* _sender, size_t _index)
     std::string prefix =
         "b_n_" + mCurrentRaceId + ((record.isMale()) ? "_m_" : "_f_");
 
-    record.mHead = prefix + "head_01";
+    std::string headIndex = (boost::format("%02d") % (mFaceIndex + 1)).str();
-    record.mHair = prefix + "hair_01";
+    std::string hairIndex = (boost::format("%02d") % (mHairIndex + 1)).str();
+
+    record.mHead = prefix + "head_" + headIndex;
+    record.mHair = prefix + "hair_" + hairIndex;
 
     const MWWorld::Store<ESM::BodyPart> &parts =
         MWBase::Environment::get().getWorld()->getStore().get<ESM::BodyPart>();
 
     if (parts.search(record.mHair) == 0) {
-        record.mHair = prefix + "hair01";
+        record.mHair = prefix + "hair" + hairIndex;
     }
-
-    mFaceIndex = 0;
-    mHairIndex = 0;
-
     mPreview->setPrototype(record);
-
-    updateSkills();
-    updateSpellPowers();
 }
 
-// update widget content
-
 void RaceDialog::updateRaces()
 {
     mRaceList->removeAllItems();

apps/openmw/mwgui/race.hpp

@@ -78,6 +78,7 @@ namespace MWGui
         void updateRaces();
         void updateSkills();
         void updateSpellPowers();
+        void updatePreview();
 
         MyGUI::ImageBox*  mPreviewImage;
         MyGUI::ListBox*   mRaceList;

apps/openmw/mwrender/animation.cpp

@@ -7,7 +7,6 @@
 #include <OgreSubMesh.h>
 #include <OgreSceneManager.h>
 
-
 namespace MWRender
 {
 

apps/openmw/mwrender/player.cpp

@@ -310,10 +310,13 @@ namespace MWRender
 
     void Player::setAnimation(NpcAnimation *anim)
     {
-        if (mAnimation) {
+        delete mAnimation;
-            delete mAnimation;
-        }
         mAnimation = anim;
+
+        mPlayerNode->setVisible(
+            mVanity.enabled || mPreviewMode || !mFirstPersonView,
+            false
+        );
     }
 
     void Player::setHeight(float height)