mirror of
https://github.com/TES3MP/openmw-tes3mp.git
synced 2025-02-20 20:09:41 +00:00
Move the user preference check to the preparation step before the running of the operation.
This commit is contained in:
parent
00c165d3a5
commit
734e52d1c8
2 changed files with 13 additions and 15 deletions
|
@ -16,17 +16,14 @@ CSMTools::PathgridCheckStage::PathgridCheckStage (const CSMWorld::SubCellCollect
|
|||
|
||||
int CSMTools::PathgridCheckStage::setup()
|
||||
{
|
||||
CSMSettings::UserSettings &userSettings = CSMSettings::UserSettings::instance();
|
||||
mExtraCheck = userSettings.setting ("verifier/pathgrid-extra-check", QString ("false"))=="true";
|
||||
|
||||
return mPathgrids.getSize();
|
||||
}
|
||||
|
||||
void CSMTools::PathgridCheckStage::perform (int stage, CSMDoc::Messages& messages)
|
||||
{
|
||||
// NOTE: This is horribly inefficient but in order to use signals the entire Stage class
|
||||
// hierarchy needs to be braught under Qt which seems like an overkill for a small
|
||||
// performance gain during verify operations
|
||||
CSMSettings::UserSettings &userSettings = CSMSettings::UserSettings::instance();
|
||||
bool extraCheck = userSettings.setting ("verifier/pathgrid-extra-check", QString ("false"))=="true";
|
||||
|
||||
const CSMWorld::Record<CSMWorld::Pathgrid>& record = mPathgrids.getRecord (stage);
|
||||
|
||||
if (record.isDeleted())
|
||||
|
@ -113,7 +110,7 @@ void CSMTools::PathgridCheckStage::perform (int stage, CSMDoc::Messages& message
|
|||
}
|
||||
}
|
||||
|
||||
if (!extraCheck)
|
||||
if (!mExtraCheck)
|
||||
continue;
|
||||
|
||||
// check duplicate points
|
||||
|
@ -144,7 +141,7 @@ void CSMTools::PathgridCheckStage::perform (int stage, CSMDoc::Messages& message
|
|||
}
|
||||
}
|
||||
|
||||
if (!extraCheck)
|
||||
if (!mExtraCheck)
|
||||
return;
|
||||
|
||||
// check pathgrid points that are not connected to anything
|
||||
|
|
|
@ -24,17 +24,18 @@ namespace CSMTools
|
|||
|
||||
class PathgridCheckStage : public CSMDoc::Stage
|
||||
{
|
||||
const CSMWorld::SubCellCollection<CSMWorld::Pathgrid,
|
||||
CSMWorld::IdAccessor<CSMWorld::Pathgrid> >& mPathgrids;
|
||||
bool mExtraCheck;
|
||||
const CSMWorld::SubCellCollection<CSMWorld::Pathgrid,
|
||||
CSMWorld::IdAccessor<CSMWorld::Pathgrid> >& mPathgrids;
|
||||
|
||||
public:
|
||||
public:
|
||||
|
||||
PathgridCheckStage (const CSMWorld::SubCellCollection<CSMWorld::Pathgrid,
|
||||
CSMWorld::IdAccessor<CSMWorld::Pathgrid> >& pathgrids);
|
||||
PathgridCheckStage (const CSMWorld::SubCellCollection<CSMWorld::Pathgrid,
|
||||
CSMWorld::IdAccessor<CSMWorld::Pathgrid> >& pathgrids);
|
||||
|
||||
virtual int setup();
|
||||
virtual int setup();
|
||||
|
||||
virtual void perform (int stage, CSMDoc::Messages& messages);
|
||||
virtual void perform (int stage, CSMDoc::Messages& messages);
|
||||
};
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue