From 4999c667b62654ba580bcd9cdb9ebeb784f5797d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miloslav=20=C4=8C=C3=AD=C5=BE?= <tastyfish@sznam.cz>
Date: Fri, 29 Sep 2017 19:56:16 +0200
Subject: [PATCH] fix rain ripple bug

---
 apps/openmw/mwrender/renderingmanager.cpp |  9 ++++++++-
 apps/openmw/mwrender/renderingmanager.hpp |  2 ++
 apps/openmw/mwrender/sky.cpp              | 10 ++++++++++
 apps/openmw/mwrender/sky.hpp              |  4 ++++
 4 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/apps/openmw/mwrender/renderingmanager.cpp b/apps/openmw/mwrender/renderingmanager.cpp
index 23fc4ec28..3826fd5f6 100644
--- a/apps/openmw/mwrender/renderingmanager.cpp
+++ b/apps/openmw/mwrender/renderingmanager.cpp
@@ -504,6 +504,9 @@ namespace MWRender
             mWater->update(dt);
         }
 
+        if (!mSky->isEnabled() || !mSky->hasRain())
+          clearRainRipples();
+
         mCamera->update(dt, paused);
 
         osg::Vec3f focal, cameraPos;
@@ -803,7 +806,11 @@ namespace MWRender
     {
         mEffectManager->clear();
         mWater->clearRipples();
-        mUniformRainIntensity->set((float) 0.0);  // for interiors
+    }
+
+    void RenderingManager::clearRainRipples()
+    {
+        mUniformRainIntensity->set((float) 0.0);
     }
 
     void RenderingManager::clear()
diff --git a/apps/openmw/mwrender/renderingmanager.hpp b/apps/openmw/mwrender/renderingmanager.hpp
index 1673003c4..43059ab6d 100644
--- a/apps/openmw/mwrender/renderingmanager.hpp
+++ b/apps/openmw/mwrender/renderingmanager.hpp
@@ -160,6 +160,8 @@ namespace MWRender
         /// Clear all worldspace-specific data
         void notifyWorldSpaceChanged();
 
+        void clearRainRipples();
+
         void update(float dt, bool paused);
 
         Animation* getAnimation(const MWWorld::Ptr& ptr);
diff --git a/apps/openmw/mwrender/sky.cpp b/apps/openmw/mwrender/sky.cpp
index 5bf5dbcb3..178c753c6 100644
--- a/apps/openmw/mwrender/sky.cpp
+++ b/apps/openmw/mwrender/sky.cpp
@@ -1431,6 +1431,16 @@ int SkyManager::getSecundaPhase() const
     return mSecunda->getPhaseInt();
 }
 
+bool SkyManager::isEnabled()
+{
+    return mEnabled;
+}
+
+bool SkyManager::hasRain()
+{
+    return mRainNode != NULL;
+}
+
 void SkyManager::update(float duration)
 {
     if (!mEnabled) return;
diff --git a/apps/openmw/mwrender/sky.hpp b/apps/openmw/mwrender/sky.hpp
index 8278c7101..59a8ddc4e 100644
--- a/apps/openmw/mwrender/sky.hpp
+++ b/apps/openmw/mwrender/sky.hpp
@@ -138,6 +138,10 @@ namespace MWRender
 
         void sunDisable();
 
+        bool isEnabled();
+
+        bool hasRain();
+
         void setRainSpeed(float speed);
 
         void setStormDirection(const osg::Vec3f& direction);