From 7fcb22b867ce009e319584feab201282348c791f Mon Sep 17 00:00:00 2001 From: Andrei Kortunov Date: Tue, 27 Jun 2017 15:54:16 +0400 Subject: [PATCH] Do not show empty journal entries (fixes #3891) --- apps/openmw/mwdialogue/journalimp.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/apps/openmw/mwdialogue/journalimp.cpp b/apps/openmw/mwdialogue/journalimp.cpp index f11ec651d..27a3b31b5 100644 --- a/apps/openmw/mwdialogue/journalimp.cpp +++ b/apps/openmw/mwdialogue/journalimp.cpp @@ -85,13 +85,15 @@ namespace MWDialogue StampedJournalEntry entry = StampedJournalEntry::makeFromQuest (id, index, actor); - mJournal.push_back (entry); - Quest& quest = getQuest (id); - quest.addEntry (entry); // we are doing slicing on purpose here - MWBase::Environment::get().getWindowManager()->messageBox ("#{sJournalEntry}"); + // there is no need to show empty entries in journal + if (!entry.getText().empty()) + { + mJournal.push_back (entry); + MWBase::Environment::get().getWindowManager()->messageBox ("#{sJournalEntry}"); + } } void Journal::setJournalIndex (const std::string& id, int index)