Merge pull request #3044 from akortunov/master

Avoid null dereference for objects without cells
pull/593/head
Bret Curtis 4 years ago committed by GitHub
commit 9f168eab88
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -1337,6 +1337,12 @@ namespace MWWorld
void World::adjustPosition(const Ptr &ptr, bool force)
{
if (ptr.isEmpty())
{
Log(Debug::Warning) << "Unable to adjust position for empty object";
return;
}
osg::Vec3f pos (ptr.getRefData().getPosition().asVec3());
if(!ptr.getRefData().getBaseNode())
@ -1345,6 +1351,12 @@ namespace MWWorld
return;
}
if (!ptr.isInCell())
{
Log(Debug::Warning) << "Unable to adjust position for object '" << ptr.getCellRef().getRefId() << "' - it has no cell";
return;
}
const float terrainHeight = ptr.getCell()->isExterior() ? getTerrainHeightAt(pos) : -std::numeric_limits<float>::max();
pos.z() = std::max(pos.z(), terrainHeight) + 20; // place slightly above terrain. will snap down to ground with code below

Loading…
Cancel
Save