Implement enchantment record effect list verification (feature #1617)

apps/opencs/model/tools/enchantmentcheck.cpp

@@ -38,5 +38,45 @@ void CSMTools::EnchantmentCheckStage::perform (int stage, CSMDoc::Messages& mess
     if (enchantment.mData.mCharge < 0)
         messages.add(id, "Charge is negative", "", CSMDoc::Message::Severity_Error);
 
-    /// \todo Check effects list for validity
+    if (enchantment.mData.mCost > enchantment.mData.mCharge)
+        messages.add(id, "Cost is higher than charge", "", CSMDoc::Message::Severity_Error);
+
+    if (enchantment.mEffects.mList.empty())
+    {
+        messages.add(id, "Enchantment doesn't have any magic effects", "", CSMDoc::Message::Severity_Warning);
+    }
+    else
+    {
+        std::vector<ESM::ENAMstruct>::const_iterator effect = enchantment.mEffects.mList.begin();
+
+        for (size_t i = 1; i <= enchantment.mEffects.mList.size(); i++)
+        {
+            const std::string number = std::to_string(i);
+            // At the time of writing this effects, attributes and skills are hardcoded
+            if (effect->mEffectID < 0 || effect->mEffectID > 142)
+            {
+                messages.add(id, "Effect #" + number + " is invalid", "", CSMDoc::Message::Severity_Error);
+                ++effect;
+                continue;
+            }
+
+            if (effect->mSkill < -1 || effect->mSkill > 26)
+                messages.add(id, "Effect #" + number + " affected skill is invalid", "", CSMDoc::Message::Severity_Error);
+            if (effect->mAttribute < -1 || effect->mAttribute > 7)
+                messages.add(id, "Effect #" + number + " affected attribute is invalid", "", CSMDoc::Message::Severity_Error);
+            if (effect->mRange < 0 || effect->mRange > 2)
+                messages.add(id, "Effect #" + number + " range is invalid", "", CSMDoc::Message::Severity_Error);
+            if (effect->mArea < 0)
+                messages.add(id, "Effect #" + number + " area is negative", "", CSMDoc::Message::Severity_Error);
+            if (effect->mDuration < 0)
+                messages.add(id, "Effect #" + number + " duration is negative", "", CSMDoc::Message::Severity_Error);
+            if (effect->mMagnMin < 0)
+                messages.add(id, "Effect #" + number + " minimum magnitude is negative", "", CSMDoc::Message::Severity_Error);
+            if (effect->mMagnMax < 0)
+                messages.add(id, "Effect #" + number + " maximum magnitude is negative", "", CSMDoc::Message::Severity_Error);
+            if (effect->mMagnMin > effect->mMagnMax)
+                messages.add(id, "Effect #" + number + " minimum magnitude is higher than maximum magnitude", "", CSMDoc::Message::Severity_Error);
+            ++effect;
+        }
+    }
 }

apps/opencs/model/tools/enchantmentcheck.hpp

@@ -24,6 +24,7 @@ namespace CSMTools
 
             virtual void perform (int stage, CSMDoc::Messages& messages);
             ///< Messages resulting from this tage will be appended to \a messages.
+
     };
 }