From d5689730eb2f4aee600367947246a4d245d664f0 Mon Sep 17 00:00:00 2001 From: Miroslav Puda Date: Sat, 18 May 2013 22:57:27 +0200 Subject: [PATCH] Removal of unnecessary variable. empty variable duplicates empty() method of std::string. Check for empty value should be replaced by assert since it does not makes much sense to call scanInt with null character. --- components/compiler/scanner.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/components/compiler/scanner.cpp b/components/compiler/scanner.cpp index 38e0c353d..d5095a50a 100644 --- a/components/compiler/scanner.cpp +++ b/components/compiler/scanner.cpp @@ -164,9 +164,7 @@ namespace Compiler bool Scanner::scanInt (char c, Parser& parser, bool& cont) { std::string value; - value += c; - bool empty = false; bool error = false; @@ -175,7 +173,6 @@ namespace Compiler if (std::isdigit (c)) { value += c; - empty = false; } else if (std::isalpha (c) || c=='_') error = true; @@ -190,7 +187,11 @@ namespace Compiler } } - if (empty || error) + /* + * value could be empty only if scanInt is called with c == '\0'. + * That is unlikely so it should be replaced by assertion. + */ + if (value.empty() || error) return false; TokenLoc loc (mLoc);