openmw-tes3mp

You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

History

scrawl 115e563a7a Fix race conditions caused by Array <-> GLBufferObject interactions (Bug #3580 ) The first part of the fix is to assign VBO/EBO's upon loading the array in the Nif reader. This avoids triggering the 'addVertexBufferObjectIfRequired' code path in osg::Geometry which has the race condition when two threads add the same Array at the same time. Essentially, we want the Arrays to be 'const' when they come out of the Nif reader. The second part of the fix is to make sure not to create empty arrays in the Nif reader (importantly, not assigning a VBO to the empty array). This empty array would be deleted when the NIFFile is cleaned up, and the detachment of the VBO assigned to it (which is still in use by other arrays) would cause threading issues. This rare crash bug was first introduced with commit `a7c5beb7c5`. When using OSG dev version 3.5 the crashes were a little more prevalent, because 'addVertexBufferObjectIfRequired' in osg::Geometry is now used even when VBO's are disabled (as part of the VAO support changes).	8 years ago
..
bulletnifloader.cpp	Fix race conditions caused by Array <-> GLBufferObject interactions (Bug #3580 )	8 years ago
bulletnifloader.hpp	Move BulletShapeManager and BulletShape to resource/	9 years ago

scrawl 115e563a7a Fix race conditions caused by Array <-> GLBufferObject interactions (Bug #3580 )

The first part of the fix is to assign VBO/EBO's upon loading the array in the Nif reader. This avoids triggering the 'addVertexBufferObjectIfRequired' code path in osg::Geometry which has the race condition when two threads add the same Array at the same time. Essentially, we want the Arrays to be 'const' when they come out of the Nif reader.

The second part of the fix is to make sure not to create empty arrays in the Nif reader (importantly, not assigning a VBO to the empty array). This empty array would be deleted when the NIFFile is cleaned up, and the detachment of the VBO assigned to it (which is still in use by other arrays) would cause threading issues.

This rare crash bug was first introduced with commit a7c5beb7c5. When using OSG dev version 3.5 the crashes were a little more prevalent, because 'addVertexBufferObjectIfRequired' in osg::Geometry is now used even when VBO's are disabled (as part of the VAO support changes).

bulletnifloader.cpp Fix race conditions caused by Array <-> GLBufferObject interactions (Bug #3580 ) 8 years ago

bulletnifloader.hpp Move BulletShapeManager and BulletShape to resource/ 9 years ago