mirror of
https://github.com/TES3MP/openmw-tes3mp.git
synced 2025-01-16 02:49:55 +00:00
9d61d76e92
Adds a boolean setting to the user preferences. This setting is locally saved to all OpenMW-CS check stages. When a verification is done, the setting is updated on setup for each check stage. If set to true, the boolean value is then used to skip the verification process for every base record - minus some special cases where, e.g., counters are to be set first. Related issue: - Fixes #4466: Editor: Add option to ignore base records when running verifier (https://gitlab.com/OpenMW/openmw/issues/4466) Tests: The changes were successfully tested in OpenMW-CS by creating faulty "Base" and "Modified" records for every record type (if possible) and, then, running the verifier with and without the option respectively.
130 lines
4.9 KiB
C++
130 lines
4.9 KiB
C++
#include "gmstcheck.hpp"
|
|
|
|
#include <sstream>
|
|
|
|
#include "../prefs/state.hpp"
|
|
|
|
#include "../world/defaultgmsts.hpp"
|
|
|
|
CSMTools::GmstCheckStage::GmstCheckStage(const CSMWorld::IdCollection<ESM::GameSetting>& gameSettings)
|
|
: mGameSettings(gameSettings)
|
|
{
|
|
mIgnoreBaseRecords = CSMPrefs::get()["Reports"]["ignore-base-records"].isTrue();
|
|
}
|
|
|
|
int CSMTools::GmstCheckStage::setup()
|
|
{
|
|
mIgnoreBaseRecords = CSMPrefs::get()["Reports"]["ignore-base-records"].isTrue();
|
|
|
|
return mGameSettings.getSize();
|
|
}
|
|
|
|
void CSMTools::GmstCheckStage::perform(int stage, CSMDoc::Messages& messages)
|
|
{
|
|
const CSMWorld::Record<ESM::GameSetting>& record = mGameSettings.getRecord (stage);
|
|
|
|
// Skip "Base" records (setting!) and "Deleted" records
|
|
if ((mIgnoreBaseRecords && record.isBaseOnly()) || record.isDeleted())
|
|
return;
|
|
|
|
const ESM::GameSetting& gmst = record.get();
|
|
|
|
CSMWorld::UniversalId id (CSMWorld::UniversalId::Type_Gmst, gmst.mId);
|
|
|
|
// Test for empty string
|
|
if (gmst.mValue.getType() == ESM::VT_String && gmst.mValue.getString().empty())
|
|
messages.add(id, gmst.mId + " is an empty string", "", CSMDoc::Message::Severity_Warning);
|
|
|
|
// Checking type and limits
|
|
// optimization - compare it to lists based on naming convention (f-float,i-int,s-string)
|
|
if (gmst.mId[0] == 'f')
|
|
{
|
|
for (size_t i = 0; i < CSMWorld::DefaultGmsts::FloatCount; ++i)
|
|
{
|
|
if (gmst.mId == CSMWorld::DefaultGmsts::Floats[i])
|
|
{
|
|
if (gmst.mValue.getType() != ESM::VT_Float)
|
|
{
|
|
std::ostringstream stream;
|
|
stream << "Expected float type for " << gmst.mId << " but found "
|
|
<< varTypeToString(gmst.mValue.getType()) << " type";
|
|
|
|
messages.add(id, stream.str(), "", CSMDoc::Message::Severity_Error);
|
|
}
|
|
|
|
if (gmst.mValue.getFloat() < CSMWorld::DefaultGmsts::FloatLimits[i*2])
|
|
messages.add(id, gmst.mId + " is less than the suggested range", "",
|
|
CSMDoc::Message::Severity_Warning);
|
|
|
|
if (gmst.mValue.getFloat() > CSMWorld::DefaultGmsts::FloatLimits[i*2+1])
|
|
messages.add(id, gmst.mId + " is more than the suggested range", "",
|
|
CSMDoc::Message::Severity_Warning);
|
|
|
|
break; // for loop
|
|
}
|
|
}
|
|
}
|
|
else if (gmst.mId[0] == 'i')
|
|
{
|
|
for (size_t i = 0; i < CSMWorld::DefaultGmsts::IntCount; ++i)
|
|
{
|
|
if (gmst.mId == CSMWorld::DefaultGmsts::Ints[i])
|
|
{
|
|
if (gmst.mValue.getType() != ESM::VT_Int)
|
|
{
|
|
std::ostringstream stream;
|
|
stream << "Expected int type for " << gmst.mId << " but found "
|
|
<< varTypeToString(gmst.mValue.getType()) << " type";
|
|
|
|
messages.add(id, stream.str(), "", CSMDoc::Message::Severity_Error);
|
|
}
|
|
|
|
if (gmst.mValue.getInteger() < CSMWorld::DefaultGmsts::IntLimits[i*2])
|
|
messages.add(id, gmst.mId + " is less than the suggested range", "",
|
|
CSMDoc::Message::Severity_Warning);
|
|
|
|
if (gmst.mValue.getInteger() > CSMWorld::DefaultGmsts::IntLimits[i*2+1])
|
|
messages.add(id, gmst.mId + " is more than the suggested range", "",
|
|
CSMDoc::Message::Severity_Warning);
|
|
|
|
break; // for loop
|
|
}
|
|
}
|
|
}
|
|
else if (gmst.mId[0] == 's')
|
|
{
|
|
for (size_t i = 0; i < CSMWorld::DefaultGmsts::StringCount; ++i)
|
|
{
|
|
if (gmst.mId == CSMWorld::DefaultGmsts::Strings[i])
|
|
{
|
|
ESM::VarType type = gmst.mValue.getType();
|
|
|
|
if (type != ESM::VT_String && type != ESM::VT_None)
|
|
{
|
|
std::ostringstream stream;
|
|
stream << "Expected string or none type for " << gmst.mId << " but found "
|
|
<< varTypeToString(gmst.mValue.getType()) << " type";
|
|
|
|
messages.add(id, stream.str(), "", CSMDoc::Message::Severity_Error);
|
|
}
|
|
|
|
break; // for loop
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
std::string CSMTools::GmstCheckStage::varTypeToString(ESM::VarType type)
|
|
{
|
|
switch (type)
|
|
{
|
|
case ESM::VT_Unknown: return "unknown";
|
|
case ESM::VT_None: return "none";
|
|
case ESM::VT_Short: return "short";
|
|
case ESM::VT_Int: return "int";
|
|
case ESM::VT_Long: return "long";
|
|
case ESM::VT_Float: return "float";
|
|
case ESM::VT_String: return "string";
|
|
default: return "unhandled";
|
|
}
|
|
}
|