openmw/components/esm3/quickkeys.hpp

#ifndef OPENMW_COMPONENTS_ESM_QUICKKEYS_H
#define OPENMW_COMPONENTS_ESM_QUICKKEYS_H

#include "components/esm/refid.hpp"
#include <string>
#include <vector>

namespace ESM
{
    class ESMReader;
    class ESMWriter;

    struct QuickKeys
    {
        struct QuickKey
        {
            int mType;
            RefId mId; // Spell or Item ID
        };

        std::vector<QuickKey> mKeys;

        void load(ESMReader& esm);
        void save(ESMWriter& esm) const;
    };

}

#endif
Move to esm component 2014-05-02 10:47:28 +00:00			`#ifndef OPENMW_COMPONENTS_ESM_QUICKKEYS_H`
			`#define OPENMW_COMPONENTS_ESM_QUICKKEYS_H`

create a specific esm reader function for RefID to avoid allocation for string and then again for RefId Fixed some types removed useless header applied clang format fixed compile tests fixed clang tidy, and closer to logic before this MR Removed hardcoded refids unless there is a returned value we don't use static RefIds can use == between RefId and hardcoded string Fix clang format Fixed a few instances where std::string was used, when only const std::string& was needed removed unused variable 2022-10-18 07:26:55 +00:00			`#include "components/esm/refid.hpp"`
Move to esm component 2014-05-02 10:47:28 +00:00			`#include <string>`
			`#include <vector>`

			`namespace ESM`
			`{`
			`class ESMReader;`
			`class ESMWriter;`

			`struct QuickKeys`
			`{`
			`struct QuickKey`
			`{`
			`int mType;`
Initial commit: In ESM structures, replace the string members that are RefIds to other records, to a new strong type The strong type is actually just a string underneath, but this will help in the future to have a distinction so it's easier to search and replace when we use an integer ID Slowly going through all the changes to make, still hundreds of errors a lot of functions/structures use std::string or stringview to designate an ID. So it takes time Continues slowly replacing ids. There are technically more and more compilation errors I have good hope that there is a point where the amount of errors will dramatically go down as all the main functions use the ESM::RefId type Continue moving forward, changes to the stores slowly moving along Starting to see the fruit of those changes. still many many error, but more and more Irun into a situation where a function is sandwiched between two functions that use the RefId type. More replacements. Things are starting to get easier I can see more and more often the issue is that the function is awaiting a RefId, but is given a string there is less need to go down functions and to fix a long list of them. Still moving forward, and for the first time error count is going down! Good pace, not sure about topics though, mId and mName are actually the same thing and are used interchangeably Cells are back to using string for the name, haven't fixed everything yet. Many other changes Under the bar of 400 compilation errors. more good progress <100 compile errors! More progress Game settings store can use string for find, it was a bit absurd how every use of it required to create refId from string some more progress on other fronts Mostly game settings clean one error opened a lot of other errors. Down to 18, but more will prbably appear only link errors left?? Fixed link errors OpenMW compiles, and launches, with some issues, but still! 2022-09-25 11:17:09 +00:00			`RefId mId; // Spell or Item ID`
Move to esm component 2014-05-02 10:47:28 +00:00			`};`

			`std::vector<QuickKey> mKeys;`

			`void load(ESMReader& esm);`
			`void save(ESMWriter& esm) const;`
			`};`

			`}`

			`#endif`