Improve window mode change (feature #7087)

CHANGELOG.md

@@ -35,6 +35,7 @@
     Feature #6983: PCVisionBonus script functions
     Feature #6995: Localize the "show effect duration" option
     Feature #7058: Implement TestModels (T3D) console command
+    Feature #7087: Block resolution change in the Windowed Fullscreen mode
 
 0.48.0
 ------

apps/openmw/mwgui/settingswindow.cpp

@@ -564,7 +564,18 @@ namespace MWGui
         if (pos == MyGUI::ITEM_NONE)
             return;
 
-        Settings::Manager::setInt("window mode", "Video", static_cast<int>(_sender->getIndexSelected()));
+        int index = static_cast<int>(_sender->getIndexSelected());
+        if (index == static_cast<size_t>(Settings::WindowMode::WindowedFullscreen))
+            mResolutionList->setEnabled(false);
+        else
+            mResolutionList->setEnabled(true);
+
+        if (index == static_cast<size_t>(Settings::WindowMode::Windowed))
+            mWindowBorderButton->setEnabled(true);
+        else
+            mWindowBorderButton->setEnabled(false);
+
+        Settings::Manager::setInt("window mode", "Video", index);
         apply();
     }
 
@@ -644,6 +655,12 @@ namespace MWGui
         apply();
     }
 
+    void SettingsWindow::onResChange(int width, int height)
+    {
+        center();
+        highlightCurrentResolution();
+    }
+
     void SettingsWindow::onSliderChangePosition(MyGUI::ScrollBar* scroller, size_t pos)
     {
         if (getSettingType(scroller) == "Slider")
@@ -839,6 +856,9 @@ namespace MWGui
 
             mWindowBorderButton->setEnabled(false);
         }
+
+        if (index == static_cast<size_t>(Settings::WindowMode::WindowedFullscreen))
+            mResolutionList->setEnabled(false);
     }
 
     void SettingsWindow::layoutControlsBox()

apps/openmw/mwgui/settingswindow.hpp

@@ -20,7 +20,7 @@ namespace MWGui
 
         void updateWindowModeSettings();
 
-        void onResChange(int, int) override { center(); }
+        void onResChange(int, int) override;
 
     protected:
         MyGUI::TabControl* mSettingsTab;