From 5b2691e7447dc8f5f82a0a14332b3452273669b3 Mon Sep 17 00:00:00 2001 From: AnyOldName3 Date: Fri, 15 Mar 2019 17:44:52 +0000 Subject: [PATCH 1/2] Actually use specular shininess parameter instead of hardcoded value. --- files/shaders/lighting.glsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/files/shaders/lighting.glsl b/files/shaders/lighting.glsl index 90d849472b..6de34bc075 100644 --- a/files/shaders/lighting.glsl +++ b/files/shaders/lighting.glsl @@ -78,5 +78,5 @@ vec3 getSpecular(vec3 viewNormal, vec3 viewDirection, float shininess, vec3 matS if (NdotL < 0.0) return vec3(0.,0.,0.); vec3 halfVec = normalize(lightDir - viewDirection); - return pow(max(dot(viewNormal, halfVec), 0.0), 128.) * gl_LightSource[0].specular.xyz * matSpec; + return pow(max(dot(viewNormal, halfVec), 0.0), shininess) * gl_LightSource[0].specular.xyz * matSpec; } From a92690d43393946953f14785c35f3099a3103cee Mon Sep 17 00:00:00 2001 From: AnyOldName3 Date: Fri, 15 Mar 2019 21:30:57 +0000 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3c0f476b86..2f3fcc3291 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -41,6 +41,7 @@ Bug #4877: Startup script executes only on a new game start Bug #4888: Global variable stray explicit reference calls break script compilation Bug #4911: Editor: QOpenGLContext::swapBuffers() warning with Qt5 + Bug #4916: Specular power (shininess) material parameter is ignored when shaders are used. Feature #2229: Improve pathfinding AI Feature #3442: Default values for fallbacks from ini file Feature #3610: Option to invert X axis