CLEANUP(CS): Do heightData check in actual implementation, revert

accidental change to land condition order

apps/opencs/view/render/cell.cpp

@@ -120,7 +120,7 @@ bool CSVRender::Cell::addObjects(int start, int end)
 
 void CSVRender::Cell::updateLand()
 {
-    if (mLandDeleted || !mUpdateLand)
+    if (!mUpdateLand || mLandDeleted)
         return;
 
     mUpdateLand = false;

apps/opencs/view/render/terrainstorage.cpp

@@ -154,6 +154,8 @@ namespace CSVRender
 
     void TerrainStorage::adjustColor(int col, int row, const ESM::LandData* heightData, osg::Vec4ub& color) const
     {
+        if (!heightData)
+            return;
         // Highlight broken height changes
         int heightWarningLimit = 1024;
         if (((col > 0 && row > 0) && leftOrUpIsOverTheLimit(col, row, heightWarningLimit, heightData->getHeights()))

components/esmterrain/storage.cpp

@@ -346,7 +346,7 @@ namespace ESMTerrain
                     color[i] = colourData->getColors()[srcArrayIndex + i];
 
             // Does nothing by default, override in OpenMW-CS
-            if (alteration && heightData != nullptr)
+            if (alteration)
                 adjustColor(col, row, heightData, color);
 
             // Unlike normals, colors mostly connect seamlessly between cells, but not always...