mirror/openmw
1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-11-08 21:46:43 +00:00
Code Issues Releases Wiki Activity

Prevent iterator invalidation when cleaning up summons

Browse source
This commit is contained in:
Evil Eye 2021-08-28 11:06:47 +02:00
parent dc1fe62dde
commit 161e042e2a
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
apps/openmw/mwgui/container.cpp
View file

@ -277,8 +277,9 @@ namespace MWGui
auto it = std::find_if(summons.begin(), summons.end(), [&] (const auto& entry) { return entry.second == creatureStats.getActorId(); }); auto it = std::find_if(summons.begin(), summons.end(), [&] (const auto& entry) { return entry.second == creatureStats.getActorId(); });
if(it != summons.end()) if(it != summons.end())
{ {
MWMechanics::purgeSummonEffect(summoner, *it); auto summon = *it;
summons.erase(it); summons.erase(it);
MWMechanics::purgeSummonEffect(summoner, summon);
break; break;
} }
} }

3
apps/openmw/mwmechanics/summoning.cpp
View file

@ -125,8 +125,9 @@ namespace MWMechanics
if (!ptr.isEmpty() && ptr.getClass().getCreatureStats(ptr).isDead() && ptr.getClass().getCreatureStats(ptr).isDeathAnimationFinished()) if (!ptr.isEmpty() && ptr.getClass().getCreatureStats(ptr).isDead() && ptr.getClass().getCreatureStats(ptr).isDeathAnimationFinished())
{ {
// Purge the magic effect so a new creature can be summoned if desired // Purge the magic effect so a new creature can be summoned if desired
purgeSummonEffect(summoner, *it); auto summon = *it;
creatureMap.erase(it++); creatureMap.erase(it++);
purgeSummonEffect(summoner, summon);
} }
else else
++it; ++it;