Address feedback

apps/openmw/mwrender/npcanimation.cpp

@@ -514,7 +514,7 @@ void NpcAnimation::updateNpcBase()
 
     if(!is1stPerson)
     {
-        const std::string& base = Settings::Manager::getString("xbaseanim", "Models");
+        const std::string base = Settings::Manager::getString("xbaseanim", "Models");
         if (smodel != base && !isWerewolf)
             addAnimSource(base, smodel);
 
@@ -528,7 +528,7 @@ void NpcAnimation::updateNpcBase()
     }
     else
     {
-        const std::string& base = Settings::Manager::getString("xbaseanim1st", "Models");
+        const std::string base = Settings::Manager::getString("xbaseanim1st", "Models");
         if (smodel != base && !isWerewolf)
             addAnimSource(base, smodel);
 

components/sceneutil/attach.cpp

@@ -26,7 +26,7 @@ namespace SceneUtil
         CopyRigVisitor(osg::ref_ptr<osg::Group> parent, std::string_view filter)
             : osg::NodeVisitor(TRAVERSE_ALL_CHILDREN)
             , mParent(parent)
-            , mFilter(std::move(filter))
+            , mFilter(filter)
         {
         }
 

components/sceneutil/visitor.hpp

@@ -20,7 +20,7 @@ namespace SceneUtil
     public:
         FindByNameVisitor(std::string_view nameToFind)
             : osg::NodeVisitor(TRAVERSE_ALL_CHILDREN)
-            , mNameToFind(std::move(nameToFind))
+            , mNameToFind(nameToFind)
             , mFoundNode(nullptr)
         {
         }
@@ -40,7 +40,7 @@ namespace SceneUtil
     public:
         FindByClassVisitor(std::string_view nameToFind)
             : osg::NodeVisitor(TRAVERSE_ALL_CHILDREN)
-            , mNameToFind(std::move(nameToFind))
+            , mNameToFind(nameToFind)
         {
         }