From 254f01b89dc681d638e93723df84c68f452fc057 Mon Sep 17 00:00:00 2001
From: Andrei Kortunov <andrei.kortunov@yandex.ru>
Date: Tue, 8 Jan 2019 20:42:08 +0400
Subject: [PATCH] RigGeometry optimization: vector iteration is more cheap than
 map iteration

---
 components/nifosg/nifloader.cpp      |  2 +-
 components/sceneutil/riggeometry.cpp | 26 +++++++++++++++-----------
 components/sceneutil/riggeometry.hpp |  9 +++++----
 3 files changed, 21 insertions(+), 16 deletions(-)

diff --git a/components/nifosg/nifloader.cpp b/components/nifosg/nifloader.cpp
index eb20b77021..431a2edd13 100644
--- a/components/nifosg/nifloader.cpp
+++ b/components/nifosg/nifloader.cpp
@@ -1098,7 +1098,7 @@ namespace NifOsg
                 influence.mInvBindMatrix = data->bones[i].trafo.toMatrix();
                 influence.mBoundSphere = osg::BoundingSpheref(data->bones[i].boundSphereCenter, data->bones[i].boundSphereRadius);
 
-                map->mMap.insert(std::make_pair(boneName, influence));
+                map->mData.emplace_back(boneName, influence);
             }
             rig->setInfluenceMap(map);
 
diff --git a/components/sceneutil/riggeometry.cpp b/components/sceneutil/riggeometry.cpp
index b086cf6288..bf43c2e709 100644
--- a/components/sceneutil/riggeometry.cpp
+++ b/components/sceneutil/riggeometry.cpp
@@ -136,20 +136,21 @@ bool RigGeometry::initFromParentSkeleton(osg::NodeVisitor* nv)
 
     typedef std::map<unsigned short, std::vector<BoneWeight> > Vertex2BoneMap;
     Vertex2BoneMap vertex2BoneMap;
-    for (std::map<std::string, BoneInfluence>::const_iterator it = mInfluenceMap->mMap.begin(); it != mInfluenceMap->mMap.end(); ++it)
+    mBoneSphereVector.clear();
+    for (auto& influencePair : mInfluenceMap->mData)
     {
-        Bone* bone = mSkeleton->getBone(it->first);
+        Bone* bone = mSkeleton->getBone(influencePair.first);
         if (!bone)
         {
-            Log(Debug::Error) << "Error: RigGeometry did not find bone " << it->first ;
+            Log(Debug::Error) << "Error: RigGeometry did not find bone " << influencePair.first;
             continue;
         }
 
-        mBoneSphereMap[bone] = it->second.mBoundSphere;
+        mBoneSphereVector.emplace_back(bone, influencePair.second.mBoundSphere);
 
-        const BoneInfluence& bi = it->second;
+        const BoneInfluence& bi = influencePair.second;
 
-        const std::map<unsigned short, float>& weights = it->second.mWeights;
+        const std::map<unsigned short, float>& weights = influencePair.second.mWeights;
         for (std::map<unsigned short, float>::const_iterator weightIt = weights.begin(); weightIt != weights.end(); ++weightIt)
         {
             std::vector<BoneWeight>& vec = vertex2BoneMap[weightIt->first];
@@ -160,11 +161,14 @@ bool RigGeometry::initFromParentSkeleton(osg::NodeVisitor* nv)
         }
     }
 
+    Bone2VertexMap bone2VertexMap;
     for (Vertex2BoneMap::iterator it = vertex2BoneMap.begin(); it != vertex2BoneMap.end(); ++it)
     {
-        mBone2VertexMap[it->second].push_back(it->first);
+        bone2VertexMap[it->second].push_back(it->first);
     }
 
+    mBone2VertexVector.assign(bone2VertexMap.begin(), bone2VertexMap.end());
+
     return true;
 }
 
@@ -201,7 +205,7 @@ void RigGeometry::cull(osg::NodeVisitor* nv)
     osg::Vec3Array* normalDst = static_cast<osg::Vec3Array*>(geom.getNormalArray());
     osg::Vec4Array* tangentDst = static_cast<osg::Vec4Array*>(geom.getTexCoordArray(7));
 
-    for (auto &pair : mBone2VertexMap)
+    for (auto &pair : mBone2VertexVector)
     {
         osg::Matrixf resultMat (0, 0, 0, 0,
                                 0, 0, 0, 0,
@@ -263,10 +267,10 @@ void RigGeometry::updateBounds(osg::NodeVisitor *nv)
     updateGeomToSkelMatrix(nv->getNodePath());
 
     osg::BoundingBox box;
-    for (BoneSphereMap::const_iterator it = mBoneSphereMap.begin(); it != mBoneSphereMap.end(); ++it)
+    for (auto& boundPair : mBoneSphereVector)
     {
-        Bone* bone = it->first;
-        osg::BoundingSpheref bs = it->second;
+        Bone* bone = boundPair.first;
+        osg::BoundingSpheref bs = boundPair.second;
         if (mGeomToSkelMatrix)
             transformBoundingSphere(bone->mMatrixInSkeletonSpace * (*mGeomToSkelMatrix), bs);
         else
diff --git a/components/sceneutil/riggeometry.hpp b/components/sceneutil/riggeometry.hpp
index 60b3edc9d8..1d51dfa593 100644
--- a/components/sceneutil/riggeometry.hpp
+++ b/components/sceneutil/riggeometry.hpp
@@ -36,7 +36,7 @@ namespace SceneUtil
 
         struct InfluenceMap : public osg::Referenced
         {
-            std::map<std::string, BoneInfluence> mMap;
+            std::vector<std::pair<std::string, BoneInfluence>> mData;
         };
 
         void setInfluenceMap(osg::ref_ptr<InfluenceMap> influenceMap);
@@ -73,12 +73,13 @@ namespace SceneUtil
         typedef std::vector<unsigned short> VertexList;
 
         typedef std::map<std::vector<BoneWeight>, VertexList> Bone2VertexMap;
+        typedef std::vector<std::pair<std::vector<BoneWeight>, VertexList>> Bone2VertexVector;
 
-        Bone2VertexMap mBone2VertexMap;
+        Bone2VertexVector mBone2VertexVector;
 
-        typedef std::map<Bone*, osg::BoundingSpheref> BoneSphereMap;
+        typedef std::vector<std::pair<Bone*, osg::BoundingSpheref>> BoneSphereVector;
 
-        BoneSphereMap mBoneSphereMap;
+        BoneSphereVector mBoneSphereVector;
 
         unsigned int mLastFrameNumber;
         bool mBoundsFirstFrame;