From 336a9e7da1cbdb497bde8823d9c5c92ef27a8d0e Mon Sep 17 00:00:00 2001 From: ddbb07 <31517774-ddbb07@users.noreply.gitlab.com> Date: Sun, 16 Nov 2025 21:54:36 +0100 Subject: [PATCH] Explicitly check if inputString is empty or only contains spaces in generatePatternArray to improve performance --- apps/openmw/mwgui/settingswindow.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/openmw/mwgui/settingswindow.cpp b/apps/openmw/mwgui/settingswindow.cpp index 2656d43d62..7ce7c0db8a 100644 --- a/apps/openmw/mwgui/settingswindow.cpp +++ b/apps/openmw/mwgui/settingswindow.cpp @@ -945,6 +945,8 @@ namespace MWGui { std::vector generatePatternArray(std::string inputString) { + if (inputString.empty() || inputString.find_first_not_of(" ") == std::string::npos) + return std::vector(); Misc::StringUtils::lowerCaseInPlace(inputString); std::istringstream stringStream(inputString); return { std::istream_iterator(stringStream), std::istream_iterator() };