From e4b28ebdceeb2495b75033b08800ff7ec0fce113 Mon Sep 17 00:00:00 2001 From: elsid Date: Sun, 2 Nov 2025 13:54:55 +0100 Subject: [PATCH] Fix clang-tidy checks Placing .clang-tidy into build/ folder hides some checks defined in the root file. Place them into more specific folders to not check generated files. --- .gitlab-ci.yml | 6 +++++- components/lua/util.hpp | 9 ++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 7fd145fe2c..edd7585cea 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -429,7 +429,11 @@ Ubuntu_Clang: - mkdir -pv "${CCACHE_DIR}" - ccache -z -M "${CCACHE_SIZE}" - CI/before_script.linux.sh - - cp extern/.clang-tidy build/.clang-tidy + - mkdir -p build/extern build/apps/launcher build/apps/opencs build/apps/wizard + - cp extern/.clang-tidy build/extern/ + - cp extern/.clang-tidy build/apps/launcher/ + - cp extern/.clang-tidy build/apps/opencs/ + - cp extern/.clang-tidy build/apps/wizard/ - cd build - find . -name *.o -exec touch {} \; - cmake --build . -- -j $(nproc) ${BUILD_TARGETS} diff --git a/components/lua/util.hpp b/components/lua/util.hpp index e664dc1f34..d3cb764831 100644 --- a/components/lua/util.hpp +++ b/components/lua/util.hpp @@ -2,7 +2,6 @@ #define COMPONENTS_LUA_UTIL_H #include -#include #include @@ -24,11 +23,11 @@ namespace LuaUtil // ADL-based customization point for sol2 to automatically convert ESM::RefId // Empty RefIds are converted to nil, non-empty ones are serialized to strings -inline int sol_lua_push(sol::types, lua_State* L, const ESM::RefId& id) +inline int sol_lua_push(sol::types, lua_State* state, const ESM::RefId& id) { if (id.empty()) - return sol::stack::push(L, sol::lua_nil); - return sol::stack::push(L, id.serializeText()); + return sol::stack::push(state, sol::lua_nil); + return sol::stack::push(state, id.serializeText()); } -#endif \ No newline at end of file +#endif