From b210e99abc047f9c448584c8b507d5e9dd7d2f66 Mon Sep 17 00:00:00 2001 From: Andrei Kortunov Date: Thu, 14 Nov 2019 17:43:21 +0400 Subject: [PATCH 1/2] Avoid divizion by zero --- apps/opencs/view/render/terrainshapemode.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/apps/opencs/view/render/terrainshapemode.cpp b/apps/opencs/view/render/terrainshapemode.cpp index 44f359c015..d356df8f39 100644 --- a/apps/opencs/view/render/terrainshapemode.cpp +++ b/apps/opencs/view/render/terrainshapemode.cpp @@ -1418,8 +1418,12 @@ void CSVRender::TerrainShapeMode::setBrushShape(CSVWidget::BrushShape brushShape selectionCenterY = selectionCenterY + value.second; ++selectionAmount; } - selectionCenterX = selectionCenterX / selectionAmount; - selectionCenterY = selectionCenterY / selectionAmount; + + if (selectionAmount != 0) + { + selectionCenterX /= selectionAmount; + selectionCenterY /= selectionAmount; + } mCustomBrushShape.clear(); std::pair differentialPos {}; From b21dc175388e4e6d8234aae439616fc46a5a5712 Mon Sep 17 00:00:00 2001 From: Andrei Kortunov Date: Thu, 14 Nov 2019 18:04:12 +0400 Subject: [PATCH 2/2] Attempt to shut up CoverityScan warnings about tainted values --- apps/openmw/mwrender/water.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/apps/openmw/mwrender/water.cpp b/apps/openmw/mwrender/water.cpp index a1b4308cec..6d230d36e2 100644 --- a/apps/openmw/mwrender/water.cpp +++ b/apps/openmw/mwrender/water.cpp @@ -527,9 +527,7 @@ void Water::createSimpleWaterStateSet(osg::Node* node, float alpha) // Add animated textures std::vector > textures; - int frameCount = Fallback::Map::getInt("Water_SurfaceFrameCount"); - frameCount = std::min(std::max(frameCount, 0), 320); - + int frameCount = std::max(0, std::min(Fallback::Map::getInt("Water_SurfaceFrameCount"), 320)); const std::string& texture = Fallback::Map::getString("Water_SurfaceTexture"); for (int i=0; i &textures) { - int frameCount = Fallback::Map::getInt("Water_SurfaceFrameCount"); - frameCount = std::min(std::max(frameCount, 0), 320); - + int frameCount = std::max(0, std::min(Fallback::Map::getInt("Water_SurfaceFrameCount"), 320)); const std::string& texture = Fallback::Map::getString("Water_SurfaceTexture"); for (int i=0; i