Merge branch 'fix_element_destroy' into 'master'

Fix bug in LuaUi::Element::destroy() that sometimes leads to an infinite loop on UI cleanup

See merge request OpenMW/openmw!3033

(cherry picked from commit 364bc91f5b)

c6eed2a6 Fix bug in LuaUi::Element::destroy() that sometimes leads to an infinite loop on UI cleanup

components/lua_ui/element.cpp

@@ -217,12 +217,12 @@ namespace LuaUi
 
     void Element::destroy()
     {
+        sAllElements.erase(this);
         if (!mRoot)
             return;
         destroyWidget(mRoot);
         mRoot = nullptr;
         mLayout = sol::make_object(mLayout.lua_state(), sol::nil);
-        sAllElements.erase(this);
     }
 
     void Element::attachToWidget(WidgetExtension* w)