Merge pull request #2986 from Capostrophic/msvc

Fix AppVeyor warnings

apps/openmw/mwmechanics/aiavoiddoor.cpp

@@ -60,14 +60,14 @@ bool MWMechanics::AiAvoidDoor::execute (const MWWorld::Ptr& actor, CharacterCont
     // Make all nearby actors also avoid the door
     std::vector<MWWorld::Ptr> actors;
     MWBase::Environment::get().getMechanicsManager()->getActorsInRange(pos.asVec3(),100,actors);
-    for(auto& actor : actors)
+    for(auto& neighbor : actors)
     {
-        if (actor == getPlayer())
+        if (neighbor == getPlayer())
             continue;
 
-        MWMechanics::AiSequence& seq = actor.getClass().getCreatureStats(actor).getAiSequence();
+        MWMechanics::AiSequence& seq = neighbor.getClass().getCreatureStats(neighbor).getAiSequence();
         if (seq.getTypeId() != MWMechanics::AiPackageTypeId::AvoidDoor)
-            seq.stack(MWMechanics::AiAvoidDoor(mDoorPtr), actor);
+            seq.stack(MWMechanics::AiAvoidDoor(mDoorPtr), neighbor);
     }
 
     return false;

apps/openmw/mwscript/miscextensions.cpp

@@ -563,9 +563,9 @@ namespace MWScript
                         effects += store.getMagicEffects();
                     }
 
-                    for (const auto& effect : effects)
+                    for (const auto& activeEffect : effects)
                     {
-                        if (effect.first.mId == key && effect.second.getModifier() > 0)
+                        if (activeEffect.first.mId == key && activeEffect.second.getModifier() > 0)
                         {
                             runtime.push(1);
                             return;

apps/openmw/mwscript/scriptmanagerimp.cpp

@@ -149,8 +149,6 @@ namespace MWScript
         int count = 0;
         int success = 0;
 
-        const MWWorld::Store<ESM::Script>& scripts = mStore.get<ESM::Script>();
-
         for (auto& script : mStore.get<ESM::Script>())
         {
             if (!std::binary_search (mScriptBlacklist.begin(), mScriptBlacklist.end(),

components/sdlutil/sdlvideowrapper.cpp

@@ -102,7 +102,6 @@ namespace SDLUtil
         int w = 0;
         int h = 0;
         auto index = SDL_GetWindowDisplayIndex(mWindow);
-        bool reposition = false;
         SDL_GetDisplayBounds(index, &rect);
         SDL_GetWindowSize(mWindow, &w, &h);