mirror/openmw
1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-01-29 21:45:33 +00:00
Code Issues Releases Wiki Activity

Use string_view in more places and reduce the number of empty string literals

Browse source
This commit is contained in:
Evil Eye 2023-05-21 16:39:32 +02:00
parent 5b36ea0179
commit 5491512905
45 changed files with 224 additions and 221 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apps/openmw/mwbase/dialoguemanager.hpp
View file

@ -41,7 +41,7 @@ namespace MWBase
{
public:
virtual ~ResponseCallback() = default;
virtual void addResponse(const std::string& title, const std::string& text) = 0;
virtual void addResponse(std::string_view title, std::string_view text) = 0;
};
DialogueManager() {}
@ -67,7 +67,7 @@ namespace MWBase
virtual void say(const MWWorld::Ptr& actor, const ESM::RefId& topic) = 0;
virtual void keywordSelected(const std::string& keyword, ResponseCallback* callback) = 0;
virtual void keywordSelected(std::string_view keyword, ResponseCallback* callback) = 0;
virtual void goodbyeSelected() = 0;
virtual void questionAnswered(int answer, ResponseCallback* callback) = 0;

4
apps/openmw/mwclass/esm4base.hpp
View file

@ -62,7 +62,7 @@ namespace MWClass
bool hasToolTip(const MWWorld::ConstPtr& ptr) const override { return false; }
std::string_view getName(const MWWorld::ConstPtr& ptr) const override { return ""; }
std::string_view getName(const MWWorld::ConstPtr& ptr) const override { return {}; }
std::string getModel(const MWWorld::ConstPtr& ptr) const override
{
@ -73,7 +73,7 @@ namespace MWClass
// TODO: Figure out a better way find markers and LOD meshes; show LOD only outside of active grid.
if (model.empty() || Misc::StringUtils::ciStartsWith(model, "meshes\\marker")
|| Misc::StringUtils::ciEndsWith(model, "lod.nif"))
return "";
return {};
return model;
}

16
apps/openmw/mwdialogue/dialoguemanagerimp.cpp
View file

@ -174,7 +174,7 @@ namespace MWDialogue
}
MWScript::InterpreterContext interpreterContext(&mActor.getRefData().getLocals(), mActor);
callback->addResponse("", Interpreter::fixDefinesDialog(info->mResponse, interpreterContext));
callback->addResponse({}, Interpreter::fixDefinesDialog(info->mResponse, interpreterContext));
executeScript(info->mResultScript, mActor);
mLastTopic = it->mId;
@ -429,14 +429,14 @@ namespace MWDialogue
return 0;
}
void DialogueManager::keywordSelected(const std::string& keyword, ResponseCallback* callback)
void DialogueManager::keywordSelected(std::string_view keyword, ResponseCallback* callback)
{
if (!mIsInChoice)
{
const ESM::Dialogue* dialogue = searchDialogue(ESM::RefId::stringRefId(keyword));
if (dialogue && dialogue->mType == ESM::Dialogue::Topic)
{
executeTopic(ESM::RefId::stringRefId(keyword), callback);
executeTopic(dialogue->mId, callback);
}
}
}
@ -487,7 +487,7 @@ namespace MWDialogue
mChoices.clear();
MWScript::InterpreterContext interpreterContext(&mActor.getRefData().getLocals(), mActor);
callback->addResponse("", Interpreter::fixDefinesDialog(text, interpreterContext));
callback->addResponse({}, Interpreter::fixDefinesDialog(text, interpreterContext));
if (dialogue->mType == ESM::Dialogue::Topic)
{
@ -731,8 +731,12 @@ namespace MWDialogue
int DialogueManager::getFactionReaction(const ESM::RefId& faction1, const ESM::RefId& faction2) const
{
ModFactionReactionMap::const_iterator map = mChangedFactionReaction.find(faction1);
if (map != mChangedFactionReaction.end() && map->second.find(faction2) != map->second.end())
return map->second.at(faction2);
if (map != mChangedFactionReaction.end())
{
auto it = map->second.find(faction2);
if (it != map->second.end())
return it->second;
}
const ESM::Faction* faction = MWBase::Environment::get().getESMStore()->get<ESM::Faction>().find(faction1);

2
apps/openmw/mwdialogue/dialoguemanagerimp.hpp
View file

@ -103,7 +103,7 @@ namespace MWDialogue
void say(const MWWorld::Ptr& actor, const ESM::RefId& topic) override;
// calbacks for the GUI
void keywordSelected(const std::string& keyword, ResponseCallback* callback) override;
void keywordSelected(std::string_view keyword, ResponseCallback* callback) override;
void goodbyeSelected() override;
void questionAnswered(int answer, ResponseCallback* callback) override;

15
apps/openmw/mwgui/alchemywindow.cpp
View file

@ -267,16 +267,17 @@ namespace MWGui
mNameEdit->setCaption({});
mBrewCountEdit->setValue(1);
int index = 0;
for (MWMechanics::Alchemy::TToolsIterator iter(mAlchemy->beginTools());
iter != mAlchemy->endTools() && index < static_cast<int>(mApparatus.size()); ++iter, ++index)
size_t index = 0;
for (auto iter = mAlchemy->beginTools(); iter != mAlchemy->endTools() && index < mApparatus.size();
++iter, ++index)
{
mApparatus.at(index)->setItem(*iter);
mApparatus.at(index)->clearUserStrings();
const auto& widget = mApparatus[index];
widget->setItem(*iter);
widget->clearUserStrings();
if (!iter->isEmpty())
{
mApparatus.at(index)->setUserString("ToolTipType", "ItemPtr");
mApparatus.at(index)->setUserData(MWWorld::Ptr(*iter));
widget->setUserString("ToolTipType", "ItemPtr");
widget->setUserData(MWWorld::Ptr(*iter));
}
}

12
apps/openmw/mwgui/birth.cpp
View file

@ -225,15 +225,15 @@ namespace MWGui
struct
{
const std::vector<ESM::RefId>& spells;
const char* label;
std::string_view label;
} categories[3] = { { abilities, "sBirthsignmenu1" }, { powers, "sPowers" }, { spells, "sBirthsignmenu2" } };
for (int category = 0; category < 3; ++category)
for (size_t category = 0; category < 3; ++category)
{
if (!categories[category].spells.empty())
{
MyGUI::TextBox* label = mSpellArea->createWidget<MyGUI::TextBox>(
"SandBrightText", coord, MyGUI::Align::Default, std::string("Label"));
MyGUI::TextBox* label
= mSpellArea->createWidget<MyGUI::TextBox>("SandBrightText", coord, MyGUI::Align::Default, "Label");
label->setCaption(toUString(MWBase::Environment::get().getWindowManager()->getGameSettingString(
categories[category].label, {})));
mSpellItems.push_back(label);
@ -243,8 +243,8 @@ namespace MWGui
for (it = categories[category].spells.begin(); it != end; ++it)
{
const ESM::RefId& spellId = *it;
spellWidget = mSpellArea->createWidget<Widgets::MWSpell>("MW_StatName", coord,
MyGUI::Align::Default, std::string("Spell") + MyGUI::utility::toString(i));
spellWidget = mSpellArea->createWidget<Widgets::MWSpell>(
"MW_StatName", coord, MyGUI::Align::Default, "Spell" + MyGUI::utility::toString(i));
spellWidget->setSpellId(spellId);
mSpellItems.push_back(spellWidget);

25
apps/openmw/mwgui/charactercreation.cpp
View file

@ -103,27 +103,16 @@ namespace MWGui
void CharacterCreation::setValue(std::string_view id, const MWMechanics::AttributeValue& value)
{
static const char* ids[] = {
"AttribVal1",
"AttribVal2",
"AttribVal3",
"AttribVal4",
"AttribVal5",
"AttribVal6",
"AttribVal7",
"AttribVal8",
nullptr,
};
for (int i = 0; ids[i]; ++i)
std::string_view prefix = "AttribVal";
if (id.starts_with(prefix) && id.size() == prefix.size() + 1)
{
if (ids[i] == id)
char index = id[prefix.size()];
auto attribute = static_cast<ESM::Attribute::AttributeID>(index - '0' - 1);
if (attribute >= ESM::Attribute::Strength && attribute < ESM::Attribute::Length)
{
mPlayerAttributes[static_cast<ESM::Attribute::AttributeID>(i)] = value;
mPlayerAttributes[attribute] = value;
if (mReviewDialog)
mReviewDialog->setAttribute(static_cast<ESM::Attribute::AttributeID>(i), value);
break;
mReviewDialog->setAttribute(attribute, value);
}
}
}

4
apps/openmw/mwgui/class.cpp
View file

@ -346,7 +346,7 @@ namespace MWGui
for (const std::string& text : buttons)
{
button = mButtonBar->createWidget<MyGUI::Button>(
"MW_Button", coord, MyGUI::Align::Top | MyGUI::Align::HCenter, "");
"MW_Button", coord, MyGUI::Align::Top | MyGUI::Align::HCenter, {});
button->getSubWidgetText()->setWordWrap(true);
button->setCaption(text);
fitToText(button);
@ -386,7 +386,7 @@ namespace MWGui
ClassChoiceDialog::ClassChoiceDialog()
: InfoBoxDialog()
{
setText("");
setText({});
ButtonList buttons;
buttons.emplace_back(
MWBase::Environment::get().getWindowManager()->getGameSettingString("sClassChoiceMenu1", {}));

2
apps/openmw/mwgui/companionwindow.cpp
View file

@ -153,7 +153,7 @@ namespace MWGui
mProfitLabel->setCaptionWithReplacing("#{sProfitValue} " + MyGUI::utility::toString(getProfit(mPtr)));
}
else
mProfitLabel->setCaption("");
mProfitLabel->setCaption({});
}
void CompanionWindow::onCloseButtonClicked(MyGUI::Widget* _sender)

8
apps/openmw/mwgui/console.cpp
View file

@ -101,7 +101,7 @@ namespace MWGui
if (mNames.empty())
{
// keywords
std::istringstream input("");
std::istringstream input;
Compiler::Scanner scanner(*this, input, mCompilerContext.getExtensions());
@ -312,7 +312,7 @@ namespace MWGui
if (oldCaption == newCaption && !matches.empty())
{
int i = 0;
printOK("");
printOK({});
for (std::string& match : matches)
{
if (i == 50)
@ -377,7 +377,7 @@ namespace MWGui
// Reset the command line before the command execution.
// It prevents the re-triggering of the acceptCommand() event for the same command
// during the actual command execution
mCommandLine->setCaption("");
mCommandLine->setCaption({});
execute(cm);
}
@ -618,7 +618,7 @@ namespace MWGui
if ((matches.front().find(' ') != std::string::npos))
{
if (!has_front_quote)
output.append(std::string("\""));
output += '"';
return output.append(matches.front() + std::string("\" "));
}
else if (has_front_quote)

21
apps/openmw/mwgui/dialogue.cpp
View file

@ -32,7 +32,7 @@
namespace MWGui
{
void ResponseCallback::addResponse(const std::string& title, const std::string& text)
void ResponseCallback::addResponse(std::string_view title, std::string_view text)
{
mWindow->addResponse(title, text, mNeedMargin);
}
@ -150,7 +150,7 @@ namespace MWGui
// --------------------------------------------------------------------------------------------------
Response::Response(const std::string& text, const std::string& title, bool needMargin)
Response::Response(std::string_view text, std::string_view title, bool needMargin)
: mTitle(title)
, mNeedMargin(needMargin)
{
@ -213,7 +213,7 @@ namespace MWGui
{
const TextColours& textColours = MWBase::Environment::get().getWindowManager()->getTextColours();
BookTypesetter::Style* style = typesetter->createStyle("", textColours.normal, false);
BookTypesetter::Style* style = typesetter->createStyle({}, textColours.normal, false);
size_t formatted = 0; // points to the first character that is not laid out yet
for (auto& hyperLink : hyperLinks)
{
@ -252,7 +252,7 @@ namespace MWGui
{
const TextColours& textColours = MWBase::Environment::get().getWindowManager()->getTextColours();
BookTypesetter::Style* style = typesetter->createStyle("", textColours.normal, false);
BookTypesetter::Style* style = typesetter->createStyle({}, textColours.normal, false);
if (topicId)
style = typesetter->createHotStyle(
@ -260,7 +260,7 @@ namespace MWGui
typesetter->write(style, begin, end);
}
Message::Message(const std::string& text)
Message::Message(std::string_view text)
{
mText = text;
}
@ -269,7 +269,7 @@ namespace MWGui
std::map<std::string, std::unique_ptr<Link>>& topicLinks) const
{
const MyGUI::Colour& textColour = MWBase::Environment::get().getWindowManager()->getTextColours().notify;
BookTypesetter::Style* title = typesetter->createStyle("", textColour, false);
BookTypesetter::Style* title = typesetter->createStyle({}, textColour, false);
typesetter->sectionBreak(9);
typesetter->write(title, to_utf8_span(mText));
}
@ -335,7 +335,8 @@ namespace MWGui
void DialogueWindow::onTradeComplete()
{
addResponse("", MyGUI::LanguageManager::getInstance().replaceTags("#{sBarterDialog5}"));
MyGUI::UString message = MyGUI::LanguageManager::getInstance().replaceTags("#{sBarterDialog5}");
addResponse({}, message.asUTF8());
}
bool DialogueWindow::exit()
@ -611,7 +612,7 @@ namespace MWGui
for (const auto& text : mHistoryContents)
text->write(typesetter, &mKeywordSearch, mTopicLinks);
BookTypesetter::Style* body = typesetter->createStyle("", MyGUI::Colour::White, false);
BookTypesetter::Style* body = typesetter->createStyle({}, MyGUI::Colour::White, false);
typesetter->sectionBreak(9);
// choices
@ -716,13 +717,13 @@ namespace MWGui
mHistory->setPosition(0, static_cast<int>(pos) * -1);
}
void DialogueWindow::addResponse(const std::string& title, const std::string& text, bool needMargin)
void DialogueWindow::addResponse(std::string_view title, std::string_view text, bool needMargin)
{
mHistoryContents.push_back(std::make_unique<Response>(text, title, needMargin));
updateHistory();
}
void DialogueWindow::addMessageBox(const std::string& text)
void DialogueWindow::addMessageBox(std::string_view text)
{
mHistoryContents.push_back(std::make_unique<Message>(text));
updateHistory();

12
apps/openmw/mwgui/dialogue.hpp
View file

@ -35,7 +35,7 @@ namespace MWGui
{
}
void addResponse(const std::string& title, const std::string& text) override;
void addResponse(std::string_view title, std::string_view text) override;
void updateTopics() const;
};
@ -112,7 +112,7 @@ namespace MWGui
struct DialogueText
{
virtual ~DialogueText() {}
virtual ~DialogueText() = default;
virtual void write(BookTypesetter::Ptr typesetter, KeywordSearchT* keywordSearch,
std::map<std::string, std::unique_ptr<Link>>& topicLinks) const = 0;
std::string mText;
@ -120,7 +120,7 @@ namespace MWGui
struct Response : DialogueText
{
Response(const std::string& text, const std::string& title = "", bool needMargin = true);
Response(std::string_view text, std::string_view title = {}, bool needMargin = true);
void write(BookTypesetter::Ptr typesetter, KeywordSearchT* keywordSearch,
std::map<std::string, std::unique_ptr<Link>>& topicLinks) const override;
void addTopicLink(BookTypesetter::Ptr typesetter, intptr_t topicId, size_t begin, size_t end) const;
@ -130,7 +130,7 @@ namespace MWGui
struct Message : DialogueText
{
Message(const std::string& text);
Message(std::string_view text);
void write(BookTypesetter::Ptr typesetter, KeywordSearchT* keywordSearch,
std::map<std::string, std::unique_ptr<Link>>& topicLinks) const override;
};
@ -154,9 +154,9 @@ namespace MWGui
/// @return true if stale keywords were updated successfully
bool setKeywords(const std::list<std::string>& keyWord);
void addResponse(const std::string& title, const std::string& text, bool needMargin = true);
void addResponse(std::string_view title, std::string_view text, bool needMargin = true);
void addMessageBox(const std::string& text);
void addMessageBox(std::string_view text);
void onFrame(float dt) override;
void clear() override { resetReference(); }

2
apps/openmw/mwgui/enchantingdialog.cpp
View file

@ -140,7 +140,7 @@ namespace MWGui
void EnchantingDialog::setPtr(const MWWorld::Ptr& ptr)
{
mName->setCaption("");
mName->setCaption({});
if (ptr.getClass().isActor())
{

39
apps/openmw/mwgui/formatting.cpp
View file

@ -34,7 +34,7 @@ namespace MWGui::Formatting
nullptr, MWWorld::Ptr()); // empty arguments, because there is no locals or actor
mText = Interpreter::fixDefinesBook(mText, interpreterContext);
Misc::StringUtils::replaceAll(mText, "\r", "");
Misc::StringUtils::replaceAll(mText, "\r", {});
// vanilla game does not show any text after the last EOL tag.
const std::string lowerText = Misc::StringUtils::lowerCase(mText);
@ -82,9 +82,9 @@ namespace MWGui::Formatting
parseTag(mText.substr(tagStart, tagEnd - tagStart));
mIndex = tagEnd;
if (mTagTypes.find(mTag) != mTagTypes.end())
if (auto it = mTagTypes.find(mTag); it != mTagTypes.end())
{
Events type = mTagTypes.at(mTag);
Events type = it->second;
if (type == Event_BrTag || type == Event_PTag)
{
@ -290,13 +290,19 @@ namespace MWGui::Formatting
{
const BookTextParser::Attributes& attr = parser.getAttributes();
if (attr.find("src") == attr.end() || attr.find("width") == attr.end()
|| attr.find("height") == attr.end())
auto srcIt = attr.find("src");
if (srcIt == attr.end())
continue;
auto widthIt = attr.find("width");
if (widthIt == attr.end())
continue;
auto heightIt = attr.find("height");
if (heightIt == attr.end())
continue;
std::string src = attr.at("src");
int width = MyGUI::utility::parseInt(attr.at("width"));
int height = MyGUI::utility::parseInt(attr.at("height"));
const std::string& src = srcIt->second;
int width = MyGUI::utility::parseInt(widthIt->second);
int height = MyGUI::utility::parseInt(heightIt->second);
auto vfs = MWBase::Environment::get().getResourceSystem()->getVFS();
std::string correctedSrc = Misc::ResourceHelpers::correctBookartPath(src, width, height, vfs);
@ -349,10 +355,11 @@ namespace MWGui::Formatting
void BookFormatter::handleDiv(const BookTextParser::Attributes& attr)
{
if (attr.find("align") == attr.end())
auto it = attr.find("align");
if (it == attr.end())
return;
std::string align = attr.at("align");
const std::string& align = it->second;
if (Misc::StringUtils::ciEqual(align, "center"))
mBlockStyle.mAlign = MyGUI::Align::HCenter;
@ -364,19 +371,21 @@ namespace MWGui::Formatting
void BookFormatter::handleFont(const BookTextParser::Attributes& attr)
{
if (attr.find("color") != attr.end())
auto it = attr.find("color");
if (it != attr.end())
{
auto& colorString = attr.at("color");
const auto& colorString = it->second;
unsigned int color = 0;
std::from_chars(colorString.data(), colorString.data() + colorString.size(), color, 16);
mTextStyle.mColour
= MyGUI::Colour((color >> 16 & 0xFF) / 255.f, (color >> 8 & 0xFF) / 255.f, (color & 0xFF) / 255.f);
}
if (attr.find("face") != attr.end())
it = attr.find("face");
if (it != attr.end())
{
std::string face = attr.at("face");
std::string name = Gui::FontLoader::getFontForFace(face);
const std::string& face = it->second;
std::string name{ Gui::FontLoader::getFontForFace(face) };
mTextStyle.mFont = "Journalbook " + name;
}

2
apps/openmw/mwgui/itemview.cpp
View file

@ -91,7 +91,7 @@ namespace MWGui
mModel->update();
MyGUI::Widget* dragArea = mScrollView->createWidget<MyGUI::Widget>(
"", 0, 0, mScrollView->getWidth(), mScrollView->getHeight(), MyGUI::Align::Stretch);
{}, 0, 0, mScrollView->getWidth(), mScrollView->getHeight(), MyGUI::Align::Stretch);
dragArea->setNeedMouseFocus(true);
dragArea->eventMouseButtonClick += MyGUI::newDelegate(this, &ItemView::onSelectedBackground);
dragArea->eventMouseWheel += MyGUI::newDelegate(this, &ItemView::onMouseWheelMoved);

14
apps/openmw/mwgui/itemwidget.cpp
View file

@ -23,7 +23,7 @@ namespace
static const int fontHeight = MWBase::Environment::get().getWindowManager()->getFontHeight();
if (count == 1)
return "";
return {};
// With small text size we can use up to 4 characters, while with large ones - only up to 3.
if (fontHeight > 16)
@ -148,11 +148,11 @@ namespace MWGui
if (ptr.isEmpty())
{
if (mFrame)
mFrame->setImageTexture("");
mFrame->setImageTexture({});
if (mItemShadow)
mItemShadow->setImageTexture("");
mItem->setImageTexture("");
mText->setCaption("");
mItemShadow->setImageTexture({});
mItem->setImageTexture({});
mText->setCaption({});
mCurrentIcon.clear();
mCurrentFrame.clear();
return;
@ -175,7 +175,7 @@ namespace MWGui
else if (state == Barter)
backgroundTex += "_barter";
if (backgroundTex != "")
if (!backgroundTex.empty())
backgroundTex += ".dds";
float scale = 1.f;
@ -210,7 +210,7 @@ namespace MWGui
if (mFrame && !mCurrentFrame.empty())
{
mCurrentFrame.clear();
mFrame->setImageTexture("");
mFrame->setImageTexture({});
}
if (mCurrentIcon != icon)
{

24
apps/openmw/mwgui/journalbooks.cpp
View file

@ -168,8 +168,8 @@ namespace MWGui
{
BookTypesetter::Ptr typesetter = createTypesetter();
BookTypesetter::Style* header = typesetter->createStyle("", MyGUI::Colour(0.60f, 0.00f, 0.00f));
BookTypesetter::Style* body = typesetter->createStyle("", MyGUI::Colour::Black);
BookTypesetter::Style* header = typesetter->createStyle({}, MyGUI::Colour(0.60f, 0.00f, 0.00f));
BookTypesetter::Style* body = typesetter->createStyle({}, MyGUI::Colour::Black);
typesetter->write(header, to_utf8_span("You have no journal entries!"));
typesetter->lineBreak();
@ -183,10 +183,10 @@ namespace MWGui
{
BookTypesetter::Ptr typesetter = createTypesetter();
BookTypesetter::Style* header = typesetter->createStyle("", MyGUI::Colour(0.60f, 0.00f, 0.00f));
BookTypesetter::Style* body = typesetter->createStyle("", MyGUI::Colour::Black);
BookTypesetter::Style* header = typesetter->createStyle({}, MyGUI::Colour(0.60f, 0.00f, 0.00f));
BookTypesetter::Style* body = typesetter->createStyle({}, MyGUI::Colour::Black);
mModel->visitJournalEntries("", AddJournalEntry(typesetter, body, header, true));
mModel->visitJournalEntries({}, AddJournalEntry(typesetter, body, header, true));
return typesetter->complete();
}
@ -195,8 +195,8 @@ namespace MWGui
{
BookTypesetter::Ptr typesetter = createTypesetter();
BookTypesetter::Style* header = typesetter->createStyle("", MyGUI::Colour(0.60f, 0.00f, 0.00f));
BookTypesetter::Style* body = typesetter->createStyle("", MyGUI::Colour::Black);
BookTypesetter::Style* header = typesetter->createStyle({}, MyGUI::Colour(0.60f, 0.00f, 0.00f));
BookTypesetter::Style* body = typesetter->createStyle({}, MyGUI::Colour::Black);
mModel->visitTopicName(topicId, AddTopicName(typesetter, header));
@ -211,8 +211,8 @@ namespace MWGui
{
BookTypesetter::Ptr typesetter = createTypesetter();
BookTypesetter::Style* header = typesetter->createStyle("", MyGUI::Colour(0.60f, 0.00f, 0.00f));
BookTypesetter::Style* body = typesetter->createStyle("", MyGUI::Colour::Black);
BookTypesetter::Style* header = typesetter->createStyle({}, MyGUI::Colour(0.60f, 0.00f, 0.00f));
BookTypesetter::Style* body = typesetter->createStyle({}, MyGUI::Colour::Black);
AddQuestName addName(typesetter, header);
addName(to_utf8_span(questName));
@ -243,7 +243,7 @@ namespace MWGui
char ch = 'A';
std::string buffer;
BookTypesetter::Style* body = typesetter->createStyle("", MyGUI::Colour::Black);
BookTypesetter::Style* body = typesetter->createStyle({}, MyGUI::Colour::Black);
for (int i = 0; i < 26; ++i)
{
buffer = "( ";
@ -272,7 +272,7 @@ namespace MWGui
typesetter->setSectionAlignment(BookTypesetter::AlignCenter);
BookTypesetter::Style* body = typesetter->createStyle("", MyGUI::Colour::Black);
BookTypesetter::Style* body = typesetter->createStyle({}, MyGUI::Colour::Black);
int fontHeight = MWBase::Environment::get().getWindowManager()->getFontHeight();
@ -297,7 +297,7 @@ namespace MWGui
buffer += ch[1];
buffer += " )";
Utf8Stream stream((char*)ch);
Utf8Stream stream(ch, ch + 2);
Utf8Stream::UnicodeChar first = stream.peek();
const MWGui::TextColours& textColours = MWBase::Environment::get().getWindowManager()->getTextColours();

15
apps/openmw/mwgui/levelupdialog.cpp
View file

@ -107,7 +107,7 @@ namespace MWGui
void LevelupDialog::assignCoins()
{
resetCoins();
for (unsigned int i = 0; i < mSpentAttributes.size(); ++i)
for (size_t i = 0; i < mSpentAttributes.size(); ++i)
{
MyGUI::ImageBox* image = mCoins[i];
image->detachFromWidget();
@ -115,7 +115,7 @@ namespace MWGui
int attribute = mSpentAttributes[i];
int xdiff = mAttributeMultipliers[attribute]->getCaption() == "" ? 0 : 20;
int xdiff = mAttributeMultipliers[attribute]->getCaption().empty() ? 0 : 20;
MyGUI::IntPoint pos = mAttributes[attribute]->getAbsolutePosition() - mAssignWidget->getAbsolutePosition()
- MyGUI::IntPoint(22 + xdiff, 0);
@ -160,14 +160,17 @@ namespace MWGui
float mult = pcStats.getLevelupAttributeMultiplier(i);
mult = std::min(mult, 100 - pcStats.getAttribute(i).getBase());
text->setCaption(mult <= 1 ? "" : "x" + MyGUI::utility::toString(mult));
if (mult <= 1)
text->setCaption({});
else
text->setCaption("x" + MyGUI::utility::toString(mult));
}
else
{
mAttributes[i]->setEnabled(false);
mAttributeValues[i]->setEnabled(false);
text->setCaption("");
text->setCaption({});
}
}
@ -227,10 +230,10 @@ namespace MWGui
assignCoins();
}
std::string LevelupDialog::getLevelupClassImage(
std::string_view LevelupDialog::getLevelupClassImage(
const int combatIncreases, const int magicIncreases, const int stealthIncreases)
{
std::string ret = "acrobat";
std::string_view ret = "acrobat";
int total = combatIncreases + magicIncreases + stealthIncreases;
if (total == 0)

2
apps/openmw/mwgui/levelupdialog.hpp
View file

@ -40,7 +40,7 @@ namespace MWGui
void setAttributeValues();
std::string getLevelupClassImage(
std::string_view getLevelupClassImage(
const int combatIncreases, const int magicIncreases, const int stealthIncreases);
};

4
apps/openmw/mwgui/loadingscreen.cpp
View file

@ -226,7 +226,7 @@ namespace MWGui
mSplashImage->setVisible(true);
mSplashImage->setBackgroundImage(randomSplash, true, stretch);
}
mSceneImage->setBackgroundImage("");
mSceneImage->setBackgroundImage({});
mSceneImage->setVisible(false);
}
@ -313,7 +313,7 @@ namespace MWGui
mViewer->getCamera()->addInitialDrawCallback(mCopyFramebufferToTextureCallback);
mCopyFramebufferToTextureCallback->reset();
mSplashImage->setBackgroundImage("");
mSplashImage->setBackgroundImage({});
mSplashImage->setVisible(false);
mSceneImage->setRenderItemTexture(mGuiTexture.get());

21
apps/openmw/mwgui/mainmenu.cpp
View file

@ -218,7 +218,7 @@ namespace MWGui
if (!mButtonBox)
mButtonBox
= mMainWidget->createWidget<MyGUI::Widget>("", MyGUI::IntCoord(0, 0, 0, 0), MyGUI::Align::Default);
= mMainWidget->createWidget<MyGUI::Widget>({}, MyGUI::IntCoord(0, 0, 0, 0), MyGUI::Align::Default);
int curH = 0;
@ -250,26 +250,24 @@ namespace MWGui
buttons.emplace_back("exitgame");
// Create new buttons if needed
std::vector<std::string> allButtons{ "return", "newgame", "savegame", "loadgame", "options", "credits",
"exitgame" };
for (std::string& buttonId : allButtons)
for (std::string_view id : { "return", "newgame", "savegame", "loadgame", "options", "credits", "exitgame" })
{
if (mButtons.find(buttonId) == mButtons.end())
if (mButtons.find(id) == mButtons.end())
{
Gui::ImageButton* button = mButtonBox->createWidget<Gui::ImageButton>(
"ImageBox", MyGUI::IntCoord(0, curH, 0, 0), MyGUI::Align::Default);
const std::string& buttonId = mButtons.emplace(id, button).first->first;
button->setProperty("ImageHighlighted", "textures\\menu_" + buttonId + "_over.dds");
button->setProperty("ImageNormal", "textures\\menu_" + buttonId + ".dds");
button->setProperty("ImagePushed", "textures\\menu_" + buttonId + "_pressed.dds");
button->eventMouseButtonClick += MyGUI::newDelegate(this, &MainMenu::onButtonClicked);
button->setUserData(std::string(buttonId));
mButtons[buttonId] = button;
button->setUserData(buttonId);
}
}
// Start by hiding all buttons
int maxwidth = 0;
for (auto& buttonPair : mButtons)
for (const auto& buttonPair : mButtons)
{
buttonPair.second->setVisible(false);
MyGUI::IntSize requested = buttonPair.second->getRequestedSize();
@ -278,10 +276,11 @@ namespace MWGui
}
// Now show and position the ones we want
for (std::string& buttonId : buttons)
for (const std::string& buttonId : buttons)
{
assert(mButtons.find(buttonId) != mButtons.end());
Gui::ImageButton* button = mButtons[buttonId];
auto it = mButtons.find(buttonId);
assert(it != mButtons.end());
Gui::ImageButton* button = it->second;
button->setVisible(true);
// By default, assume that all menu buttons textures should have 64 height.

2
apps/openmw/mwgui/mainmenu.hpp
View file

@ -51,7 +51,7 @@ namespace MWGui
MyGUI::ImageBox* mVideoBackground;
VideoWidget* mVideo; // For animated main menus
std::map<std::string, Gui::ImageButton*> mButtons;
std::map<std::string, Gui::ImageButton*, std::less<>> mButtons;
void onButtonClicked(MyGUI::Widget* sender);
void onNewGameConfirmed();

6
apps/openmw/mwgui/mapwindow.cpp
View file

@ -252,7 +252,7 @@ namespace MWGui
{
for (auto& entry : mMaps)
{
entry.mFogWidget->setImageTexture("");
entry.mFogWidget->setImageTexture({});
entry.mFogTexture.reset();
}
}
@ -891,7 +891,7 @@ namespace MWGui
mEditNoteDialog.setVisible(true);
mEditNoteDialog.showDeleteButton(false);
mEditNoteDialog.setText("");
mEditNoteDialog.setText({});
}
void MapWindow::onMapZoomed(MyGUI::Widget* sender, int rel)
@ -1122,7 +1122,7 @@ namespace MWGui
if (!destNotes.empty())
{
MarkerUserData data(nullptr);
data.notes = destNotes;
std::swap(data.notes, destNotes);
data.caption = markerWidget->getUserString("Caption_TextOneLine");
markerWidget->setUserData(data);
markerWidget->setUserString("ToolTipType", "MapMarker");

2
apps/openmw/mwgui/postprocessorhud.cpp
View file

@ -81,7 +81,7 @@ namespace MWGui
mConfigLayout->setVisibleVScroll(true);
mConfigArea = mConfigLayout->createWidget<MyGUI::Widget>("", {}, MyGUI::Align::Default);
mConfigArea = mConfigLayout->createWidget<MyGUI::Widget>({}, {}, MyGUI::Align::Default);
mConfigLayout->eventMouseWheel += MyGUI::newDelegate(this, &PostProcessorHud::notifyMouseWheel);
mConfigArea->eventMouseWheel += MyGUI::newDelegate(this, &PostProcessorHud::notifyMouseWheel);

12
apps/openmw/mwgui/resourceskin.cpp
View file

@ -33,9 +33,9 @@ namespace MWGui
const std::string basisSkinType = basis->findAttribute("type");
if (Misc::StringUtils::ciEqual(basisSkinType, "SimpleText"))
continue;
bool isTileRect = Misc::StringUtils::ciEqual(basisSkinType, "TileRect");
const std::string offset = basis->findAttribute("offset");
if (!offset.empty())
if (!basis->findAttribute("offset").empty())
continue;
basis->addAttribute("offset", coord);
@ -45,19 +45,17 @@ namespace MWGui
{
if (state->getName() == "State")
{
const std::string stateOffset = state->findAttribute("offset");
if (!stateOffset.empty())
if (!state->findAttribute("offset").empty())
continue;
state->addAttribute("offset", coord);
if (Misc::StringUtils::ciEqual(basisSkinType, "TileRect"))
if (isTileRect)
{
MyGUI::xml::ElementEnumerator property = state->getElementEnumerator();
bool hasTileSize = false;
while (property.next("Property"))
{
const std::string key = property->findAttribute("key");
if (key != "TileSize")
if (property->findAttribute("key") != "TileSize")
continue;
hasTileSize = true;

15
apps/openmw/mwgui/savegamedialog.cpp
View file

@ -146,7 +146,7 @@ namespace MWGui
{
WindowModal::onOpen();
mSaveNameEdit->setCaption("");
mSaveNameEdit->setCaption({});
if (mSaving)
MWBase::Environment::get().getWindowManager()->setKeyFocusWidget(mSaveNameEdit);
else
@ -154,7 +154,7 @@ namespace MWGui
center();
mCharacterSelection->setCaption("");
mCharacterSelection->setCaption({});
mCharacterSelection->removeAllItems();
mCurrentCharacter = nullptr;
mCurrentSlot = nullptr;
@ -167,7 +167,7 @@ namespace MWGui
mCurrentCharacter = mgr->getCurrentCharacter();
std::string directory = Misc::StringUtils::lowerCase(Settings::Manager::getString("character", "Saves"));
const std::string& directory = Settings::Manager::getString("character", "Saves");
size_t selectedIndex = MyGUI::ITEM_NONE;
@ -203,9 +203,8 @@ namespace MWGui
if (mCurrentCharacter == &*it
|| (!mCurrentCharacter && !mSaving
&& directory
== Misc::StringUtils::lowerCase(
Files::pathToUnicodeString(it->begin()->mPath.parent_path().filename()))))
&& Misc::StringUtils::ciEqual(
directory, Files::pathToUnicodeString(it->begin()->mPath.parent_path().filename()))))
{
mCurrentCharacter = &*it;
selectedIndex = mCharacterSelection->getItemCount() - 1;
@ -389,8 +388,8 @@ namespace MWGui
if (pos == MyGUI::ITEM_NONE || !mCurrentCharacter)
{
mCurrentSlot = nullptr;
mInfoText->setCaption("");
mScreenshot->setImageTexture("");
mInfoText->setCaption({});
mScreenshot->setImageTexture({});
return;
}

18
apps/openmw/mwgui/settingswindow.cpp
View file

@ -107,25 +107,25 @@ namespace
return MyGUI::utility::toString(xaspect) + " : " + MyGUI::utility::toString(yaspect);
}
const char* checkButtonType = "CheckButton";
const char* sliderType = "Slider";
const std::string_view checkButtonType = "CheckButton";
const std::string_view sliderType = "Slider";
std::string getSettingType(MyGUI::Widget* widget)
std::string_view getSettingType(MyGUI::Widget* widget)
{
return widget->getUserString("SettingType");
}
std::string getSettingName(MyGUI::Widget* widget)
std::string_view getSettingName(MyGUI::Widget* widget)
{
return widget->getUserString("SettingName");
}
std::string getSettingCategory(MyGUI::Widget* widget)
std::string_view getSettingCategory(MyGUI::Widget* widget)
{
return widget->getUserString("SettingCategory");
}
std::string getSettingValueType(MyGUI::Widget* widget)
std::string_view getSettingValueType(MyGUI::Widget* widget)
{
return widget->getUserString("SettingValueType");
}
@ -165,7 +165,7 @@ namespace MWGui
{
MyGUI::Widget* current = widgets.current();
std::string type = getSettingType(current);
std::string_view type = getSettingType(current);
if (type == checkButtonType)
{
const std::string initialValue
@ -179,7 +179,7 @@ namespace MWGui
{
MyGUI::ScrollBar* scroll = current->castType<MyGUI::ScrollBar>();
std::string valueStr;
std::string valueType = getSettingValueType(current);
std::string_view valueType = getSettingValueType(current);
if (valueType == "Float" || valueType == "Integer" || valueType == "Cell")
{
// TODO: ScrollBar isn't meant for this. should probably use a dedicated FloatSlider widget
@ -689,7 +689,7 @@ namespace MWGui
if (getSettingType(scroller) == "Slider")
{
std::string valueStr;
std::string valueType = getSettingValueType(scroller);
std::string_view valueType = getSettingValueType(scroller);
if (valueType == "Float" || valueType == "Integer" || valueType == "Cell")
{
float value = pos / float(scroller->getScrollRange() - 1);

6
apps/openmw/mwgui/spellcreationdialog.cpp
View file

@ -366,7 +366,7 @@ namespace MWGui
void SpellCreationDialog::setPtr(const MWWorld::Ptr& actor)
{
mPtr = actor;
mNameEdit->setCaption("");
mNameEdit->setCaption({});
startEditing();
}
@ -384,7 +384,7 @@ namespace MWGui
return;
}
if (mNameEdit->getCaption() == "")
if (mNameEdit->getCaption().empty())
{
MWBase::Environment::get().getWindowManager()->messageBox("#{sNotifyMessage10}");
return;
@ -700,7 +700,7 @@ namespace MWGui
params.mIsConstant = mConstantEffect;
MyGUI::Button* button = mUsedEffectsView->createWidget<MyGUI::Button>(
"", MyGUI::IntCoord(0, size.height, 0, 24), MyGUI::Align::Default);
{}, MyGUI::IntCoord(0, size.height, 0, 24), MyGUI::Align::Default);
button->setUserData(i);
button->eventMouseButtonClick += MyGUI::newDelegate(this, &SpellCreationDialog::onEditEffect);
button->setNeedMouseFocus(true);

4
apps/openmw/mwgui/spellview.cpp
View file

@ -100,7 +100,7 @@ namespace MWGui
if (curType != spell.mType)
{
if (spell.mType == Spell::Type_Power)
addGroup("#{sPowers}", "");
addGroup("#{sPowers}", {});
else if (spell.mType == Spell::Type_Spell)
addGroup("#{sSpells}", mShowCostColumn ? "#{sCostChance}" : "");
else
@ -246,7 +246,7 @@ namespace MWGui
groupWidget->setTextAlign(MyGUI::Align::Left);
groupWidget->setNeedMouseFocus(false);
if (label2 != "")
if (!label2.empty())
{
MyGUI::TextBox* groupWidget2 = mScrollView->createWidget<Gui::TextBox>("SandBrightText",
MyGUI::IntCoord(0, 0, mScrollView->getWidth(), 24), MyGUI::Align::Left | MyGUI::Align::Top);

2
apps/openmw/mwgui/spellwindow.cpp
View file

@ -241,7 +241,7 @@ namespace MWGui
if ((!godmode && stats.isParalyzed()) || stats.getKnockedDown() || stats.isDead() || stats.getHitRecovery())
return;
mSpellView->setModel(new SpellModel(MWMechanics::getPlayer(), ""));
mSpellView->setModel(new SpellModel(MWMechanics::getPlayer()));
SpellModel::ModelIndex selected = mSpellView->getModel()->getSelectedIndex();
if (selected < 0)

9
apps/openmw/mwgui/statswindow.cpp
View file

@ -347,9 +347,12 @@ namespace MWGui
float mult = PCstats.getLevelupAttributeMultiplier(attribute);
mult = std::min(mult, 100 - PCstats.getAttribute(attribute).getBase());
if (mult > 1)
detail << (detail.str().empty() ? "" : "\n") << "#{"
<< MyGUI::TextIterator::toTagsString(ESM::Attribute::sGmstAttributeIds[attribute]) << "} x"
<< MyGUI::utility::toString(mult);
{
if (!detail.view().empty())
detail << '\n';
detail << "#{" << MyGUI::TextIterator::toTagsString(ESM::Attribute::sGmstAttributeIds[attribute])
<< "} x" << MyGUI::utility::toString(mult);
}
}
detailText = MyGUI::LanguageManager::getInstance().replaceTags(detail.str());

16
apps/openmw/mwgui/tooltips.cpp
View file

@ -169,9 +169,9 @@ namespace MWGui
return;
}
std::string type = focus->getUserString("ToolTipType");
std::string_view type = focus->getUserString("ToolTipType");
if (type == "")
if (type.empty())
{
return;
}
@ -252,8 +252,8 @@ namespace MWGui
int school = MWMechanics::getSpellSchool(spell, player);
info.text = "#{sSchool}: " + sSchoolNames[school];
}
std::string cost = focus->getUserString("SpellCost");
if (cost != "" && cost != "0")
const std::string& cost = focus->getUserString("SpellCost");
if (!cost.empty() && cost != "0")
info.text
+= MWGui::ToolTips::getValueString(MWMechanics::calcSpellCost(*spell), "#{sCastCost}");
info.effects = effects;
@ -267,7 +267,7 @@ namespace MWGui
tooltip->setVisible(true);
std::map<std::string, std::string> userStrings = focus->getUserStrings();
const auto& userStrings = focus->getUserStrings();
for (auto& userStringPair : userStrings)
{
size_t underscorePos = userStringPair.first.find('_');
@ -496,7 +496,7 @@ namespace MWGui
if (!info.effects.empty())
{
MyGUI::Widget* effectArea = mDynamicToolTipBox->createWidget<MyGUI::Widget>("",
MyGUI::Widget* effectArea = mDynamicToolTipBox->createWidget<MyGUI::Widget>({},
MyGUI::IntCoord(padding.left, totalSize.height, 300 - padding.left, 300 - totalSize.height),
MyGUI::Align::Stretch);
@ -518,7 +518,7 @@ namespace MWGui
if (enchant)
{
MyGUI::Widget* enchantArea = mDynamicToolTipBox->createWidget<MyGUI::Widget>("",
MyGUI::Widget* enchantArea = mDynamicToolTipBox->createWidget<MyGUI::Widget>({},
MyGUI::IntCoord(padding.left, totalSize.height, 300 - padding.left, 300 - totalSize.height),
MyGUI::Align::Stretch);
@ -932,7 +932,7 @@ namespace MWGui
void ToolTips::createClassToolTip(MyGUI::Widget* widget, const ESM::Class& playerClass)
{
if (playerClass.mName == "")
if (playerClass.mName.empty())
return;
int spec = playerClass.mData.mSpecialization;

2
apps/openmw/mwgui/tradewindow.cpp
View file

@ -128,7 +128,7 @@ namespace MWGui
setTitle(actor.getClass().getName(actor));
onFilterChanged(mFilterAll);
mFilterEdit->setCaption("");
mFilterEdit->setCaption({});
}
void TradeWindow::onFrame(float dt)

2
apps/openmw/mwgui/travelwindow.cpp
View file

@ -171,7 +171,7 @@ namespace MWGui
MWBase::Environment::get().getWindowManager()->fadeScreenOut(1);
ESM::Position pos = *_sender->getUserData<ESM::Position>();
const std::string& cellname = _sender->getUserString("Destination");
std::string_view cellname = _sender->getUserString("Destination");
bool interior = _sender->getUserString("interior") == "y";
if (mPtr.getCell()->isExterior())
{

8
apps/openmw/mwgui/widgets.cpp
View file

@ -62,7 +62,7 @@ namespace MWGui::Widgets
{
if (mSkillId == ESM::Skill::Length)
{
mSkillNameWidget->setCaption("");
mSkillNameWidget->setCaption({});
}
else
{
@ -147,7 +147,7 @@ namespace MWGui::Widgets
{
if (mId < 0 || mId >= 8)
{
mAttributeNameWidget->setCaption("");
mAttributeNameWidget->setCaption({});
}
else
{
@ -251,7 +251,7 @@ namespace MWGui::Widgets
if (spell)
mSpellNameWidget->setCaption(spell->mName);
else
mSpellNameWidget->setCaption("");
mSpellNameWidget->setCaption({});
}
}
@ -371,7 +371,7 @@ namespace MWGui::Widgets
mTextWidget->setCoord(sIconOffset / 2, mTextWidget->getCoord().top, mTextWidget->getCoord().width,
mTextWidget->getCoord().height); // Compensates for the missing image when effect is not known
mRequestedWidth = mTextWidget->getTextSize().width + sIconOffset;
mImageWidget->setImageTexture("");
mImageWidget->setImageTexture({});
return;
}

7
apps/openmw/mwgui/windowmanagerimp.cpp
View file

@ -212,7 +212,7 @@ namespace MWGui
resourceSystem->getVFS(), mScalingFactor, "mygui", logpath / "MyGUI.log");
mGui = std::make_unique<MyGUI::Gui>();
mGui->initialise("");
mGui->initialise({});
createTextures();
@ -517,7 +517,7 @@ namespace MWGui
trackWindow(mPostProcessorHud, makePostprocessorWindowSettingValues());
mInputBlocker = MyGUI::Gui::getInstance().createWidget<MyGUI::Widget>(
"", 0, 0, w, h, MyGUI::Align::Stretch, "InputBlocker");
{}, 0, 0, w, h, MyGUI::Align::Stretch, "InputBlocker");
mHud->setVisible(true);
@ -796,7 +796,8 @@ namespace MWGui
{
if (getMode() == GM_Dialogue && showInDialogueMode != MWGui::ShowInDialogueMode_Never)
{
mDialogueWindow->addMessageBox(MyGUI::LanguageManager::getInstance().replaceTags(toUString(message)));
MyGUI::UString text = MyGUI::LanguageManager::getInstance().replaceTags(toUString(message));
mDialogueWindow->addMessageBox(text.asUTF8());
}
else if (showInDialogueMode != MWGui::ShowInDialogueMode_Only)
{

40
components/fontloader/fontloader.cpp
View file

@ -29,15 +29,13 @@
namespace
{
MyGUI::xml::ElementPtr getProperty(MyGUI::xml::ElementPtr resourceNode, const std::string propertyName)
MyGUI::xml::ElementPtr getProperty(MyGUI::xml::ElementPtr resourceNode, std::string_view propertyName)
{
MyGUI::xml::ElementPtr propertyNode = nullptr;
MyGUI::xml::ElementEnumerator propertyIterator = resourceNode->getElementEnumerator();
while (propertyIterator.next("Property"))
{
std::string key = propertyIterator->findAttribute("key");
if (key == propertyName)
if (propertyIterator->findAttribute("key") == propertyName)
{
propertyNode = propertyIterator.current();
break;
@ -55,15 +53,15 @@ namespace
MyGUI::xml::ElementEnumerator layersIterator = root->getElementEnumerator();
while (layersIterator.next("Layer"))
{
std::string name = layersIterator->findAttribute("name");
if (name == "JournalBooks")
if (layersIterator->findAttribute("name") == "JournalBooks")
{
MyGUI::xml::ElementPtr sizeProperty = getProperty(layersIterator.current(), "Size");
const std::string& sizeValue
= sizeProperty != nullptr ? sizeProperty->findAttribute("value") : std::string();
if (!sizeValue.empty())
return MyGUI::IntSize::parse(sizeValue);
if (sizeProperty != nullptr)
{
std::string sizeValue = sizeProperty->findAttribute("value");
if (!sizeValue.empty())
return MyGUI::IntSize::parse(sizeValue);
}
}
}
@ -215,7 +213,7 @@ namespace
}
}
[[noreturn]] void fail(std::istream& stream, const std::string& fileName, const std::string& message)
[[noreturn]] void fail(std::istream& stream, std::string_view fileName, std::string_view message)
{
std::stringstream error;
error << "Font loading error: " << message;
@ -291,7 +289,7 @@ namespace Gui
MyGUI::IntSize bookSize = getBookSize(layersStream.get());
float bookScale = osgMyGUI::ScalingLayer::getScaleFactor(bookSize);
const auto oldDataPath = dataManager->getDataPath("");
const auto oldDataPath = dataManager->getDataPath({});
dataManager->setResourcePath("fonts");
std::unique_ptr<MyGUI::IDataStream> dataStream(dataManager->getData(fileName));
@ -303,8 +301,7 @@ namespace Gui
bool valid = false;
if (resourceNode.next("Resource"))
{
std::string type = resourceNode->findAttribute("type");
valid = (type == "ResourceTrueTypeFont");
valid = resourceNode->findAttribute("type") == "ResourceTrueTypeFont";
}
if (valid == false)
@ -450,7 +447,7 @@ namespace Gui
defaultHeight->addAttribute("value", fontSize);
MyGUI::xml::ElementPtr source = root->createChild("Property");
source->addAttribute("key", "Source");
source->addAttribute("value", std::string(bitmapFilename));
source->addAttribute("value", bitmapFilename);
MyGUI::xml::ElementPtr codes = root->createChild("Codes");
for (int i = 0; i < 256; i++)
@ -532,12 +529,12 @@ namespace Gui
additional.insert(std::make_pair(84, 0x2122)); // trademark sign
additional.insert(std::make_pair(45, 0x2212)); // minus sign
for (std::multimap<int, int>::iterator it = additional.begin(); it != additional.end(); ++it)
for (const auto [key, value] : additional)
{
if (it->first != i)
if (key != i)
continue;
code = codes->createChild("Code");
code->addAttribute("index", it->second);
code->addAttribute("index", value);
code->addAttribute("coord",
MyGUI::utility::toString(x1) + " " + MyGUI::utility::toString(y1) + " "
+ MyGUI::utility::toString(w) + " " + MyGUI::utility::toString(h));
@ -638,10 +635,9 @@ namespace Gui
return mFontHeight;
}
std::string FontLoader::getFontForFace(const std::string& face)
std::string_view FontLoader::getFontForFace(std::string_view face)
{
const std::string lowerFace = Misc::StringUtils::lowerCase(face);
if (lowerFace == "daedric")
if (Misc::StringUtils::ciEqual(face, "daedric"))
return "ScrollFont";
return "DefaultFont";

2
components/fontloader/fontloader.hpp
View file

@ -31,7 +31,7 @@ namespace Gui
int getFontHeight();
static std::string getFontForFace(const std::string& face);
static std::string_view getFontForFace(std::string_view face);
private:
ToUTF8::FromType mEncoding;

6
components/interpreter/defines.cpp
View file

@ -171,17 +171,17 @@ namespace
namespace Interpreter
{
std::string fixDefinesDialog(const std::string& text, Context& context)
std::string fixDefinesDialog(std::string_view text, Context& context)
{
return fixDefinesReal(text, true, context);
}
std::string fixDefinesMsgBox(const std::string& text, Context& context)
std::string fixDefinesMsgBox(std::string_view text, Context& context)
{
return fixDefinesReal(text, false, context);
}
std::string fixDefinesBook(const std::string& text, Context& context)
std::string fixDefinesBook(std::string_view text, Context& context)
{
return fixDefinesReal(text, false, context);
}

6
components/interpreter/defines.hpp
View file

@ -6,9 +6,9 @@
namespace Interpreter
{
std::string fixDefinesDialog(const std::string& text, Context& context);
std::string fixDefinesMsgBox(const std::string& text, Context& context);
std::string fixDefinesBook(const std::string& text, Context& context);
std::string fixDefinesDialog(std::string_view text, Context& context);
std::string fixDefinesMsgBox(std::string_view text, Context& context);
std::string fixDefinesBook(std::string_view text, Context& context);
}
#endif

6
components/resource/imagemanager.cpp
View file

@ -55,7 +55,7 @@ namespace Resource
ImageManager::~ImageManager() {}
bool checkSupported(osg::Image* image, const std::string& filename)
bool checkSupported(osg::Image* image)
{
switch (image->getPixelFormat())
{
@ -83,7 +83,7 @@ namespace Resource
return true;
}
osg::ref_ptr<osg::Image> ImageManager::getImage(const std::string& filename, bool disableFlip)
osg::ref_ptr<osg::Image> ImageManager::getImage(std::string_view filename, bool disableFlip)
{
const std::string normalized = mVFS->normalizeFilename(filename);
@ -149,7 +149,7 @@ namespace Resource
osg::ref_ptr<osg::Image> image = result.getImage();
image->setFileName(normalized);
if (!checkSupported(image, filename))
if (!checkSupported(image))
{
static bool uncompress = (getenv("OPENMW_DECOMPRESS_TEXTURES") != nullptr);
if (!uncompress)

2
components/resource/imagemanager.hpp
View file

@ -28,7 +28,7 @@ namespace Resource
/// Create or retrieve an Image
/// Returns the dummy image if the given image is not found.
osg::ref_ptr<osg::Image> getImage(const std::string& filename, bool disableFlip = false);
osg::ref_ptr<osg::Image> getImage(std::string_view filename, bool disableFlip = false);
osg::Image* getWarningImage();

12
components/sdlutil/sdlcursormanager.cpp
View file

@ -66,20 +66,20 @@ namespace SDLUtil
}
}
void SDLCursorManager::cursorChanged(const std::string& name)
void SDLCursorManager::cursorChanged(std::string_view name)
{
mCurrentCursor = name;
_setGUICursor(name);
_setGUICursor(mCurrentCursor);
}
void SDLCursorManager::_setGUICursor(const std::string& name)
void SDLCursorManager::_setGUICursor(std::string_view name)
{
auto it = mCursorMap.find(name);
if (it != mCursorMap.end())
SDL_SetCursor(it->second);
}
void SDLCursorManager::createCursor(const std::string& name, int rotDegrees, osg::Image* image, Uint8 hotspot_x,
void SDLCursorManager::createCursor(std::string_view name, int rotDegrees, osg::Image* image, Uint8 hotspot_x,
Uint8 hotspot_y, int cursorWidth, int cursorHeight)
{
#ifndef ANDROID
@ -128,7 +128,7 @@ namespace SDLUtil
return SDLUtil::SurfaceUniquePtr(targetSurface, SDL_FreeSurface);
}
void SDLCursorManager::_createCursorFromResource(const std::string& name, int rotDegrees, osg::Image* image,
void SDLCursorManager::_createCursorFromResource(std::string_view name, int rotDegrees, osg::Image* image,
Uint8 hotspot_x, Uint8 hotspot_y, int cursorWidth, int cursorHeight)
{
if (mCursorMap.find(name) != mCursorMap.end())
@ -141,7 +141,7 @@ namespace SDLUtil
// set the cursor and store it for later
SDL_Cursor* curs = SDL_CreateColorCursor(surface.get(), hotspot_x, hotspot_y);
mCursorMap.insert(CursorMap::value_type(std::string(name), curs));
mCursorMap.emplace(name, curs);
}
catch (std::exception& e)
{

10
components/sdlutil/sdlcursormanager.hpp
View file

@ -27,19 +27,19 @@ namespace SDLUtil
/// \brief Tell the manager that the cursor has changed, giving the
/// name of the cursor we changed to ("arrow", "ibeam", etc)
virtual void cursorChanged(const std::string& name);
virtual void cursorChanged(std::string_view name);
virtual void createCursor(const std::string& name, int rotDegrees, osg::Image* image, Uint8 hotspot_x,
virtual void createCursor(std::string_view name, int rotDegrees, osg::Image* image, Uint8 hotspot_x,
Uint8 hotspot_y, int cursorWidth, int cursorHeight);
private:
void _createCursorFromResource(const std::string& name, int rotDegrees, osg::Image* image, Uint8 hotspot_x,
void _createCursorFromResource(std::string_view name, int rotDegrees, osg::Image* image, Uint8 hotspot_x,
Uint8 hotspot_y, int cursorWidth, int cursorHeight);
void _putPixel(SDL_Surface* surface, int x, int y, Uint32 pixel);
void _setGUICursor(const std::string& name);
void _setGUICursor(std::string_view name);
typedef std::map<std::string, SDL_Cursor*> CursorMap;
typedef std::map<std::string, SDL_Cursor*, std::less<>> CursorMap;
CursorMap mCursorMap;
std::string mCurrentCursor;

2
components/widgets/imagebutton.cpp
View file

@ -42,7 +42,7 @@ namespace Gui
mImagePushed = _value;
else if (_key == "ImageNormal")
{
if (mImageNormal == "")
if (mImageNormal.empty())
{
setImageTexture(_value);
}