From 5859fd464cc123e7c813268f26b99505017ea482 Mon Sep 17 00:00:00 2001
From: elsid <elsid.mail@gmail.com>
Date: Fri, 8 Mar 2024 01:22:42 +0100
Subject: [PATCH] Add option to disable precompiled headers

To be able to use ccache.

Also fix compilation errors appeared due to absence of precompiled
headers.
---
 CMakeLists.txt                                 | 1 +
 apps/benchmarks/detournavigator/CMakeLists.txt | 2 +-
 apps/benchmarks/esm/CMakeLists.txt             | 2 +-
 apps/benchmarks/settings/CMakeLists.txt        | 2 +-
 apps/bsatool/CMakeLists.txt                    | 2 +-
 apps/bulletobjecttool/CMakeLists.txt           | 2 +-
 apps/esmtool/CMakeLists.txt                    | 2 +-
 apps/essimporter/CMakeLists.txt                | 2 +-
 apps/launcher/CMakeLists.txt                   | 2 +-
 apps/mwiniimporter/CMakeLists.txt              | 2 +-
 apps/navmeshtool/CMakeLists.txt                | 2 +-
 apps/niftest/CMakeLists.txt                    | 2 +-
 apps/opencs/CMakeLists.txt                     | 2 +-
 apps/opencs_tests/CMakeLists.txt               | 2 +-
 apps/openmw/CMakeLists.txt                     | 2 +-
 apps/openmw_test_suite/CMakeLists.txt          | 2 +-
 components/CMakeLists.txt                      | 2 +-
 components/detournavigator/commulativeaabb.hpp | 2 +-
 components/esm/esm3exteriorcellrefid.hpp       | 2 +-
 components/esm/format.cpp                      | 1 +
 components/esm/generatedrefid.hpp              | 1 +
 components/platform/platform.cpp               | 5 ++++-
 extern/Base64/CMakeLists.txt                   | 2 +-
 extern/CMakeLists.txt                          | 2 +-
 extern/oics/CMakeLists.txt                     | 2 +-
 extern/osg-ffmpeg-videoplayer/CMakeLists.txt   | 2 +-
 26 files changed, 29 insertions(+), 23 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index acec38fad0..50af98393e 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -44,6 +44,7 @@ option(BUILD_BENCHMARKS         "Build benchmarks with Google Benchmark" OFF)
 option(BUILD_NAVMESHTOOL        "Build navmesh tool" ON)
 option(BUILD_BULLETOBJECTTOOL   "Build Bullet object tool" ON)
 option(BUILD_OPENCS_TESTS       "Build OpenMW Construction Set tests" OFF)
+option(PRECOMPILE_HEADERS_WITH_MSVC "Precompile most common used headers with MSVC (alternative to ccache)" ON)
 
 set(OpenGL_GL_PREFERENCE LEGACY)  # Use LEGACY as we use GL2; GLNVD is for GL3 and up.
 
diff --git a/apps/benchmarks/detournavigator/CMakeLists.txt b/apps/benchmarks/detournavigator/CMakeLists.txt
index 2b3a6abe51..ffe7818a5a 100644
--- a/apps/benchmarks/detournavigator/CMakeLists.txt
+++ b/apps/benchmarks/detournavigator/CMakeLists.txt
@@ -5,7 +5,7 @@ if (UNIX AND NOT APPLE)
     target_link_libraries(openmw_detournavigator_navmeshtilescache_benchmark ${CMAKE_THREAD_LIBS_INIT})
 endif()
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(openmw_detournavigator_navmeshtilescache_benchmark PRIVATE <algorithm>)
 endif()
 
diff --git a/apps/benchmarks/esm/CMakeLists.txt b/apps/benchmarks/esm/CMakeLists.txt
index 74870ceda1..9b5afd649d 100644
--- a/apps/benchmarks/esm/CMakeLists.txt
+++ b/apps/benchmarks/esm/CMakeLists.txt
@@ -5,7 +5,7 @@ if (UNIX AND NOT APPLE)
     target_link_libraries(openmw_esm_refid_benchmark ${CMAKE_THREAD_LIBS_INIT})
 endif()
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(openmw_esm_refid_benchmark PRIVATE <algorithm>)
 endif()
 
diff --git a/apps/benchmarks/settings/CMakeLists.txt b/apps/benchmarks/settings/CMakeLists.txt
index ccdd51eeac..51e2d2b0fd 100644
--- a/apps/benchmarks/settings/CMakeLists.txt
+++ b/apps/benchmarks/settings/CMakeLists.txt
@@ -8,7 +8,7 @@ if (UNIX AND NOT APPLE)
     target_link_libraries(openmw_settings_access_benchmark ${CMAKE_THREAD_LIBS_INIT})
 endif()
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(openmw_settings_access_benchmark PRIVATE <algorithm>)
 endif()
 
diff --git a/apps/bsatool/CMakeLists.txt b/apps/bsatool/CMakeLists.txt
index a567499ac6..e893feb91a 100644
--- a/apps/bsatool/CMakeLists.txt
+++ b/apps/bsatool/CMakeLists.txt
@@ -18,7 +18,7 @@ if (BUILD_WITH_CODE_COVERAGE)
     target_link_libraries(bsatool gcov)
 endif()
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(bsatool PRIVATE
         <filesystem>
         <fstream>
diff --git a/apps/bulletobjecttool/CMakeLists.txt b/apps/bulletobjecttool/CMakeLists.txt
index 6e6e1cdbb3..d9bba10195 100644
--- a/apps/bulletobjecttool/CMakeLists.txt
+++ b/apps/bulletobjecttool/CMakeLists.txt
@@ -19,7 +19,7 @@ if (WIN32)
     install(TARGETS openmw-bulletobjecttool RUNTIME DESTINATION ".")
 endif()
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(openmw-bulletobjecttool PRIVATE
         <string>
         <vector>
diff --git a/apps/esmtool/CMakeLists.txt b/apps/esmtool/CMakeLists.txt
index 6f7fa1a993..d26e2a2128 100644
--- a/apps/esmtool/CMakeLists.txt
+++ b/apps/esmtool/CMakeLists.txt
@@ -25,7 +25,7 @@ if (BUILD_WITH_CODE_COVERAGE)
     target_link_libraries(esmtool gcov)
 endif()
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(esmtool PRIVATE
         <fstream>
         <string>
diff --git a/apps/essimporter/CMakeLists.txt b/apps/essimporter/CMakeLists.txt
index c6c98791e3..5dfb747aee 100644
--- a/apps/essimporter/CMakeLists.txt
+++ b/apps/essimporter/CMakeLists.txt
@@ -47,7 +47,7 @@ if (WIN32)
     INSTALL(TARGETS openmw-essimporter RUNTIME DESTINATION ".")
 endif(WIN32)
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(openmw-essimporter PRIVATE
         <algorithm>
         <filesystem>
diff --git a/apps/launcher/CMakeLists.txt b/apps/launcher/CMakeLists.txt
index 0c888afe9d..bd6a7062fd 100644
--- a/apps/launcher/CMakeLists.txt
+++ b/apps/launcher/CMakeLists.txt
@@ -94,7 +94,7 @@ if(USE_QT)
     set_property(TARGET openmw-launcher PROPERTY AUTOMOC ON)
 endif(USE_QT)
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(openmw-launcher PRIVATE
         <boost/program_options/options_description.hpp>
 
diff --git a/apps/mwiniimporter/CMakeLists.txt b/apps/mwiniimporter/CMakeLists.txt
index 704393cd0d..49be8309ab 100644
--- a/apps/mwiniimporter/CMakeLists.txt
+++ b/apps/mwiniimporter/CMakeLists.txt
@@ -33,7 +33,7 @@ if (BUILD_WITH_CODE_COVERAGE)
     target_link_libraries(openmw-iniimporter gcov)
 endif()
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(openmw-iniimporter PRIVATE
         <string>
         <vector>
diff --git a/apps/navmeshtool/CMakeLists.txt b/apps/navmeshtool/CMakeLists.txt
index 9abd8dc283..13c8230abd 100644
--- a/apps/navmeshtool/CMakeLists.txt
+++ b/apps/navmeshtool/CMakeLists.txt
@@ -21,7 +21,7 @@ if (WIN32)
     install(TARGETS openmw-navmeshtool RUNTIME DESTINATION ".")
 endif()
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(openmw-navmeshtool PRIVATE
         <algorithm>
         <memory>
diff --git a/apps/niftest/CMakeLists.txt b/apps/niftest/CMakeLists.txt
index f112e087e3..cf37162f6e 100644
--- a/apps/niftest/CMakeLists.txt
+++ b/apps/niftest/CMakeLists.txt
@@ -17,6 +17,6 @@ if (BUILD_WITH_CODE_COVERAGE)
     target_link_libraries(niftest gcov)
 endif()
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(niftest PRIVATE <filesystem>)
 endif()
diff --git a/apps/opencs/CMakeLists.txt b/apps/opencs/CMakeLists.txt
index 9bf02e10c9..c2f249171a 100644
--- a/apps/opencs/CMakeLists.txt
+++ b/apps/opencs/CMakeLists.txt
@@ -292,7 +292,7 @@ if (BUILD_WITH_CODE_COVERAGE)
     target_link_libraries(openmw-cs-lib gcov)
 endif()
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(openmw-cs-lib PRIVATE
         <boost/program_options/options_description.hpp>
 
diff --git a/apps/opencs_tests/CMakeLists.txt b/apps/opencs_tests/CMakeLists.txt
index 2b7309f8b9..3bf783bb68 100644
--- a/apps/opencs_tests/CMakeLists.txt
+++ b/apps/opencs_tests/CMakeLists.txt
@@ -26,7 +26,7 @@ if (BUILD_WITH_CODE_COVERAGE)
     target_link_libraries(openmw-cs-tests PRIVATE gcov)
 endif()
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(openmw-cs-tests PRIVATE
         <gtest/gtest.h>
     )
diff --git a/apps/openmw/CMakeLists.txt b/apps/openmw/CMakeLists.txt
index 5fb06881ec..5fb4f398f1 100644
--- a/apps/openmw/CMakeLists.txt
+++ b/apps/openmw/CMakeLists.txt
@@ -161,7 +161,7 @@ target_link_libraries(openmw
     components
 )
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(openmw PRIVATE
         <boost/program_options/options_description.hpp>
 
diff --git a/apps/openmw_test_suite/CMakeLists.txt b/apps/openmw_test_suite/CMakeLists.txt
index 71da2de590..3fe76623bf 100644
--- a/apps/openmw_test_suite/CMakeLists.txt
+++ b/apps/openmw_test_suite/CMakeLists.txt
@@ -126,7 +126,7 @@ target_compile_definitions(openmw_test_suite
     PRIVATE OPENMW_DATA_DIR=u8"${CMAKE_CURRENT_BINARY_DIR}/data"
             OPENMW_PROJECT_SOURCE_DIR=u8"${PROJECT_SOURCE_DIR}")
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(openmw_test_suite PRIVATE
         <boost/program_options/options_description.hpp>
 
diff --git a/components/CMakeLists.txt b/components/CMakeLists.txt
index 8bdead1357..1c553e855e 100644
--- a/components/CMakeLists.txt
+++ b/components/CMakeLists.txt
@@ -691,7 +691,7 @@ if(USE_QT)
     set_property(TARGET components_qt PROPERTY AUTOMOC ON)
 endif(USE_QT)
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(components PUBLIC
         <sol/sol.hpp>
 
diff --git a/components/detournavigator/commulativeaabb.hpp b/components/detournavigator/commulativeaabb.hpp
index 5d24c329ca..46cf64b348 100644
--- a/components/detournavigator/commulativeaabb.hpp
+++ b/components/detournavigator/commulativeaabb.hpp
@@ -3,7 +3,7 @@
 
 #include <BulletCollision/Gimpact/btBoxCollision.h>
 
-#include <cstdint>
+#include <cstddef>
 
 namespace DetourNavigator
 {
diff --git a/components/esm/esm3exteriorcellrefid.hpp b/components/esm/esm3exteriorcellrefid.hpp
index 5fca8dc597..fd6a9b128d 100644
--- a/components/esm/esm3exteriorcellrefid.hpp
+++ b/components/esm/esm3exteriorcellrefid.hpp
@@ -3,7 +3,7 @@
 
 #include <functional>
 #include <iosfwd>
-
+#include <string>
 #include <utility>
 
 #include <components/misc/hash.hpp>
diff --git a/components/esm/format.cpp b/components/esm/format.cpp
index aa869ab998..04edc5c7db 100644
--- a/components/esm/format.cpp
+++ b/components/esm/format.cpp
@@ -3,6 +3,7 @@
 #include <cstring>
 #include <istream>
 #include <stdexcept>
+#include <string>
 
 namespace ESM
 {
diff --git a/components/esm/generatedrefid.hpp b/components/esm/generatedrefid.hpp
index c5cd1bcef5..e9d07ff314 100644
--- a/components/esm/generatedrefid.hpp
+++ b/components/esm/generatedrefid.hpp
@@ -4,6 +4,7 @@
 #include <cstdint>
 #include <functional>
 #include <iosfwd>
+#include <string>
 
 namespace ESM
 {
diff --git a/components/platform/platform.cpp b/components/platform/platform.cpp
index 787cfa522e..9743c14337 100644
--- a/components/platform/platform.cpp
+++ b/components/platform/platform.cpp
@@ -1,12 +1,15 @@
 #include "platform.hpp"
 
+#ifdef WIN32
+#include <stdio.h>
+#endif
+
 namespace Platform
 {
 
     static void increaseFileHandleLimit()
     {
 #ifdef WIN32
-#include <stdio.h>
         // Increase limit for open files at the stream I/O level, see
         // https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/setmaxstdio?view=msvc-170#remarks
         _setmaxstdio(8192);
diff --git a/extern/Base64/CMakeLists.txt b/extern/Base64/CMakeLists.txt
index 94992a22b5..fc750823c7 100644
--- a/extern/Base64/CMakeLists.txt
+++ b/extern/Base64/CMakeLists.txt
@@ -1,6 +1,6 @@
 add_library(Base64 INTERFACE)
 target_include_directories(Base64 INTERFACE .)
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(Base64 INTERFACE <string>)
 endif()
diff --git a/extern/CMakeLists.txt b/extern/CMakeLists.txt
index 4a2cf1162b..1a6fcf2625 100644
--- a/extern/CMakeLists.txt
+++ b/extern/CMakeLists.txt
@@ -234,7 +234,7 @@ if (NOT OPENMW_USE_SYSTEM_YAML_CPP)
     )
     FetchContent_MakeAvailableExcludeFromAll(yaml-cpp)
 
-    if (MSVC)
+    if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
         target_precompile_headers(yaml-cpp PRIVATE <algorithm>)
     endif()
 endif()
diff --git a/extern/oics/CMakeLists.txt b/extern/oics/CMakeLists.txt
index 4bd3bc51ad..2d34f3f3e6 100644
--- a/extern/oics/CMakeLists.txt
+++ b/extern/oics/CMakeLists.txt
@@ -22,6 +22,6 @@ endif()
 
 target_link_libraries(oics SDL2::SDL2)
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(oics PUBLIC <algorithm> <string>)
 endif()
diff --git a/extern/osg-ffmpeg-videoplayer/CMakeLists.txt b/extern/osg-ffmpeg-videoplayer/CMakeLists.txt
index 10c8d356a0..8ff608bf04 100644
--- a/extern/osg-ffmpeg-videoplayer/CMakeLists.txt
+++ b/extern/osg-ffmpeg-videoplayer/CMakeLists.txt
@@ -18,7 +18,7 @@ target_link_libraries(${OSG_FFMPEG_VIDEOPLAYER_LIBRARY} SDL2::SDL2)
 
 link_directories(${CMAKE_CURRENT_BINARY_DIR})
 
-if (MSVC)
+if (MSVC AND PRECOMPILE_HEADERS_WITH_MSVC)
     target_precompile_headers(${OSG_FFMPEG_VIDEOPLAYER_LIBRARY} PUBLIC
         <memory>
         <string>