mirror/openmw
1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-04-01 09:36:40 +00:00
Code Issues Releases Wiki Activity

Use static QFile::exists instead of creating object

Browse source
This commit is contained in:
elsid 2023-03-20 23:05:57 +01:00
parent ecb9c35268
commit 62536d5cf7
No known key found for this signature in database
GPG key ID: 4DE04C198CBA7625
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
apps/launcher/datafilespage.cpp
View file

@ -401,11 +401,8 @@ QStringList Launcher::DataFilesPage::selectedFilePaths() const
ContentSelectorModel::ContentFileList items = mSelector->selectedFiles(); ContentSelectorModel::ContentFileList items = mSelector->selectedFiles();
QStringList filePaths; QStringList filePaths;
for (const ContentSelectorModel::EsmFile* item : items) for (const ContentSelectorModel::EsmFile* item : items)
{ if (QFile::exists(item->filePath()))
QFile file(item->filePath());
if (file.exists())
filePaths.append(item->filePath()); filePaths.append(item->filePath());
}
return filePaths; return filePaths;
} }

3
apps/wizard/existinginstallationpage.cpp
View file

@ -50,9 +50,8 @@ bool Wizard::ExistingInstallationPage::validatePage()
// Or failed to be detected due to the target being a symlink // Or failed to be detected due to the target being a symlink
QString path(field(QLatin1String("installation.path")).toString()); QString path(field(QLatin1String("installation.path")).toString());
QFile file(mWizard->mInstallations[path].iniPath);
if (!file.exists()) if (!QFile::exists(mWizard->mInstallations[path].iniPath))
{ {
QMessageBox msgBox; QMessageBox msgBox;
msgBox.setWindowTitle(tr("Error detecting Morrowind configuration")); msgBox.setWindowTitle(tr("Error detecting Morrowind configuration"));