Use static QFile::exists instead of creating object

depth-refraction
elsid 2 years ago
parent ecb9c35268
commit 62536d5cf7
No known key found for this signature in database
GPG Key ID: 4DE04C198CBA7625

@ -401,11 +401,8 @@ QStringList Launcher::DataFilesPage::selectedFilePaths() const
ContentSelectorModel::ContentFileList items = mSelector->selectedFiles(); ContentSelectorModel::ContentFileList items = mSelector->selectedFiles();
QStringList filePaths; QStringList filePaths;
for (const ContentSelectorModel::EsmFile* item : items) for (const ContentSelectorModel::EsmFile* item : items)
{ if (QFile::exists(item->filePath()))
QFile file(item->filePath());
if (file.exists())
filePaths.append(item->filePath()); filePaths.append(item->filePath());
}
return filePaths; return filePaths;
} }

@ -50,9 +50,8 @@ bool Wizard::ExistingInstallationPage::validatePage()
// Or failed to be detected due to the target being a symlink // Or failed to be detected due to the target being a symlink
QString path(field(QLatin1String("installation.path")).toString()); QString path(field(QLatin1String("installation.path")).toString());
QFile file(mWizard->mInstallations[path].iniPath);
if (!file.exists()) if (!QFile::exists(mWizard->mInstallations[path].iniPath))
{ {
QMessageBox msgBox; QMessageBox msgBox;
msgBox.setWindowTitle(tr("Error detecting Morrowind configuration")); msgBox.setWindowTitle(tr("Error detecting Morrowind configuration"));

Loading…
Cancel
Save