Merge branch 'enchanting' into companion

apps/openmw/CMakeLists.txt

@@ -31,7 +31,7 @@ add_openmw_dir (mwgui
     confirmationdialog alchemywindow referenceinterface spellwindow mainmenu quickkeysmenu
     itemselection spellbuyingwindow loadingscreen levelupdialog waitdialog spellcreationdialog
     enchantingdialog trainingwindow travelwindow imagebutton exposedwindow cursor spellicons
-    merchantrepair repair
+    merchantrepair repair soulgemdialog
     )
 
 add_openmw_dir (mwdialogue
@@ -54,7 +54,7 @@ add_openmw_dir (mwworld
     containerstore actiontalk actiontake manualref player cellfunctors failedaction
     cells localscripts customdata weather inventorystore ptr actionopen actionread
     actionequip timestamp actionalchemy cellstore actionapply actioneat
-    esmstore store recordcmp fallback actionrepair
+    esmstore store recordcmp fallback actionrepair actionsoulgem
     )
 
 add_openmw_dir (mwclass

apps/openmw/mwbase/windowmanager.hpp

@@ -237,10 +237,13 @@ namespace MWBase
 
             virtual void startSpellMaking(MWWorld::Ptr actor) = 0;
             virtual void startEnchanting(MWWorld::Ptr actor) = 0;
+            virtual void startSelfEnchanting(MWWorld::Ptr soulgem) = 0;
             virtual void startTraining(MWWorld::Ptr actor) = 0;
             virtual void startRepair(MWWorld::Ptr actor) = 0;
             virtual void startRepairItem(MWWorld::Ptr item) = 0;
 
+            virtual void showSoulgemDialog (MWWorld::Ptr item) = 0;
+
             virtual void changePointer (const std::string& name) = 0;
 
             virtual const Translation::Storage& getTranslationDataStorage() const = 0;

apps/openmw/mwclass/container.cpp

@@ -115,7 +115,7 @@ namespace MWClass
 
         if (needKey && hasKey)
         {
-            MWBase::Environment::get().getWindowManager ()->messageBox (keyName + " #{sKeyUsed}", std::vector<std::string>());
+            MWBase::Environment::get().getWindowManager ()->messageBox (keyName + " #{sKeyUsed}");
             ptr.getCellRef().mLockLevel = 0;
             // using a key disarms the trap
             ptr.getCellRef().mTrap = "";

apps/openmw/mwclass/door.cpp

@@ -98,7 +98,7 @@ namespace MWClass
 
         if (needKey && hasKey)
         {
-            MWBase::Environment::get().getWindowManager ()->messageBox (keyName + " #{sKeyUsed}", std::vector<std::string>());
+            MWBase::Environment::get().getWindowManager ()->messageBox (keyName + " #{sKeyUsed}");
             ptr.getCellRef().mLockLevel = 0;
             // using a key disarms the trap
             ptr.getCellRef().mTrap = "";

apps/openmw/mwclass/misc.cpp

@@ -15,6 +15,7 @@
 #include "../mwworld/physicssystem.hpp"
 #include "../mwworld/manualref.hpp"
 #include "../mwworld/nullaction.hpp"
+#include "../mwworld/actionsoulgem.hpp"
 
 #include "../mwgui/tooltips.hpp"
 
@@ -238,4 +239,13 @@ namespace MWClass
         }
         return newPtr;
     }
+
+    boost::shared_ptr<MWWorld::Action> Miscellaneous::use (const MWWorld::Ptr& ptr) const
+    {
+        if (ptr.getCellRef().mSoul == "")
+            return boost::shared_ptr<MWWorld::Action>(new MWWorld::NullAction());
+        else
+            return boost::shared_ptr<MWWorld::Action>(new MWWorld::ActionSoulgem(ptr));
+    }
+
 }

apps/openmw/mwclass/misc.hpp

@@ -49,6 +49,10 @@ namespace MWClass
             ///< Return name of inventory icon.
 
             virtual std::string getModel(const MWWorld::Ptr &ptr) const;
+
+            virtual boost::shared_ptr<MWWorld::Action> use (const MWWorld::Ptr& ptr)
+                const;
+            ///< Generate action for using via inventory menu
     };
 }
 

apps/openmw/mwgui/alchemywindow.cpp

@@ -77,40 +77,40 @@ namespace MWGui
 
         if (result == MWMechanics::Alchemy::Result_NoName)
         {
-            mWindowManager.messageBox("#{sNotifyMessage37}", std::vector<std::string>());
+            mWindowManager.messageBox("#{sNotifyMessage37}");
             return;
         }
 
         // check if mortar & pestle is available (always needed)
         if (result == MWMechanics::Alchemy::Result_NoMortarAndPestle)
         {
-            mWindowManager.messageBox("#{sNotifyMessage45}", std::vector<std::string>());
+            mWindowManager.messageBox("#{sNotifyMessage45}");
             return;
         }
 
         // make sure 2 or more ingredients were selected
         if (result == MWMechanics::Alchemy::Result_LessThanTwoIngredients)
         {
-            mWindowManager.messageBox("#{sNotifyMessage6a}", std::vector<std::string>());
+            mWindowManager.messageBox("#{sNotifyMessage6a}");
             return;
         }
 
         if (result == MWMechanics::Alchemy::Result_NoEffects)
         {
-            mWindowManager.messageBox("#{sNotifyMessage8}", std::vector<std::string>());
+            mWindowManager.messageBox("#{sNotifyMessage8}");
             MWBase::Environment::get().getSoundManager()->playSound("potion fail", 1.f, 1.f);
             return;
         }
 
         if (result == MWMechanics::Alchemy::Result_Success)
         {
-            mWindowManager.messageBox("#{sPotionSuccess}", std::vector<std::string>());
+            mWindowManager.messageBox("#{sPotionSuccess}");
             MWBase::Environment::get().getSoundManager()->playSound("potion success", 1.f, 1.f);
         }
         else if (result == MWMechanics::Alchemy::Result_RandomFailure)
         {
             // potion failed
-            mWindowManager.messageBox("#{sNotifyMessage8}", std::vector<std::string>());
+            mWindowManager.messageBox("#{sNotifyMessage8}");
             MWBase::Environment::get().getSoundManager()->playSound("potion fail", 1.f, 1.f);
         }
 

apps/openmw/mwgui/container.cpp

@@ -150,7 +150,7 @@ void ContainerBase::onSelectedItem(MyGUI::Widget* _sender)
             {
                 // user notification "i don't buy this item"
                 MWBase::Environment::get().getWindowManager()->
-                        messageBox("#{sBarterDialog4}", std::vector<std::string>());
+                        messageBox("#{sBarterDialog4}");
                 return;
             }
         }
@@ -294,7 +294,7 @@ void ContainerBase::onContainerClicked(MyGUI::Widget* _sender)
                 {
                     // user notification
                     MWBase::Environment::get().getWindowManager()->
-                        messageBox("#{sContentsMessage2}", std::vector<std::string>());
+                        messageBox("#{sContentsMessage2}");
 
                     return;
                 }
@@ -318,7 +318,7 @@ void ContainerBase::onContainerClicked(MyGUI::Widget* _sender)
                     object.getRefData().setCount(origCount);
                     // user notification
                     MWBase::Environment::get().getWindowManager()->
-                        messageBox("#{sContentsMessage3}", std::vector<std::string>());
+                        messageBox("#{sContentsMessage3}");
 
                     return;
                 }

apps/openmw/mwgui/enchantingdialog.cpp

@@ -92,6 +92,11 @@ namespace MWGui
         startEditing ();
     }
 
+    void EnchantingDialog::startSelfEnchanting(MWWorld::Ptr soulgem)
+    {
+        /// \todo
+    }
+
     void EnchantingDialog::onReferenceUnavailable ()
     {
         mWindowManager.removeGuiMode (GM_Dialogue);
@@ -158,7 +163,7 @@ namespace MWGui
 
         if(mEnchanting.getGemCharge()==0)
         {
-            mWindowManager.messageBox ("#{sNotifyMessage32}", std::vector<std::string>());
+            mWindowManager.messageBox ("#{sNotifyMessage32}");
             return;
         }
 
@@ -222,31 +227,37 @@ namespace MWGui
     {
         if (mEffects.size() <= 0)
         {
-            mWindowManager.messageBox ("#{sNotifyMessage30}", std::vector<std::string>());
+            mWindowManager.messageBox ("#{sNotifyMessage30}");
             return;
         }
 
         if (mName->getCaption ().empty())
         {
-            mWindowManager.messageBox ("#{sNotifyMessage10}", std::vector<std::string>());
+            mWindowManager.messageBox ("#{sNotifyMessage10}");
             return;
         }
 
         if (boost::lexical_cast<int>(mPrice->getCaption()) > mWindowManager.getInventoryWindow()->getPlayerGold())
         {
-            mWindowManager.messageBox ("#{sNotifyMessage18}", std::vector<std::string>());
+            mWindowManager.messageBox ("#{sNotifyMessage18}");
             return;
         }
 
         if (mEnchanting.soulEmpty())
         {
-            mWindowManager.messageBox ("#{sNotifyMessage52}", std::vector<std::string>());
+            mWindowManager.messageBox ("#{sNotifyMessage52}");
             return;
         }
 
         if (mEnchanting.itemEmpty())
         {
-            mWindowManager.messageBox ("#{sNotifyMessage11}", std::vector<std::string>());
+            mWindowManager.messageBox ("#{sNotifyMessage11}");
+            return;
+        }
+
+        if (mEnchanting.getEnchantCost() > mEnchanting.getMaxEnchantValue())
+        {
+            mWindowManager.messageBox ("#{sNotifyMessage29}");
             return;
         }
 
@@ -254,7 +265,7 @@ namespace MWGui
         mEnchanting.setEffect(mEffectList);
 
         mEnchanting.create();
-        mWindowManager.messageBox ("#{sEnchantmentMenu12}", std::vector<std::string>());
+        mWindowManager.messageBox ("#{sEnchantmentMenu12}");
         mWindowManager.removeGuiMode (GM_Enchanting);
     }
 }

apps/openmw/mwgui/enchantingdialog.hpp

@@ -22,6 +22,7 @@ namespace MWGui
 
         virtual void open();
         void startEnchanting(MWWorld::Ptr actor);
+        void startSelfEnchanting(MWWorld::Ptr soulgem);
 
     protected:
         virtual void onReferenceUnavailable();

apps/openmw/mwgui/levelupdialog.cpp

@@ -162,7 +162,7 @@ namespace MWGui
         MWMechanics::NpcStats& pcStats = MWWorld::Class::get(player).getNpcStats (player);
 
         if (mSpentAttributes.size() < 3)
-            MWBase::Environment::get().getWindowManager ()->messageBox("#{sNotifyMessage36}", std::vector<std::string>());
+            MWBase::Environment::get().getWindowManager ()->messageBox("#{sNotifyMessage36}");
         else
         {
             // increase attributes

apps/openmw/mwgui/messagebox.cpp

@@ -3,6 +3,7 @@
 #include "messagebox.hpp"
 #include "../mwbase/environment.hpp"
 #include "../mwbase/soundmanager.hpp"
+#include "../mwbase/inputmanager.hpp"
 
 using namespace MWGui;
 
@@ -62,7 +63,8 @@ void MessageBoxManager::onFrame (float frameDuration)
     if(mInterMessageBoxe != NULL && mInterMessageBoxe->mMarkedToDelete) {
         delete mInterMessageBoxe;
         mInterMessageBoxe = NULL;
-        mWindowManager->removeGuiMode(GM_InterMessageBox);
+        MWBase::Environment::get().getInputManager()->changeInputMode(
+                    MWBase::Environment::get().getWindowManager()->isGuiMode());
     }
 }
 
@@ -90,11 +92,8 @@ void MessageBoxManager::createMessageBox (const std::string& message)
 
 bool MessageBoxManager::createInteractiveMessageBox (const std::string& message, const std::vector<std::string>& buttons)
 {
-    /// \todo Don't write this kind of error message to cout. Either discard the old message box
-    /// silently or throw an exception.
     if(mInterMessageBoxe != NULL) {
-        std::cout << "there is a MessageBox already" << std::endl;
+        throw std::runtime_error("There is a message box already");
-        return false;
     }
 
     mInterMessageBoxe = new InteractiveMessageBox(*this, message, buttons);
@@ -139,7 +138,8 @@ void MessageBoxManager::setMessageBoxSpeed (int speed)
 
 void MessageBoxManager::enterPressed ()
 {
-    mInterMessageBoxe->enterPressed();
+    if(mInterMessageBoxe != NULL)
+        mInterMessageBoxe->enterPressed();
 }
 
 int MessageBoxManager::readPressedButton ()
@@ -213,10 +213,12 @@ int MessageBox::getHeight ()
 
 
 InteractiveMessageBox::InteractiveMessageBox(MessageBoxManager& parMessageBoxManager, const std::string& message, const std::vector<std::string>& buttons)
-  : Layout("openmw_interactive_messagebox.layout")
+    : WindowModal("openmw_interactive_messagebox.layout", *MWBase::Environment::get().getWindowManager())
   , mMessageBoxManager(parMessageBoxManager)
   , mButtonPressed(-1)
 {
+    WindowModal::open();
+
     int fixedWidth = 500;
     int textPadding = 10; // padding between text-widget and main-widget
     int textButtonPadding = 20; // padding between the text-widget und the button-widget
@@ -232,7 +234,7 @@ InteractiveMessageBox::InteractiveMessageBox(MessageBoxManager& parMessageBoxMan
     getWidget(mButtonsWidget, "buttons");
 
     mMessageWidget->setOverflowToTheLeft(true);
-    mMessageWidget->addText(message);
+    mMessageWidget->setCaptionWithReplacing(message);
 
     MyGUI::IntSize textSize = mMessageWidget->getTextSize();
 
@@ -252,7 +254,7 @@ InteractiveMessageBox::InteractiveMessageBox(MessageBoxManager& parMessageBoxMan
             std::string("MW_Button"),
             dummyCoord,
             MyGUI::Align::Default);
-        button->setCaption(*it);
+        button->setCaptionWithReplacing(*it);
 
         button->eventMouseButtonClick += MyGUI::newDelegate(this, &InteractiveMessageBox::mousePressed);
 
@@ -399,6 +401,7 @@ void InteractiveMessageBox::buttonActivated (MyGUI::Widget* pressed)
         if(*button == pressed)
         {
             mButtonPressed = index;
+            mMessageBoxManager.onButtonPressed(mButtonPressed);
             return;
         }
         index++;

apps/openmw/mwgui/messagebox.hpp

@@ -44,6 +44,13 @@ namespace MWGui
             void enterPressed();
             int readPressedButton ();
 
+            typedef MyGUI::delegates::CMultiDelegate1<int> EventHandle_Int;
+
+            // Note: this delegate unassigns itself after it was fired, i.e. works once.
+            EventHandle_Int eventButtonPressed;
+
+            void onButtonPressed(int button) { eventButtonPressed(button); eventButtonPressed.clear(); }
+
             MWBase::WindowManager *mWindowManager;
 
         private:
@@ -73,7 +80,7 @@ namespace MWGui
             int mNextBoxPadding;
     };
 
-    class InteractiveMessageBox : public OEngine::GUI::Layout
+    class InteractiveMessageBox : public WindowModal
     {
         public:
             InteractiveMessageBox (MessageBoxManager& parMessageBoxManager, const std::string& message, const std::vector<std::string>& buttons);

apps/openmw/mwgui/mode.hpp

@@ -5,6 +5,7 @@ namespace MWGui
 {
   enum GuiMode
     {
+      GM_None,
       GM_Settings,      // Settings window
       GM_Inventory,     // Inventory mode
       GM_Container,
@@ -41,9 +42,6 @@ namespace MWGui
       GM_ClassCreate,
       GM_Review,
       
-      // interactive MessageBox
-      GM_InterMessageBox,
-
       GM_Loading,
       GM_LoadingWallpaper,
 

apps/openmw/mwgui/quickkeysmenu.cpp

@@ -291,7 +291,7 @@ namespace MWGui
             if (item.getRefData ().getCount() == 0)
             {
                 MWBase::Environment::get().getWindowManager ()->messageBox (
-                            "#{sQuickMenu5} " + MWWorld::Class::get(item).getName(item), std::vector<std::string>());
+                            "#{sQuickMenu5} " + MWWorld::Class::get(item).getName(item));
                 return;
             }
 
@@ -317,7 +317,7 @@ namespace MWGui
             if (item.getRefData ().getCount() == 0)
             {
                 MWBase::Environment::get().getWindowManager ()->messageBox (
-                            "#{sQuickMenu5} " + MWWorld::Class::get(item).getName(item), std::vector<std::string>());
+                            "#{sQuickMenu5} " + MWWorld::Class::get(item).getName(item));
                 return;
             }
 

apps/openmw/mwgui/settingswindow.cpp

@@ -362,7 +362,7 @@ namespace MWGui
             {
                 std::string msg = "This resolution is not supported in Fullscreen mode. Please select a resolution from the list.";
                 MWBase::Environment::get().getWindowManager()->
-                    messageBox(msg, std::vector<std::string>());
+                    messageBox(msg);
                 _sender->castType<MyGUI::Button>()->setCaption(off);
             }
             else
@@ -593,7 +593,7 @@ namespace MWGui
 
         static_cast<MyGUI::Button*>(_sender)->setCaptionWithReplacing("#{sNone}");
 
-        MWBase::Environment::get().getWindowManager ()->messageBox ("#{sControlsMenu3}", std::vector<std::string>());
+        MWBase::Environment::get().getWindowManager ()->messageBox ("#{sControlsMenu3}");
         MWBase::Environment::get().getWindowManager ()->disallowMouse();
 
         MWBase::Environment::get().getInputManager ()->enableDetectingBindingMode (actionId);

apps/openmw/mwgui/soulgemdialog.cpp

@@ -0,0 +1,34 @@
+#include "soulgemdialog.hpp"
+
+#include "../mwbase/windowmanager.hpp"
+#include "../mwbase/environment.hpp"
+
+#include "messagebox.hpp"
+
+namespace MWGui
+{
+
+    void SoulgemDialog::show(const MWWorld::Ptr &soulgem)
+    {
+        mSoulgem = soulgem;
+        std::vector<std::string> buttons;
+        buttons.push_back("#{sRechargeEnchantment}");
+        buttons.push_back("#{sMake Enchantment}");
+        mManager->createInteractiveMessageBox("#{sDoYouWantTo}", buttons);
+        mManager->eventButtonPressed += MyGUI::newDelegate(this, &SoulgemDialog::onButtonPressed);
+    }
+
+    void SoulgemDialog::onButtonPressed(int button)
+    {
+        if (button == 0)
+        {
+            /// \todo show recharge enchanted item dialog here
+        }
+        else
+        {
+            MWBase::Environment::get().getWindowManager()->pushGuiMode(GM_Enchanting);
+            MWBase::Environment::get().getWindowManager()->startSelfEnchanting(mSoulgem);
+        }
+    }
+
+}

apps/openmw/mwgui/soulgemdialog.hpp

@@ -0,0 +1,28 @@
+#ifndef OPENMW_MWGUI_SOULGEMDIALOG_H
+#define OPENMW_MWGUI_SOULGEMDIALOG_H
+
+#include "../mwworld/ptr.hpp"
+
+namespace MWGui
+{
+
+    class MessageBoxManager;
+
+    class SoulgemDialog
+    {
+    public:
+        SoulgemDialog (MessageBoxManager* manager)
+            : mManager(manager) {}
+
+        void show (const MWWorld::Ptr& soulgem);
+
+        void onButtonPressed(int button);
+
+    private:
+        MessageBoxManager* mManager;
+        MWWorld::Ptr mSoulgem;
+    };
+
+}
+
+#endif

apps/openmw/mwgui/spellcreationdialog.cpp

@@ -310,25 +310,25 @@ namespace MWGui
     {
         if (mEffects.size() <= 0)
         {
-            mWindowManager.messageBox ("#{sNotifyMessage30}", std::vector<std::string>());
+            mWindowManager.messageBox ("#{sNotifyMessage30}");
             return;
         }
 
         if (mNameEdit->getCaption () == "")
         {
-            mWindowManager.messageBox ("#{sNotifyMessage10}", std::vector<std::string>());
+            mWindowManager.messageBox ("#{sNotifyMessage10}");
             return;
         }
 
         if (mMagickaCost->getCaption() == "0")
         {
-            mWindowManager.messageBox ("#{sEnchantmentMenu8}", std::vector<std::string>());
+            mWindowManager.messageBox ("#{sEnchantmentMenu8}");
             return;
         }
 
         if (boost::lexical_cast<int>(mPriceLabel->getCaption()) > mWindowManager.getInventoryWindow()->getPlayerGold())
         {
-            mWindowManager.messageBox ("#{sNotifyMessage18}", std::vector<std::string>());
+            mWindowManager.messageBox ("#{sNotifyMessage18}");
             return;
         }
 
@@ -517,7 +517,7 @@ namespace MWGui
     {
         if (mEffects.size() >= 8)
         {
-            MWBase::Environment::get().getWindowManager()->messageBox("#{sNotifyMessage28}", std::vector<std::string>());
+            MWBase::Environment::get().getWindowManager()->messageBox("#{sNotifyMessage28}");
             return;
         }
 
@@ -528,7 +528,7 @@ namespace MWGui
         {
             if (it->mEffectID == effectId)
             {
-                MWBase::Environment::get().getWindowManager()->messageBox ("#{sOnetypeEffectMessage}", std::vector<std::string>());
+                MWBase::Environment::get().getWindowManager()->messageBox ("#{sOnetypeEffectMessage}");
                 return;
             }
         }

apps/openmw/mwgui/spellwindow.cpp

@@ -404,7 +404,7 @@ namespace MWGui
             if (spell->mData.mFlags & ESM::Spell::F_Always
                 || spell->mData.mType == ESM::Spell::ST_Power)
             {
-                mWindowManager.messageBox("#{sDeleteSpellError}", std::vector<std::string>());
+                mWindowManager.messageBox("#{sDeleteSpellError}");
             }
             else
             {

apps/openmw/mwgui/text_input.cpp

@@ -50,7 +50,7 @@ void TextInputDialog::onOkClicked(MyGUI::Widget* _sender)
 {
     if (mTextEdit->getCaption() == "")
     {
-        mWindowManager.messageBox ("#{sNotifyMessage37}", std::vector<std::string>());
+        mWindowManager.messageBox ("#{sNotifyMessage37}");
         MyGUI::InputManager::getInstance ().setKeyFocusWidget (mTextEdit);
     }
     else
@@ -61,7 +61,7 @@ void TextInputDialog::onTextAccepted(MyGUI::Edit* _sender)
 {
     if (mTextEdit->getCaption() == "")
     {
-        mWindowManager.messageBox ("#{sNotifyMessage37}", std::vector<std::string>());
+        mWindowManager.messageBox ("#{sNotifyMessage37}");
         MyGUI::InputManager::getInstance ().setKeyFocusWidget (mTextEdit);
     }
     else

apps/openmw/mwgui/tradewindow.cpp

@@ -181,7 +181,7 @@ namespace MWGui
         {
             // user notification
             MWBase::Environment::get().getWindowManager()->
-                messageBox("#{sBarterDialog11}", std::vector<std::string>());
+                messageBox("#{sBarterDialog11}");
             return;
         }
 
@@ -190,7 +190,7 @@ namespace MWGui
         {
             // user notification
             MWBase::Environment::get().getWindowManager()->
-                messageBox("#{sBarterDialog1}", std::vector<std::string>());
+                messageBox("#{sBarterDialog1}");
             return;
         }
 
@@ -199,7 +199,7 @@ namespace MWGui
         {
             // user notification
             MWBase::Environment::get().getWindowManager()->
-                messageBox("#{sBarterDialog2}", std::vector<std::string>());
+                messageBox("#{sBarterDialog2}");
             return;
         }
 
@@ -209,7 +209,7 @@ namespace MWGui
             if (mPtr.getTypeName() != typeid(ESM::NPC).name())
             {
                 MWBase::Environment::get().getWindowManager()->
-                    messageBox("#{sNotifyMessage9}", std::vector<std::string>());
+                    messageBox("#{sNotifyMessage9}");
                 return;
             }
 
@@ -245,7 +245,7 @@ namespace MWGui
             if(roll > x) //trade refused
             {
                 MWBase::Environment::get().getWindowManager()->
-                    messageBox("#{sNotifyMessage9}", std::vector<std::string>());
+                    messageBox("#{sNotifyMessage9}");
 
                 int iBarterFailDisposition = gmst.find("iBarterFailDisposition")->getInt();
                 MWBase::Environment::get().getDialogueManager()->applyTemporaryDispositionChange(iBarterFailDisposition);

apps/openmw/mwgui/trainingwindow.cpp

@@ -129,7 +129,7 @@ namespace MWGui
         MWMechanics::NpcStats& npcStats = MWWorld::Class::get(mPtr).getNpcStats (mPtr);
         if (npcStats.getSkill (skillId).getBase () <= pcStats.getSkill (skillId).getBase ())
         {
-            mWindowManager.messageBox ("#{sServiceTrainingWords}", std::vector<std::string>());
+            mWindowManager.messageBox ("#{sServiceTrainingWords}");
             return;
         }
 

apps/openmw/mwgui/waitdialog.cpp

@@ -83,7 +83,7 @@ namespace MWGui
         if (canRest == 2)
         {
             // resting underwater or mid-air not allowed
-            mWindowManager.messageBox ("#{sNotifyMessage1}", std::vector<std::string>());
+            mWindowManager.messageBox ("#{sNotifyMessage1}");
             mWindowManager.popGuiMode ();
         }
 

apps/openmw/mwgui/windowmanagerimp.cpp

@@ -57,6 +57,7 @@
 #include "spellicons.hpp"
 #include "merchantrepair.hpp"
 #include "repair.hpp"
+#include "soulgemdialog.hpp"
 
 using namespace MWGui;
 
@@ -94,6 +95,7 @@ WindowManager::WindowManager(
   , mTrainingWindow(NULL)
   , mMerchantRepair(NULL)
   , mRepair(NULL)
+  , mSoulgemDialog(NULL)
   , mPlayerName()
   , mPlayerRaceId()
   , mPlayerAttributes()
@@ -186,6 +188,7 @@ WindowManager::WindowManager(
     mTrainingWindow = new TrainingWindow(*this);
     mMerchantRepair = new MerchantRepair(*this);
     mRepair = new Repair(*this);
+    mSoulgemDialog = new SoulgemDialog(mMessageBoxManager);
 
     mLoadingScreen = new LoadingScreen(mRendering->getScene (), mRendering->getWindow (), *this);
     mLoadingScreen->onResChange (w,h);
@@ -253,6 +256,7 @@ WindowManager::~WindowManager()
     delete mQuickKeysMenu;
     delete mMerchantRepair;
     delete mRepair;
+    delete mSoulgemDialog;
     delete mCursor;
 
     cleanupGarbage();
@@ -316,9 +320,6 @@ void WindowManager::updateVisible()
 
     mHud->setVisible(mHudEnabled);
 
-    // Mouse is visible whenever we're not in game mode
-    mCursor->setVisible(isGuiMode());
-
     bool gameMode = !isGuiMode();
 
     mInputBlocker->setVisible (gameMode);
@@ -444,8 +445,6 @@ void WindowManager::updateVisible()
         case GM_Repair:
             mRepair->setVisible(true);
             break;
-        case GM_InterMessageBox:
-            break;
         case GM_Journal:
             mJournal->setVisible(true);
             break;
@@ -609,7 +608,7 @@ void WindowManager::messageBox (const std::string& message, const std::vector<st
     else
     {
         mMessageBoxManager->createInteractiveMessageBox(message, buttons);
-        pushGuiMode(GM_InterMessageBox);
+        MWBase::Environment::get().getInputManager()->changeInputMode(isGuiMode());
     }
 }
 
@@ -648,6 +647,7 @@ void WindowManager::onDialogueWindowBye()
 void WindowManager::onFrame (float frameDuration)
 {
     mMessageBoxManager->onFrame(frameDuration);
+
     mToolTips->onFrame(frameDuration);
 
     if (mDragAndDrop->mIsOnDragAndDrop)
@@ -1033,12 +1033,12 @@ void WindowManager::toggleVisible (GuiWindow wnd)
 
 bool WindowManager::isGuiMode() const
 {
-    return !mGuiModes.empty();
+    return !mGuiModes.empty() || mMessageBoxManager->isInteractiveMessageBox();
 }
 
 bool WindowManager::isConsoleMode() const
 {
-    if (mGuiModes.back()==GM_Console)
+    if (!mGuiModes.empty() && mGuiModes.back()==GM_Console)
         return true;
     return false;
 }
@@ -1046,8 +1046,7 @@ bool WindowManager::isConsoleMode() const
 MWGui::GuiMode WindowManager::getMode() const
 {
     if (mGuiModes.empty())
-        throw std::runtime_error ("getMode() called, but there is no active mode");
+        return GM_None;
-
     return mGuiModes.back();
 }
 
@@ -1143,6 +1142,11 @@ void WindowManager::startEnchanting (MWWorld::Ptr actor)
     mEnchantingDialog->startEnchanting (actor);
 }
 
+void WindowManager::startSelfEnchanting(MWWorld::Ptr soulgem)
+{
+    mEnchantingDialog->startSelfEnchanting(soulgem);
+}
+
 void WindowManager::startTraining(MWWorld::Ptr actor)
 {
     mTrainingWindow->startTraining(actor);
@@ -1167,3 +1171,8 @@ void WindowManager::changePointer(const std::string &name)
 {
     mCursor->onCursorChange(name);
 }
+
+void WindowManager::showSoulgemDialog(MWWorld::Ptr item)
+{
+    mSoulgemDialog->show(item);
+}

apps/openmw/mwgui/windowmanagerimp.hpp

@@ -76,6 +76,7 @@ namespace MWGui
   class SpellIcons;
   class MerchantRepair;
   class Repair;
+  class SoulgemDialog;
 
   class WindowManager : public MWBase::WindowManager
   {
@@ -230,14 +231,19 @@ namespace MWGui
 
     virtual void startSpellMaking(MWWorld::Ptr actor);
     virtual void startEnchanting(MWWorld::Ptr actor);
+    virtual void startSelfEnchanting(MWWorld::Ptr soulgem);
     virtual void startTraining(MWWorld::Ptr actor);
     virtual void startRepair(MWWorld::Ptr actor);
     virtual void startRepairItem(MWWorld::Ptr item);
 
+    virtual void showSoulgemDialog (MWWorld::Ptr item);
+
     virtual void changePointer (const std::string& name);
 
     virtual const Translation::Storage& getTranslationDataStorage() const;
 
+    void onSoulgemDialogButtonPressed (int button);
+
   private:
     OEngine::GUI::MyGUIManager *mGuiManager;
     OEngine::Render::OgreRenderer *mRendering;
@@ -271,6 +277,7 @@ namespace MWGui
     EnchantingDialog* mEnchantingDialog;
     TrainingWindow* mTrainingWindow;
     MerchantRepair* mMerchantRepair;
+    SoulgemDialog* mSoulgemDialog;
     Repair* mRepair;
 
     Translation::Storage& mTranslationDataStorage;

apps/openmw/mwinput/inputmanagerimp.cpp

@@ -181,8 +181,7 @@ namespace MWInput
                 break;
             case A_Activate:
                 resetIdleTime();
-                if( MWBase::Environment::get().getWindowManager()->isGuiMode()
+                if( MWBase::Environment::get().getWindowManager()->isGuiMode()) {
-                    && MWBase::Environment::get().getWindowManager()->getMode() == MWGui::GM_InterMessageBox ) {
                         // Pressing the activation key when a messagebox is prompting for "ok" will activate the ok button
                         MWBase::Environment::get().getWindowManager()->enterPressed();
                     }
@@ -378,7 +377,7 @@ namespace MWInput
 
     void InputManager::changeInputMode(bool guiMode)
     {
-        // Are we in GUI mode now?
+        MWBase::Environment::get().getWindowManager()->setMouseVisible(guiMode);
         if(guiMode)
         {
             // Disable mouse look
@@ -462,8 +461,7 @@ namespace MWInput
     bool InputManager::keyPressed( const OIS::KeyEvent &arg )
     {
         if(arg.key == OIS::KC_RETURN
-            && MWBase::Environment::get().getWindowManager()->isGuiMode()
+            && MWBase::Environment::get().getWindowManager()->isGuiMode())
-            && MWBase::Environment::get().getWindowManager()->getMode() == MWGui::GM_InterMessageBox )
         {
             // Pressing enter when a messagebox is prompting for "ok" will activate the ok button
             MWBase::Environment::get().getWindowManager()->enterPressed();

apps/openmw/mwmechanics/actors.cpp

@@ -256,7 +256,7 @@ namespace MWMechanics
 
                 if(MWWorld::Class::get(iter->first).isEssential(iter->first))
                     MWBase::Environment::get().getWindowManager()->messageBox(
-                        "#{sKilledEssential}", std::vector<std::string>());
+                        "#{sKilledEssential}");
             }
         }
 

apps/openmw/mwmechanics/npcstats.cpp

@@ -221,12 +221,12 @@ void MWMechanics::NpcStats::increaseSkill(int skillIndex, const ESM::Class &clas
     message << boost::format(MWBase::Environment::get().getWindowManager ()->getGameSettingString ("sNotifyMessage39", ""))
                % std::string("#{" + ESM::Skill::sSkillNameIds[skillIndex] + "}")
                % static_cast<int> (base);
-    MWBase::Environment::get().getWindowManager ()->messageBox(message.str(), std::vector<std::string>());
+    MWBase::Environment::get().getWindowManager ()->messageBox(message.str());
 
     if (mLevelProgress >= 10)
     {
         // levelup is possible now
-        MWBase::Environment::get().getWindowManager ()->messageBox ("#{sLevelUpMsg}", std::vector<std::string>());
+        MWBase::Environment::get().getWindowManager ()->messageBox ("#{sLevelUpMsg}");
     }
 
     getSkill (skillIndex).setBase (base);

apps/openmw/mwscript/containerextensions.cpp

@@ -83,7 +83,7 @@ namespace MWScript
                             msgBox = boost::str(boost::format(msgBox) % count % itemName);
                         }
 
-                        MWBase::Environment::get().getWindowManager()->messageBox(msgBox, std::vector<std::string>());
+                        MWBase::Environment::get().getWindowManager()->messageBox(msgBox);
                     }
                 }
         };
@@ -179,7 +179,7 @@ namespace MWScript
                         }
 
                         if (numRemoved > 0)
-                            MWBase::Environment::get().getWindowManager()->messageBox(msgBox, std::vector<std::string>());
+                            MWBase::Environment::get().getWindowManager()->messageBox(msgBox);
                     }
                 }
         };

apps/openmw/mwworld/actionequip.cpp

@@ -62,7 +62,7 @@ namespace MWWorld
                         if((*itr).mPart == ESM::PRT_Head)
                         {
                             if(actor == MWBase::Environment::get().getWorld()->getPlayer().getPlayer() )
-                                MWBase::Environment::get().getWindowManager()->messageBox ("#{sNotifyMessage13}", std::vector<std::string>());
+                                MWBase::Environment::get().getWindowManager()->messageBox ("#{sNotifyMessage13}");
 
                             allow = false;
                             break;
@@ -90,12 +90,12 @@ namespace MWWorld
                             if(actor == MWBase::Environment::get().getWorld()->getPlayer().getPlayer() )
                             {
                                 if(it.getType() == MWWorld::ContainerStore::Type_Clothing){ // It's shoes
-                                    MWBase::Environment::get().getWindowManager()->messageBox ("#{sNotifyMessage15}", std::vector<std::string>());
+                                    MWBase::Environment::get().getWindowManager()->messageBox ("#{sNotifyMessage15}");
                                 }
 
                                 else // It's boots
                                 {
-                                    MWBase::Environment::get().getWindowManager()->messageBox ("#{sNotifyMessage14}", std::vector<std::string>());
+                                    MWBase::Environment::get().getWindowManager()->messageBox ("#{sNotifyMessage14}");
                                 }
                             }
                             break;

apps/openmw/mwworld/actionsoulgem.cpp

@@ -0,0 +1,21 @@
+#include "actionsoulgem.hpp"
+
+#include "../mwbase/windowmanager.hpp"
+#include "../mwbase/environment.hpp"
+
+namespace MWWorld
+{
+
+ActionSoulgem::ActionSoulgem(const Ptr &object)
+    : Action(false, object)
+{
+
+}
+
+void ActionSoulgem::executeImp(const Ptr &actor)
+{
+    MWBase::Environment::get().getWindowManager()->showSoulgemDialog(getTarget());
+}
+
+
+}

apps/openmw/mwworld/actionsoulgem.hpp

@@ -0,0 +1,19 @@
+#ifndef GAME_MWWORLD_ACTIONSOULGEM_H
+#define GAME_MWWORLD_ACTIONSOULGEM_H
+
+#include "action.hpp"
+#include "ptr.hpp"
+
+namespace MWWorld
+{
+    class ActionSoulgem : public Action
+    {
+            virtual void executeImp (const MWWorld::Ptr& actor);
+
+        public:
+            /// @param soulgem to use
+            ActionSoulgem (const Ptr& object);
+    };
+}
+
+#endif

apps/openmw/mwworld/failedaction.cpp

@@ -15,7 +15,7 @@ namespace MWWorld
     {
         if ( actor.getRefData().getHandle()=="player" && !(message.empty()))
 	{
-	  MWBase::Environment::get().getWindowManager() ->messageBox(message, std::vector<std::string>());
+      MWBase::Environment::get().getWindowManager() ->messageBox(message);
 	}
     }
 }

files/mygui/openmw_enchanting_dialog.layout

@@ -70,18 +70,18 @@
 
 
         <!-- Available effects -->
-        <Widget type="TextBox" skin="NormalText" position="12 148 300 24">
+        <Widget type="TextBox" skin="NormalText" position="12 108 300 24">
             <Property key="Caption" value="#{sMagicEffects}"/>
         </Widget>
-        <Widget type="MWList" skin="MW_SimpleList" position="12 176 202 169" name="AvailableEffects">
+        <Widget type="MWList" skin="MW_SimpleList" position="12 136 202 209" name="AvailableEffects">
         </Widget>
 
         <!-- Used effects -->
-        <Widget type="TextBox" skin="NormalText" position="226 148 300 24">
+        <Widget type="TextBox" skin="NormalText" position="226 108 300 24">
             <Property key="Caption" value="#{sEffects}"/>
         </Widget>
-        <Widget type="Widget" skin="MW_Box" position="226 176 316 169">
+        <Widget type="Widget" skin="MW_Box" position="226 136 316 209">
-            <Widget type="ScrollView" skin="MW_ScrollViewH" position="4 4 308 161" name="UsedEffects">
+            <Widget type="ScrollView" skin="MW_ScrollViewH" position="4 4 308 201" name="UsedEffects">
                 <Property key="CanvasAlign" value="Left Top"/>
             </Widget>
         </Widget>