mirror/openmw
1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-01-21 07:53:53 +00:00
Code Issues Releases Wiki Activity

Use prefix increment for iterators in esmstore.cpp

Browse source 
See https://pvs-studio.com/en/docs/warnings/v803/
for the rationale.
This commit is contained in:
jvoisin 2021-07-22 22:03:59 +02:00
parent 469cc44ef7
commit 73c20be29a
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apps/openmw/mwworld/esmstore.cpp
View file

@ -274,9 +274,9 @@ void ESMStore::countRecords()
std::vector<Ref> refs; std::vector<Ref> refs;
std::vector<std::string> refIDs; std::vector<std::string> refIDs;
std::vector<ESM::ESMReader> readers; std::vector<ESM::ESMReader> readers;
for(auto it = mCells.intBegin(); it != mCells.intEnd(); it++) for(auto it = mCells.intBegin(); it != mCells.intEnd(); ++it)
readRefs(*it, refs, refIDs, readers); readRefs(*it, refs, refIDs, readers);
for(auto it = mCells.extBegin(); it != mCells.extEnd(); it++) for(auto it = mCells.extBegin(); it != mCells.extEnd(); ++it)
readRefs(*it, refs, refIDs, readers); readRefs(*it, refs, refIDs, readers);
const auto lessByRefNum = [] (const Ref& l, const Ref& r) { return l.mRefNum < r.mRefNum; }; const auto lessByRefNum = [] (const Ref& l, const Ref& r) { return l.mRefNum < r.mRefNum; };
std::stable_sort(refs.begin(), refs.end(), lessByRefNum); std::stable_sort(refs.begin(), refs.end(), lessByRefNum);