From 7501597813b45f7998a31ed7af35754b91dd0577 Mon Sep 17 00:00:00 2001
From: elsid <elsid.mail@gmail.com>
Date: Wed, 6 Jul 2022 12:55:36 +0200
Subject: [PATCH] Do not use float as loop variable

apps/opencs/view/render/instanceselectionmode.cpp:294:9: warning: Variable 'i' with floating point type 'float' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter]
        for (float i = 0.0; i <= resolution; i += 2)
        ^                   ~                ~
---
 apps/opencs/view/render/instanceselectionmode.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/apps/opencs/view/render/instanceselectionmode.cpp b/apps/opencs/view/render/instanceselectionmode.cpp
index 9b5fb759cc..545d35d93b 100644
--- a/apps/opencs/view/render/instanceselectionmode.cpp
+++ b/apps/opencs/view/render/instanceselectionmode.cpp
@@ -284,14 +284,14 @@ namespace CSVRender
         osg::ref_ptr<osg::Geometry> geometry (new osg::Geometry);
 
         osg::Vec3Array *vertices = new osg::Vec3Array;
-        int resolution = 32;
+        constexpr int resolution = 32;
         float radiusPerResolution = radius / resolution;
         float reciprocalResolution = 1.0f / resolution;
         float doubleReciprocalRes = reciprocalResolution * 2;
 
         osg::Vec4Array *colours = new osg::Vec4Array;
 
-        for (float i = 0.0; i <= resolution; i += 2)
+        for (int i = 0; i <= resolution; i += 2)
         {
             float iShifted = (static_cast<float>(i) - resolution / 2.0f); // i - 16 = -16 ... 16
             float xPercentile = iShifted * doubleReciprocalRes;