From dd01c4d2240acc21a220f1fd60ac6e6081b1cb05 Mon Sep 17 00:00:00 2001 From: Sophie Kirschner Date: Sat, 25 Aug 2018 11:53:43 +0300 Subject: [PATCH 1/3] Fix: 'sizeof' to an incomplete type 'Video::VideoPlayer' Alternate solution to same problem reported in https://github.com/OpenMW/openmw/pull/1888 --- apps/openmw/mwgui/videowidget.cpp | 2 ++ apps/openmw/mwgui/videowidget.hpp | 2 ++ 2 files changed, 4 insertions(+) diff --git a/apps/openmw/mwgui/videowidget.cpp b/apps/openmw/mwgui/videowidget.cpp index 516f5cfcc6..28432b811d 100644 --- a/apps/openmw/mwgui/videowidget.cpp +++ b/apps/openmw/mwgui/videowidget.cpp @@ -22,6 +22,8 @@ VideoWidget::VideoWidget() setNeedKeyFocus(true); } +VideoWidget::~VideoWidget() = default; + void VideoWidget::setVFS(const VFS::Manager *vfs) { mVFS = vfs; diff --git a/apps/openmw/mwgui/videowidget.hpp b/apps/openmw/mwgui/videowidget.hpp index ac240e69d5..20af579a25 100644 --- a/apps/openmw/mwgui/videowidget.hpp +++ b/apps/openmw/mwgui/videowidget.hpp @@ -25,6 +25,8 @@ namespace MWGui MYGUI_RTTI_DERIVED(VideoWidget) VideoWidget(); + + ~VideoWidget(); /// Set the VFS (virtual file system) to find the videos on. void setVFS(const VFS::Manager* vfs); From dc68b2ff2681e64d9e4ae61289562b7e1f88065d Mon Sep 17 00:00:00 2001 From: Sophie Kirschner Date: Sun, 26 Aug 2018 11:10:25 +0300 Subject: [PATCH 2/3] Add Sophie Kirschner (me) to AUTHORS.md --- AUTHORS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.md b/AUTHORS.md index 3422f28a92..5320a24625 100644 --- a/AUTHORS.md +++ b/AUTHORS.md @@ -153,6 +153,7 @@ Programmers Siimacore sir_herrbatka smbas + Sophie Kirschner (pineapplemachine) spycrab Stefan Galowicz (bogglez) Stanislav Bobrov (Jiub) From 9e253f6a46263f92e8a5939459d66a2d541b4e4c Mon Sep 17 00:00:00 2001 From: Sophie Kirschner Date: Sun, 26 Aug 2018 12:02:49 +0300 Subject: [PATCH 3/3] Add issue #4613 to changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d6d8df78eb..a8a0721051 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -123,6 +123,7 @@ Feature #4581: Use proper logging system Task #2490: Don't open command prompt window on Release-mode builds automatically Task #4545: Enable is_pod string test + Task #4613: Incomplete type errors when compiling with g++ on OSX 10.9 0.44.0 ------