Set Deleted flag to false when initializing ESM records

components/esm/loadacti.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Activator::sRecordId = REC_ACTI;
 
+    Activator::Activator()
+        : mIsDeleted(false)
+    {}
+
     void Activator::load(ESMReader &esm)
     {
         mId = esm.getHNString("NAME");

components/esm/loadacti.hpp

@@ -19,6 +19,8 @@ struct Activator
 
     bool mIsDeleted;
 
+    Activator();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadalch.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Potion::sRecordId = REC_ALCH;
 
+    Potion::Potion()
+        : mIsDeleted(false)
+    {}
+
     void Potion::load(ESMReader &esm)
     {
         mEffects.mList.clear();

components/esm/loadalch.hpp

@@ -35,6 +35,8 @@ struct Potion
 
     bool mIsDeleted;
 
+    Potion();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadappa.cpp

@@ -9,60 +9,64 @@ namespace ESM
 {
     unsigned int Apparatus::sRecordId = REC_APPA;
 
-void Apparatus::load(ESMReader &esm)
+    Apparatus::Apparatus()
-{
+        : mIsDeleted(false)
-    mId = esm.getHNString("NAME");
+    {}
-    if (mIsDeleted = readDeleSubRecord(esm))
-    {
-        return;
-    }
 
-    bool hasData = false;
+    void Apparatus::load(ESMReader &esm)
-    while (esm.hasMoreSubs())
     {
-        esm.getSubName();
+        mId = esm.getHNString("NAME");
-        uint32_t name = esm.retSubName().val;
+        if (mIsDeleted = readDeleSubRecord(esm))
-        switch (name)
         {
-            case ESM::FourCC<'M','O','D','L'>::value:
+            return;
-                mModel = esm.getHString();
-                break;
-            case ESM::FourCC<'F','N','A','M'>::value:
-                mName = esm.getHString();
-                break;
-            case ESM::FourCC<'A','A','D','T'>::value:
-                esm.getHT(mData);
-                hasData = true;
-                break;
-            case ESM::FourCC<'S','C','R','I'>::value:
-                mScript = esm.getHString();
-                break;
-            case ESM::FourCC<'I','T','E','X'>::value:
-                mIcon = esm.getHString();
-                break;
-            default:
-                esm.fail("Unknown subrecord");
         }
-    }
-    if (!hasData)
-        esm.fail("Missing AADT");
-}
 
-void Apparatus::save(ESMWriter &esm) const
+        bool hasData = false;
-{
+        while (esm.hasMoreSubs())
-    esm.writeHNCString("NAME", mId);
+        {
-    if (mIsDeleted)
+            esm.getSubName();
+            uint32_t name = esm.retSubName().val;
+            switch (name)
+            {
+                case ESM::FourCC<'M','O','D','L'>::value:
+                    mModel = esm.getHString();
+                    break;
+                case ESM::FourCC<'F','N','A','M'>::value:
+                    mName = esm.getHString();
+                    break;
+                case ESM::FourCC<'A','A','D','T'>::value:
+                    esm.getHT(mData);
+                    hasData = true;
+                    break;
+                case ESM::FourCC<'S','C','R','I'>::value:
+                    mScript = esm.getHString();
+                    break;
+                case ESM::FourCC<'I','T','E','X'>::value:
+                    mIcon = esm.getHString();
+                    break;
+                default:
+                    esm.fail("Unknown subrecord");
+            }
+        }
+        if (!hasData)
+            esm.fail("Missing AADT");
+    }
+
+    void Apparatus::save(ESMWriter &esm) const
     {
-        writeDeleSubRecord(esm);
+        esm.writeHNCString("NAME", mId);
-        return;
+        if (mIsDeleted)
-    }
+        {
+            writeDeleSubRecord(esm);
+            return;
+        }
 
-    esm.writeHNCString("MODL", mModel);
+        esm.writeHNCString("MODL", mModel);
-    esm.writeHNCString("FNAM", mName);
+        esm.writeHNCString("FNAM", mName);
-    esm.writeHNT("AADT", mData, 16);
+        esm.writeHNT("AADT", mData, 16);
-    esm.writeHNOCString("SCRI", mScript);
+        esm.writeHNOCString("SCRI", mScript);
-    esm.writeHNCString("ITEX", mIcon);
+        esm.writeHNCString("ITEX", mIcon);
-}
+    }
 
     void Apparatus::blank()
     {

components/esm/loadappa.hpp

@@ -40,6 +40,8 @@ struct Apparatus
 
     bool mIsDeleted;
 
+    Apparatus();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadarmo.cpp

@@ -39,6 +39,10 @@ namespace ESM
 
     unsigned int Armor::sRecordId = REC_ARMO;
 
+    Armor::Armor()
+        : mIsDeleted(false)
+    {}
+
     void Armor::load(ESMReader &esm)
     {
         mParts.mParts.clear();

components/esm/loadarmo.hpp

@@ -98,6 +98,8 @@ struct Armor
 
     bool mIsDeleted;
 
+    Armor();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadbody.cpp

@@ -9,53 +9,57 @@ namespace ESM
 {
     unsigned int BodyPart::sRecordId = REC_BODY;
 
+    BodyPart::BodyPart()
+        : mIsDeleted(false)
+    {}
 
-void BodyPart::load(ESMReader &esm)
+    void BodyPart::load(ESMReader &esm)
-{
-    mId = esm.getHNString("NAME");
-    if (mIsDeleted = readDeleSubRecord(esm))
     {
-        return;
+        mId = esm.getHNString("NAME");
-    }
+        if (mIsDeleted = readDeleSubRecord(esm))
-
-    bool hasData = false;
-    while (esm.hasMoreSubs())
-    {
-        esm.getSubName();
-        uint32_t name = esm.retSubName().val;
-        switch (name)
         {
-            case ESM::FourCC<'M','O','D','L'>::value:
+            return;
-                mModel = esm.getHString();
-                break;
-            case ESM::FourCC<'F','N','A','M'>::value:
-                mRace = esm.getHString();
-                break;
-            case ESM::FourCC<'B','Y','D','T'>::value:
-                esm.getHT(mData, 4);
-                hasData = true;
-                break;
-            default:
-                esm.fail("Unknown subrecord");
         }
+
+        bool hasData = false;
+        while (esm.hasMoreSubs())
+        {
+            esm.getSubName();
+            uint32_t name = esm.retSubName().val;
+            switch (name)
+            {
+                case ESM::FourCC<'M','O','D','L'>::value:
+                    mModel = esm.getHString();
+                    break;
+                case ESM::FourCC<'F','N','A','M'>::value:
+                    mRace = esm.getHString();
+                    break;
+                case ESM::FourCC<'B','Y','D','T'>::value:
+                    esm.getHT(mData, 4);
+                    hasData = true;
+                    break;
+                default:
+                    esm.fail("Unknown subrecord");
+            }
+        }
+
+        if (!hasData)
+            esm.fail("Missing BYDT subrecord");
     }
 
-    if (!hasData)
+    void BodyPart::save(ESMWriter &esm) const
-        esm.fail("Missing BYDT subrecord");
-}
-void BodyPart::save(ESMWriter &esm) const
-{
-    esm.writeHNCString("NAME", mId);
-    if (mIsDeleted)
     {
-        writeDeleSubRecord(esm);
+        esm.writeHNCString("NAME", mId);
-        return;
+        if (mIsDeleted)
-    }
+        {
+            writeDeleSubRecord(esm);
+            return;
+        }
 
-    esm.writeHNCString("MODL", mModel);
+        esm.writeHNCString("MODL", mModel);
-    esm.writeHNOCString("FNAM", mRace);
+        esm.writeHNOCString("FNAM", mRace);
-    esm.writeHNT("BYDT", mData, 4);
+        esm.writeHNT("BYDT", mData, 4);
-}
+    }
 
     void BodyPart::blank()
     {

components/esm/loadbody.hpp

@@ -62,6 +62,8 @@ struct BodyPart
 
     bool mIsDeleted;
 
+    BodyPart();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadbook.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Book::sRecordId = REC_BOOK;
 
+    Book::Book()
+        : mIsDeleted(false)
+    {}
+
     void Book::load(ESMReader &esm)
     {
         mId = esm.getHNString("NAME");

components/esm/loadbook.hpp

@@ -30,6 +30,8 @@ struct Book
 
     bool mIsDeleted;
 
+    Book();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadbsgn.cpp

@@ -9,50 +9,54 @@ namespace ESM
 {
     unsigned int BirthSign::sRecordId = REC_BSGN;
 
-void BirthSign::load(ESMReader &esm)
+    BirthSign::BirthSign()
-{
+        : mIsDeleted(false)
-    mPowers.mList.clear();
+    {}
 
-    mIsDeleted = readDeleSubRecord(esm);
+    void BirthSign::load(ESMReader &esm)
-    mId = esm.getHNString("NAME");
-
-    while (esm.hasMoreSubs())
     {
-        esm.getSubName();
+        mPowers.mList.clear();
-        uint32_t name = esm.retSubName().val;
+
-        switch (name)
+        mIsDeleted = readDeleSubRecord(esm);
+        mId = esm.getHNString("NAME");
+
+        while (esm.hasMoreSubs())
         {
-            case ESM::FourCC<'F','N','A','M'>::value:
+            esm.getSubName();
-                mName = esm.getHString();
+            uint32_t name = esm.retSubName().val;
-                break;
+            switch (name)
-            case ESM::FourCC<'T','N','A','M'>::value:
+            {
-                mTexture = esm.getHString();
+                case ESM::FourCC<'F','N','A','M'>::value:
-                break;
+                    mName = esm.getHString();
-            case ESM::FourCC<'D','E','S','C'>::value:
+                    break;
-                mDescription = esm.getHString();
+                case ESM::FourCC<'T','N','A','M'>::value:
-                break;
+                    mTexture = esm.getHString();
-            case ESM::FourCC<'N','P','C','S'>::value:
+                    break;
-                mPowers.add(esm);
+                case ESM::FourCC<'D','E','S','C'>::value:
-                break;
+                    mDescription = esm.getHString();
-            default:
+                    break;
-                esm.fail("Unknown subrecord");
+                case ESM::FourCC<'N','P','C','S'>::value:
+                    mPowers.add(esm);
+                    break;
+                default:
+                    esm.fail("Unknown subrecord");
+            }
         }
     }
-}
 
-void BirthSign::save(ESMWriter &esm) const
+    void BirthSign::save(ESMWriter &esm) const
-{
-    if (mIsDeleted)
     {
-        writeDeleSubRecord(esm);
+        if (mIsDeleted)
-    }
+        {
-    esm.writeHNCString("NAME", mId);
+            writeDeleSubRecord(esm);
-    esm.writeHNOCString("FNAM", mName);
+        }
-    esm.writeHNOCString("TNAM", mTexture);
+        esm.writeHNCString("NAME", mId);
-    esm.writeHNOCString("DESC", mDescription);
+        esm.writeHNOCString("FNAM", mName);
+        esm.writeHNOCString("TNAM", mTexture);
+        esm.writeHNOCString("DESC", mDescription);
 
-    mPowers.save(esm);
+        mPowers.save(esm);
-}
+    }
 
     void BirthSign::blank()
     {

components/esm/loadbsgn.hpp

@@ -24,6 +24,8 @@ struct BirthSign
 
     bool mIsDeleted;
 
+    BirthSign();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadcell.hpp

@@ -85,7 +85,8 @@ struct Cell
            mWater(0),
            mWaterInt(false),
            mMapColor(0),
-           mRefNumCounter(0)
+           mRefNumCounter(0),
+           mIsDeleted(false)
   {}
 
   // Interior cells are indexed by this (it's the 'id'), for exterior

components/esm/loadclas.cpp

@@ -23,6 +23,9 @@ namespace ESM
       "sSpecializationStealth"
     };
 
+    Class::Class()
+        : mIsDeleted(false)
+    {}
 
     int& Class::CLDTstruct::getSkill (int index, bool major)
     {

components/esm/loadclas.hpp

@@ -75,6 +75,8 @@ struct Class
 
     bool mIsDeleted;
 
+    Class();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadclot.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Clothing::sRecordId = REC_CLOT;
 
+    Clothing::Clothing()
+        : mIsDeleted(false)
+    {}
+
     void Clothing::load(ESMReader &esm)
     {
         mParts.mParts.clear();

components/esm/loadclot.hpp

@@ -50,6 +50,8 @@ struct Clothing
 
     bool mIsDeleted;
 
+    Clothing();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadcont.cpp

@@ -25,6 +25,10 @@ namespace ESM
 
     unsigned int Container::sRecordId = REC_CONT;
 
+    Container::Container()
+        : mIsDeleted(false)
+    {}
+
     void Container::load(ESMReader &esm)
     {
         mInventory.mList.clear();

components/esm/loadcont.hpp

@@ -54,6 +54,8 @@ struct Container
 
     bool mIsDeleted;
 
+    Container();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadcrea.cpp

@@ -9,6 +9,10 @@ namespace ESM {
 
     unsigned int Creature::sRecordId = REC_CREA;
 
+    Creature::Creature()
+        : mIsDeleted(false)
+    {}
+
     void Creature::load(ESMReader &esm)
     {
         mPersistent = (esm.getRecordFlags() & 0x0400) != 0;

components/esm/loadcrea.hpp

@@ -98,6 +98,8 @@ struct Creature
 
     bool mIsDeleted;
 
+    Creature();
+
     const std::vector<Transport::Dest>& getTransport() const;
 
     void load(ESMReader &esm);

components/esm/loaddial.cpp

@@ -13,125 +13,128 @@ namespace ESM
 {
     unsigned int Dialogue::sRecordId = REC_DIAL;
 
-void Dialogue::load(ESMReader &esm)
+    Dialogue::Dialogue()
-{
+        : mIsDeleted(false)
-    mIsDeleted = false;
+    {}
 
-    mId = esm.getHNString("NAME");
+    void Dialogue::load(ESMReader &esm)
-    esm.getSubNameIs("DATA");
-    esm.getSubHeader();
-    int si = esm.getSubSize();
-    if (si == 1)
-        esm.getT(mType);
-    else if (si == 4) // The dialogue is deleted
     {
-        int32_t empty;
+        mIsDeleted = false;
-        esm.getT(empty); // Skip an empty DATA
-        mIsDeleted = readDeleSubRecord(esm);
-    }
-    else
-        esm.fail("Unknown sub record size");
-}
 
-void Dialogue::save(ESMWriter &esm) const
+        mId = esm.getHNString("NAME");
-{
+        esm.getSubNameIs("DATA");
-    esm.writeHNCString("NAME", mId);
+        esm.getSubHeader();
-    if (mIsDeleted)
+        int si = esm.getSubSize();
-    {
+        if (si == 1)
-        esm.writeHNT("DATA", static_cast<int32_t>(0));
+            esm.getT(mType);
-        writeDeleSubRecord(esm);
+        else if (si == 4) // The dialogue is deleted
-    }
+        {
-    else
+            int32_t empty;
-    {
+            esm.getT(empty); // Skip an empty DATA
-        esm.writeHNT("DATA", mType);
+            mIsDeleted = readDeleSubRecord(esm);
-    }
+        }
-}
-
-void Dialogue::blank()
-{
-    mInfo.clear();
-}
-
-void Dialogue::readInfo(ESMReader &esm, bool merge)
-{
-    const std::string& id = esm.getHNOString("INAM");
-
-    if (!merge || mInfo.empty())
-    {
-        ESM::DialInfo info;
-        info.mId = id;
-        info.load(esm);
-        mLookup[id] = mInfo.insert(mInfo.end(), info);
-        return;
-    }
-
-    ESM::Dialogue::InfoContainer::iterator it = mInfo.end();
-
-    std::map<std::string, ESM::Dialogue::InfoContainer::iterator>::iterator lookup;
-
-    lookup = mLookup.find(id);
-
-    ESM::DialInfo info;
-    if (lookup != mLookup.end())
-    {
-        it = lookup->second;
-
-        // Merge with existing record. Only the subrecords that are present in
-        // the new record will be overwritten.
-        it->load(esm);
-        info = *it;
-
-        // Since the record merging may have changed the next/prev linked list connection, we need to re-insert the record
-        mInfo.erase(it);
-        mLookup.erase(lookup);
-    }
-    else
-    {
-        info.mId = id;
-        info.load(esm);
-    }
-
-    if (info.mNext.empty())
-    {
-        mLookup[id] = mInfo.insert(mInfo.end(), info);
-        return;
-    }
-    if (info.mPrev.empty())
-    {
-        mLookup[id] = mInfo.insert(mInfo.begin(), info);
-        return;
-    }
-
-    lookup = mLookup.find(info.mPrev);
-    if (lookup != mLookup.end())
-    {
-        it = lookup->second;
-
-        mLookup[id] = mInfo.insert(++it, info);
-        return;
-    }
-
-    lookup = mLookup.find(info.mNext);
-    if (lookup != mLookup.end())
-    {
-        it = lookup->second;
-
-        mLookup[id] = mInfo.insert(it, info);
-        return;
-    }
-
-    std::cerr << "Failed to insert info " << id << std::endl;
-}
-
-void Dialogue::clearDeletedInfos()
-{
-    for (InfoContainer::iterator it = mInfo.begin(); it != mInfo.end(); )
-    {
-        if (it->mQuestStatus == DialInfo::QS_Deleted)
-            it = mInfo.erase(it);
         else
-            ++it;
+            esm.fail("Unknown sub record size");
+    }
+
+    void Dialogue::save(ESMWriter &esm) const
+    {
+        esm.writeHNCString("NAME", mId);
+        if (mIsDeleted)
+        {
+            esm.writeHNT("DATA", static_cast<int32_t>(0));
+            writeDeleSubRecord(esm);
+        }
+        else
+        {
+            esm.writeHNT("DATA", mType);
+        }
+    }
+
+    void Dialogue::blank()
+    {
+        mInfo.clear();
+    }
+
+    void Dialogue::readInfo(ESMReader &esm, bool merge)
+    {
+        const std::string& id = esm.getHNOString("INAM");
+
+        if (!merge || mInfo.empty())
+        {
+            ESM::DialInfo info;
+            info.mId = id;
+            info.load(esm);
+            mLookup[id] = mInfo.insert(mInfo.end(), info);
+            return;
+        }
+
+        ESM::Dialogue::InfoContainer::iterator it = mInfo.end();
+
+        std::map<std::string, ESM::Dialogue::InfoContainer::iterator>::iterator lookup;
+
+        lookup = mLookup.find(id);
+
+        ESM::DialInfo info;
+        if (lookup != mLookup.end())
+        {
+            it = lookup->second;
+
+            // Merge with existing record. Only the subrecords that are present in
+            // the new record will be overwritten.
+            it->load(esm);
+            info = *it;
+
+            // Since the record merging may have changed the next/prev linked list connection, we need to re-insert the record
+            mInfo.erase(it);
+            mLookup.erase(lookup);
+        }
+        else
+        {
+            info.mId = id;
+            info.load(esm);
+        }
+
+        if (info.mNext.empty())
+        {
+            mLookup[id] = mInfo.insert(mInfo.end(), info);
+            return;
+        }
+        if (info.mPrev.empty())
+        {
+            mLookup[id] = mInfo.insert(mInfo.begin(), info);
+            return;
+        }
+
+        lookup = mLookup.find(info.mPrev);
+        if (lookup != mLookup.end())
+        {
+            it = lookup->second;
+
+            mLookup[id] = mInfo.insert(++it, info);
+            return;
+        }
+
+        lookup = mLookup.find(info.mNext);
+        if (lookup != mLookup.end())
+        {
+            it = lookup->second;
+
+            mLookup[id] = mInfo.insert(it, info);
+            return;
+        }
+
+        std::cerr << "Failed to insert info " << id << std::endl;
+    }
+
+    void Dialogue::clearDeletedInfos()
+    {
+        for (InfoContainer::iterator it = mInfo.begin(); it != mInfo.end(); )
+        {
+            if (it->mQuestStatus == DialInfo::QS_Deleted)
+                it = mInfo.erase(it);
+            else
+                ++it;
+        }
     }
 }
-
-}

components/esm/loaddial.hpp

@@ -47,6 +47,8 @@ struct Dialogue
 
     bool mIsDeleted;
 
+    Dialogue();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loaddoor.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Door::sRecordId = REC_DOOR;
 
+    Door::Door()
+        : mIsDeleted(false)
+    {}
+
     void Door::load(ESMReader &esm)
     {
         mId = esm.getHNString("NAME");

components/esm/loaddoor.hpp

@@ -19,6 +19,8 @@ struct Door
 
     bool mIsDeleted;
 
+    Door();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadench.cpp

@@ -9,51 +9,55 @@ namespace ESM
 {
     unsigned int Enchantment::sRecordId = REC_ENCH;
 
-void Enchantment::load(ESMReader &esm)
+    Enchantment::Enchantment()
-{
+        : mIsDeleted(false)
-    mEffects.mList.clear();
+    {}
 
-    mId = esm.getHNString("NAME");
+    void Enchantment::load(ESMReader &esm)
-    if (mIsDeleted = readDeleSubRecord(esm))
     {
-        return;
+        mEffects.mList.clear();
-    }
 
-    bool hasData = false;
+        mId = esm.getHNString("NAME");
-    while (esm.hasMoreSubs())
+        if (mIsDeleted = readDeleSubRecord(esm))
-    {
-        esm.getSubName();
-        uint32_t name = esm.retSubName().val;
-        switch (name)
         {
-            case ESM::FourCC<'E','N','D','T'>::value:
+            return;
-                esm.getHT(mData, 16);
-                hasData = true;
-                break;
-            case ESM::FourCC<'E','N','A','M'>::value:
-                mEffects.add(esm);
-                break;
-            default:
-                esm.fail("Unknown subrecord");
-                break;
         }
-    }
-    if (!hasData)
-        esm.fail("Missing ENDT subrecord");
-}
 
-void Enchantment::save(ESMWriter &esm) const
+        bool hasData = false;
-{
+        while (esm.hasMoreSubs())
-    esm.writeHNCString("NAME", mId);
+        {
-    if (mIsDeleted)
+            esm.getSubName();
+            uint32_t name = esm.retSubName().val;
+            switch (name)
+            {
+                case ESM::FourCC<'E','N','D','T'>::value:
+                    esm.getHT(mData, 16);
+                    hasData = true;
+                    break;
+                case ESM::FourCC<'E','N','A','M'>::value:
+                    mEffects.add(esm);
+                    break;
+                default:
+                    esm.fail("Unknown subrecord");
+                    break;
+            }
+        }
+        if (!hasData)
+            esm.fail("Missing ENDT subrecord");
+    }
+
+    void Enchantment::save(ESMWriter &esm) const
     {
-        writeDeleSubRecord(esm);
+        esm.writeHNCString("NAME", mId);
-        return;
+        if (mIsDeleted)
-    }
+        {
+            writeDeleSubRecord(esm);
+            return;
+        }
 
-    esm.writeHNT("ENDT", mData, 16);
+        esm.writeHNT("ENDT", mData, 16);
-    mEffects.save(esm);
+        mEffects.save(esm);
-}
+    }
 
     void Enchantment::blank()
     {

components/esm/loadench.hpp

@@ -44,6 +44,8 @@ struct Enchantment
 
     bool mIsDeleted;
 
+    Enchantment();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadfact.cpp

@@ -11,6 +11,10 @@ namespace ESM
 {
     unsigned int Faction::sRecordId = REC_FACT;
 
+    Faction::Faction()
+        : mIsDeleted(false)
+    {}
+
     int& Faction::FADTstruct::getSkill (int index, bool ignored)
     {
         if (index<0 || index>=7)
@@ -27,82 +31,83 @@ namespace ESM
         return mSkills[index];
     }
 
-void Faction::load(ESMReader &esm)
+    void Faction::load(ESMReader &esm)
-{
-    mReactions.clear();
-    for (int i=0;i<10;++i)
-        mRanks[i].clear();
-
-    mId = esm.getHNString("NAME");
-    if (mIsDeleted = readDeleSubRecord(esm))
     {
-        return;
+        mReactions.clear();
+        for (int i=0;i<10;++i)
+            mRanks[i].clear();
+
+        mId = esm.getHNString("NAME");
+        if (mIsDeleted = readDeleSubRecord(esm))
+        {
+            return;
+        }
+
+        int rankCounter=0;
+        bool hasData = false;
+        while (esm.hasMoreSubs())
+        {
+            esm.getSubName();
+            uint32_t name = esm.retSubName().val;
+            switch (name)
+            {
+                case ESM::FourCC<'F','N','A','M'>::value:
+                    mName = esm.getHString();
+                    break;
+                case ESM::FourCC<'R','N','A','M'>::value:
+                    if (rankCounter >= 10)
+                        esm.fail("Rank out of range");
+                    mRanks[rankCounter++] = esm.getHString();
+                    break;
+                case ESM::FourCC<'F','A','D','T'>::value:
+                    esm.getHT(mData, 240);
+                    if (mData.mIsHidden > 1)
+                        esm.fail("Unknown flag!");
+                    hasData = true;
+                    break;
+                case ESM::FourCC<'A','N','A','M'>::value:
+                {
+                    std::string faction = esm.getHString();
+                    int reaction;
+                    esm.getHNT(reaction, "INTV");
+                    mReactions[faction] = reaction;
+                    break;
+                }
+                default:
+                    esm.fail("Unknown subrecord");
+            }
+        }
+        if (!hasData)
+            esm.fail("Missing FADT subrecord");
     }
 
-    int rankCounter=0;
+    void Faction::save(ESMWriter &esm) const
-    bool hasData = false;
-    while (esm.hasMoreSubs())
     {
-        esm.getSubName();
+        esm.writeHNCString("NAME", mId);
-        uint32_t name = esm.retSubName().val;
+        if (mIsDeleted)
-        switch (name)
         {
-            case ESM::FourCC<'F','N','A','M'>::value:
+            writeDeleSubRecord(esm);
-                mName = esm.getHString();
+            return;
+        }
+
+        esm.writeHNOCString("FNAM", mName);
+
+        for (int i = 0; i < 10; i++)
+        {
+            if (mRanks[i].empty())
                 break;
-            case ESM::FourCC<'R','N','A','M'>::value:
+
-                if (rankCounter >= 10)
+            esm.writeHNString("RNAM", mRanks[i], 32);
-                    esm.fail("Rank out of range");
+        }
-                mRanks[rankCounter++] = esm.getHString();
+
-                break;
+        esm.writeHNT("FADT", mData, 240);
-            case ESM::FourCC<'F','A','D','T'>::value:
+
-                esm.getHT(mData, 240);
+        for (std::map<std::string, int>::const_iterator it = mReactions.begin(); it != mReactions.end(); ++it)
-                if (mData.mIsHidden > 1)
+        {
-                    esm.fail("Unknown flag!");
+            esm.writeHNString("ANAM", it->first);
-                hasData = true;
+            esm.writeHNT("INTV", it->second);
-                break;
-            case ESM::FourCC<'A','N','A','M'>::value:
-            {
-                std::string faction = esm.getHString();
-                int reaction;
-                esm.getHNT(reaction, "INTV");
-                mReactions[faction] = reaction;
-                break;
-            }
-            default:
-                esm.fail("Unknown subrecord");
         }
     }
-    if (!hasData)
-        esm.fail("Missing FADT subrecord");
-}
-void Faction::save(ESMWriter &esm) const
-{
-    esm.writeHNCString("NAME", mId);
-    if (mIsDeleted)
-    {
-        writeDeleSubRecord(esm);
-        return;
-    }
-
-    esm.writeHNOCString("FNAM", mName);
-
-    for (int i = 0; i < 10; i++)
-    {
-        if (mRanks[i].empty())
-            break;
-
-        esm.writeHNString("RNAM", mRanks[i], 32);
-    }
-
-    esm.writeHNT("FADT", mData, 240);
-
-    for (std::map<std::string, int>::const_iterator it = mReactions.begin(); it != mReactions.end(); ++it)
-    {
-        esm.writeHNString("ANAM", it->first);
-        esm.writeHNT("INTV", it->second);
-    }
-}
 
     void Faction::blank()
     {

components/esm/loadfact.hpp

@@ -64,6 +64,8 @@ struct Faction
 
     bool mIsDeleted;
 
+    Faction();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadglob.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Global::sRecordId = REC_GLOB;
 
+    Global::Global()
+        : mIsDeleted(false)
+    {}
+
     void Global::load (ESMReader &esm)
     {
         mId = esm.getHNString("NAME");

components/esm/loadglob.hpp

@@ -26,6 +26,8 @@ struct Global
 
     bool mIsDeleted;
 
+    Global();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadinfo.cpp

@@ -9,170 +9,174 @@ namespace ESM
 {
     unsigned int DialInfo::sRecordId = REC_INFO;
 
-void DialInfo::load(ESMReader &esm)
+    DialInfo::DialInfo()
-{
+        : mIsDeleted(false)
-    mQuestStatus = QS_None;
+    {}
-    mFactionLess = false;
 
-    mPrev = esm.getHNString("PNAM");
+    void DialInfo::load(ESMReader &esm)
-    mNext = esm.getHNString("NNAM");
-
-    // Since there's no way to mark selects as "deleted", we have to clear the SelectStructs from all previous loadings
-    mSelects.clear();
-
-    // If the info is deleted, NAME and DELE sub-records are followed after NNAM
-    if (esm.isNextSub("NAME"))
     {
-        mResponse = esm.getHString();
+        mQuestStatus = QS_None;
-        mIsDeleted = readDeleSubRecord(esm);
+        mFactionLess = false;
-        return;
-    }
 
-    esm.getSubNameIs("DATA");
+        mPrev = esm.getHNString("PNAM");
-    esm.getHT(mData, 12);
+        mNext = esm.getHNString("NNAM");
 
-    if (!esm.hasMoreSubs())
+        // Since there's no way to mark selects as "deleted", we have to clear the SelectStructs from all previous loadings
-        return;
+        mSelects.clear();
 
-    // What follows is somewhat spaghetti-ish, but it's worth if for
+        // If the info is deleted, NAME and DELE sub-records are followed after NNAM
-    // an extra speedup. INFO is by far the most common record type.
+        if (esm.isNextSub("NAME"))
-
+        {
-    // subName is a reference to the original, so it changes whenever
+            mResponse = esm.getHString();
-    // a new sub name is read. esm.isEmptyOrGetName() will get the
+            mIsDeleted = readDeleSubRecord(esm);
-    // next name for us, or return true if there are no more records.
-    esm.getSubName();
-    const NAME &subName = esm.retSubName();
-
-    if (subName.val == REC_ONAM)
-    {
-        mActor = esm.getHString();
-        if (esm.isEmptyOrGetName())
             return;
-    }
+        }
-    if (subName.val == REC_RNAM)
+
-    {
+        esm.getSubNameIs("DATA");
-        mRace = esm.getHString();
+        esm.getHT(mData, 12);
-        if (esm.isEmptyOrGetName())
+
+        if (!esm.hasMoreSubs())
             return;
+
+        // What follows is somewhat spaghetti-ish, but it's worth if for
+        // an extra speedup. INFO is by far the most common record type.
+
+        // subName is a reference to the original, so it changes whenever
+        // a new sub name is read. esm.isEmptyOrGetName() will get the
+        // next name for us, or return true if there are no more records.
+        esm.getSubName();
+        const NAME &subName = esm.retSubName();
+
+        if (subName.val == REC_ONAM)
+        {
+            mActor = esm.getHString();
+            if (esm.isEmptyOrGetName())
+                return;
+        }
+        if (subName.val == REC_RNAM)
+        {
+            mRace = esm.getHString();
+            if (esm.isEmptyOrGetName())
+                return;
+        }
+        if (subName.val == REC_CNAM)
+        {
+            mClass = esm.getHString();
+            if (esm.isEmptyOrGetName())
+                return;
+        }
+
+        if (subName.val == REC_FNAM)
+        {
+            mFaction = esm.getHString();
+            if (mFaction == "FFFF")
+                mFactionLess = true;
+            if (esm.isEmptyOrGetName())
+                return;
+        }
+        if (subName.val == REC_ANAM)
+        {
+            mCell = esm.getHString();
+            if (esm.isEmptyOrGetName())
+                return;
+        }
+        if (subName.val == REC_DNAM)
+        {
+            mPcFaction = esm.getHString();
+            if (esm.isEmptyOrGetName())
+                return;
+        }
+        if (subName.val == REC_SNAM)
+        {
+            mSound = esm.getHString();
+            if (esm.isEmptyOrGetName())
+                return;
+        }
+        if (subName.val == REC_NAME)
+        {
+            mResponse = esm.getHString();
+            if (esm.isEmptyOrGetName())
+                return;
+        }
+
+        while (subName.val == REC_SCVR)
+        {
+            SelectStruct ss;
+
+            ss.mSelectRule = esm.getHString();
+
+            ss.mValue.read (esm, Variant::Format_Info);
+
+            mSelects.push_back(ss);
+
+            if (esm.isEmptyOrGetName())
+                return;
+        }
+
+        if (subName.val == REC_BNAM)
+        {
+            mResultScript = esm.getHString();
+            if (esm.isEmptyOrGetName())
+                return;
+        }
+
+        if (subName.val == REC_QSTN)
+            mQuestStatus = QS_Name;
+        else if (subName.val == REC_QSTF)
+            mQuestStatus = QS_Finished;
+        else if (subName.val == REC_QSTR)
+            mQuestStatus = QS_Restart;
+        else if (subName.val == REC_DELE)
+            mQuestStatus = QS_Deleted;
+        else
+            esm.fail(
+                    "Don't know what to do with " + subName.toString()
+                            + " in INFO " + mId);
+
+        if (mQuestStatus != QS_None)
+            // Skip rest of record
+            esm.skipRecord();
     }
-    if (subName.val == REC_CNAM)
+
+    void DialInfo::save(ESMWriter &esm) const
     {
-        mClass = esm.getHString();
+        esm.writeHNCString("PNAM", mPrev);
-        if (esm.isEmptyOrGetName())
+        esm.writeHNCString("NNAM", mNext);
+        if (mIsDeleted)
+        {
+            esm.writeHNCString("NAME", mResponse);
+            writeDeleSubRecord(esm);
             return;
+        }
+
+        esm.writeHNT("DATA", mData, 12);
+        esm.writeHNOCString("ONAM", mActor);
+        esm.writeHNOCString("RNAM", mRace);
+        esm.writeHNOCString("CNAM", mClass);
+        esm.writeHNOCString("FNAM", mFaction);
+        esm.writeHNOCString("ANAM", mCell);
+        esm.writeHNOCString("DNAM", mPcFaction);
+        esm.writeHNOCString("SNAM", mSound);
+        esm.writeHNOString("NAME", mResponse);
+
+        for (std::vector<SelectStruct>::const_iterator it = mSelects.begin(); it != mSelects.end(); ++it)
+        {
+            esm.writeHNString("SCVR", it->mSelectRule);
+            it->mValue.write (esm, Variant::Format_Info);
+        }
+
+        esm.writeHNOString("BNAM", mResultScript);
+
+        switch(mQuestStatus)
+        {
+        case QS_Name: esm.writeHNT("QSTN",'\1'); break;
+        case QS_Finished: esm.writeHNT("QSTF", '\1'); break;
+        case QS_Restart: esm.writeHNT("QSTR", '\1'); break;
+        case QS_Deleted: esm.writeHNT("DELE", '\1'); break;
+        default: break;
+        }
     }
 
-    if (subName.val == REC_FNAM)
-    {
-        mFaction = esm.getHString();
-        if (mFaction == "FFFF")
-            mFactionLess = true;
-        if (esm.isEmptyOrGetName())
-            return;
-    }
-    if (subName.val == REC_ANAM)
-    {
-        mCell = esm.getHString();
-        if (esm.isEmptyOrGetName())
-            return;
-    }
-    if (subName.val == REC_DNAM)
-    {
-        mPcFaction = esm.getHString();
-        if (esm.isEmptyOrGetName())
-            return;
-    }
-    if (subName.val == REC_SNAM)
-    {
-        mSound = esm.getHString();
-        if (esm.isEmptyOrGetName())
-            return;
-    }
-    if (subName.val == REC_NAME)
-    {
-        mResponse = esm.getHString();
-        if (esm.isEmptyOrGetName())
-            return;
-    }
-
-    while (subName.val == REC_SCVR)
-    {
-        SelectStruct ss;
-
-        ss.mSelectRule = esm.getHString();
-
-        ss.mValue.read (esm, Variant::Format_Info);
-
-        mSelects.push_back(ss);
-
-        if (esm.isEmptyOrGetName())
-            return;
-    }
-
-    if (subName.val == REC_BNAM)
-    {
-        mResultScript = esm.getHString();
-        if (esm.isEmptyOrGetName())
-            return;
-    }
-
-    if (subName.val == REC_QSTN)
-        mQuestStatus = QS_Name;
-    else if (subName.val == REC_QSTF)
-        mQuestStatus = QS_Finished;
-    else if (subName.val == REC_QSTR)
-        mQuestStatus = QS_Restart;
-    else if (subName.val == REC_DELE)
-        mQuestStatus = QS_Deleted;
-    else
-        esm.fail(
-                "Don't know what to do with " + subName.toString()
-                        + " in INFO " + mId);
-
-    if (mQuestStatus != QS_None)
-        // Skip rest of record
-        esm.skipRecord();
-}
-
-void DialInfo::save(ESMWriter &esm) const
-{
-    esm.writeHNCString("PNAM", mPrev);
-    esm.writeHNCString("NNAM", mNext);
-    if (mIsDeleted)
-    {
-        esm.writeHNCString("NAME", mResponse);
-        writeDeleSubRecord(esm);
-        return;
-    }
-
-    esm.writeHNT("DATA", mData, 12);
-    esm.writeHNOCString("ONAM", mActor);
-    esm.writeHNOCString("RNAM", mRace);
-    esm.writeHNOCString("CNAM", mClass);
-    esm.writeHNOCString("FNAM", mFaction);
-    esm.writeHNOCString("ANAM", mCell);
-    esm.writeHNOCString("DNAM", mPcFaction);
-    esm.writeHNOCString("SNAM", mSound);
-    esm.writeHNOString("NAME", mResponse);
-
-    for (std::vector<SelectStruct>::const_iterator it = mSelects.begin(); it != mSelects.end(); ++it)
-    {
-        esm.writeHNString("SCVR", it->mSelectRule);
-        it->mValue.write (esm, Variant::Format_Info);
-    }
-
-    esm.writeHNOString("BNAM", mResultScript);
-
-    switch(mQuestStatus)
-    {
-    case QS_Name: esm.writeHNT("QSTN",'\1'); break;
-    case QS_Finished: esm.writeHNT("QSTF", '\1'); break;
-    case QS_Restart: esm.writeHNT("QSTR", '\1'); break;
-    case QS_Deleted: esm.writeHNT("DELE", '\1'); break;
-    default: break;
-    }
-}
-
     void DialInfo::blank()
     {
         mData.mUnknown1 = 0;

components/esm/loadinfo.hpp

@@ -108,6 +108,8 @@ struct DialInfo
 
     bool mIsDeleted;
 
+    DialInfo();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadingr.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Ingredient::sRecordId = REC_INGR;
 
+    Ingredient::Ingredient()
+        : mIsDeleted(false)
+    {}
+
     void Ingredient::load(ESMReader &esm)
     {
         mId = esm.getHNString("NAME");

components/esm/loadingr.hpp

@@ -33,6 +33,8 @@ struct Ingredient
 
     bool mIsDeleted;
 
+    Ingredient();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadlevlist.cpp

@@ -7,6 +7,9 @@
 
 namespace ESM
 {
+    LevelledListBase::LevelledListBase()
+        : mIsDeleted(false)
+    {}
 
     void LevelledListBase::load(ESMReader &esm)
     {

components/esm/loadlevlist.hpp

@@ -38,6 +38,8 @@ struct LevelledListBase
 
     bool mIsDeleted;
 
+    LevelledListBase();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadligh.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Light::sRecordId = REC_LIGH;
 
+    Light::Light()
+        : mIsDeleted(false)
+    {}
+
     void Light::load(ESMReader &esm)
     {
         mId = esm.getHNString("NAME");

components/esm/loadligh.hpp

@@ -49,6 +49,8 @@ struct Light
 
     bool mIsDeleted;
 
+    Light();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadlock.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Lockpick::sRecordId = REC_LOCK;
 
+    Lockpick::Lockpick()
+        : mIsDeleted(false)
+    {}
+
     void Lockpick::load(ESMReader &esm)
     {
         mId = esm.getHNString("NAME");

components/esm/loadlock.hpp

@@ -29,6 +29,8 @@ struct Lockpick
 
     bool mIsDeleted;
 
+    Lockpick();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadltex.cpp

@@ -9,29 +9,32 @@ namespace ESM
 {
     unsigned int LandTexture::sRecordId = REC_LTEX;
 
-void LandTexture::load(ESMReader &esm)
+    LandTexture::LandTexture()
-{
+        : mIsDeleted(false)
-    mIsDeleted = readDeleSubRecord(esm);
+    {}
-    mId = esm.getHNString("NAME");
+
-    esm.getHNT(mIndex, "INTV");
+    void LandTexture::load(ESMReader &esm)
-    mTexture = esm.getHNString("DATA");
-}
-void LandTexture::save(ESMWriter &esm) const
-{
-    if (mIsDeleted)
     {
-        writeDeleSubRecord(esm);
+        mIsDeleted = readDeleSubRecord(esm);
+        mId = esm.getHNString("NAME");
+        esm.getHNT(mIndex, "INTV");
+        mTexture = esm.getHNString("DATA");
+    }
+    void LandTexture::save(ESMWriter &esm) const
+    {
+        if (mIsDeleted)
+        {
+            writeDeleSubRecord(esm);
+        }
+        esm.writeHNCString("NAME", mId);
+        esm.writeHNT("INTV", mIndex);
+        esm.writeHNCString("DATA", mTexture);
     }
-    esm.writeHNCString("NAME", mId);
-    esm.writeHNT("INTV", mIndex);
-    esm.writeHNCString("DATA", mTexture);
-}
-
-void LandTexture::blank()
-{
-    mTexture.clear();
-    mIndex = -1;
-    mIsDeleted = false;
-}
 
+    void LandTexture::blank()
+    {
+        mTexture.clear();
+        mIndex = -1;
+        mIsDeleted = false;
+    }
 }

components/esm/loadltex.hpp

@@ -36,11 +36,13 @@ struct LandTexture
 
     bool mIsDeleted;
 
-    void blank();
+    LandTexture();
-    ///< Set record to default state (does not touch the ID).
 
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
+
+    void blank();
+    ///< Set record to default state (does not touch the ID).
 };
 }
 #endif

components/esm/loadmisc.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Miscellaneous::sRecordId = REC_MISC;
 
+    Miscellaneous::Miscellaneous()
+        : mIsDeleted(false)
+    {}
+
     void Miscellaneous::load(ESMReader &esm)
     {
         mId = esm.getHNString("NAME");

components/esm/loadmisc.hpp

@@ -34,6 +34,8 @@ struct Miscellaneous
 
     bool mIsDeleted;
 
+    Miscellaneous();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadnpc.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int NPC::sRecordId = REC_NPC_;
 
+    NPC::NPC()
+        : mIsDeleted(false)
+    {}
+
     void NPC::load(ESMReader &esm)
     {
         mPersistent = (esm.getRecordFlags() & 0x0400) != 0;

components/esm/loadnpc.hpp

@@ -132,6 +132,8 @@ struct NPC
 
     bool mIsDeleted;
 
+    NPC();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadprob.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Probe::sRecordId = REC_PROB;
 
+    Probe::Probe()
+        : mIsDeleted(false)
+    {}
+
     void Probe::load(ESMReader &esm)
     {
         mId = esm.getHNString("NAME");

components/esm/loadprob.hpp

@@ -29,6 +29,8 @@ struct Probe
 
     bool mIsDeleted;
 
+    Probe();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadregn.cpp

@@ -9,69 +9,74 @@ namespace ESM
 {
     unsigned int Region::sRecordId = REC_REGN;
 
-void Region::load(ESMReader &esm)
+    Region::Region()
-{
+        : mIsDeleted(false)
-    mIsDeleted = readDeleSubRecord(esm);
+    {}
-    mId = esm.getHNString("NAME");
-    mName = esm.getHNOString("FNAM");
 
-    esm.getSubNameIs("WEAT");
+    void Region::load(ESMReader &esm)
-    esm.getSubHeader();
-    if (esm.getVer() == VER_12)
     {
-        mData.mA = 0;
+        mIsDeleted = readDeleSubRecord(esm);
-        mData.mB = 0;
+        mId = esm.getHNString("NAME");
-        esm.getExact(&mData, sizeof(mData) - 2);
+        mName = esm.getHNOString("FNAM");
-    }
+
-    else if (esm.getVer() == VER_13)
+        esm.getSubNameIs("WEAT");
-    {
+        esm.getSubHeader();
-        // May include the additional two bytes (but not necessarily)
+        if (esm.getVer() == VER_12)
-        if (esm.getSubSize() == sizeof(mData))
-            esm.getExact(&mData, sizeof(mData));
-        else
         {
             mData.mA = 0;
             mData.mB = 0;
-            esm.getExact(&mData, sizeof(mData)-2);
+            esm.getExact(&mData, sizeof(mData) - 2);
+        }
+        else if (esm.getVer() == VER_13)
+        {
+            // May include the additional two bytes (but not necessarily)
+            if (esm.getSubSize() == sizeof(mData))
+                esm.getExact(&mData, sizeof(mData));
+            else
+            {
+                mData.mA = 0;
+                mData.mB = 0;
+                esm.getExact(&mData, sizeof(mData)-2);
+            }
+        }
+        else
+            esm.fail("Don't know what to do in this version");
+
+        mSleepList = esm.getHNOString("BNAM");
+
+        esm.getHNT(mMapColor, "CNAM");
+
+        mSoundList.clear();
+        while (esm.hasMoreSubs())
+        {
+            SoundRef sr;
+            esm.getHNT(sr, "SNAM", 33);
+            mSoundList.push_back(sr);
         }
     }
-    else
-        esm.fail("Don't know what to do in this version");
 
-    mSleepList = esm.getHNOString("BNAM");
+    void Region::save(ESMWriter &esm) const
-
-    esm.getHNT(mMapColor, "CNAM");
-
-    mSoundList.clear();
-    while (esm.hasMoreSubs())
     {
-        SoundRef sr;
+        if (mIsDeleted)
-        esm.getHNT(sr, "SNAM", 33);
+        {
-        mSoundList.push_back(sr);
+            writeDeleSubRecord(esm);
-    }
+        }
-}
+        esm.writeHNString("NAME", mId);
-void Region::save(ESMWriter &esm) const
+        esm.writeHNOCString("FNAM", mName);
-{
-    if (mIsDeleted)
-    {
-        writeDeleSubRecord(esm);
-    }
-    esm.writeHNString("NAME", mId);
-    esm.writeHNOCString("FNAM", mName);
 
-    if (esm.getVersion() == VER_12)
+        if (esm.getVersion() == VER_12)
-        esm.writeHNT("WEAT", mData, sizeof(mData) - 2);
+            esm.writeHNT("WEAT", mData, sizeof(mData) - 2);
-    else
+        else
-        esm.writeHNT("WEAT", mData);
+            esm.writeHNT("WEAT", mData);
 
-    esm.writeHNOCString("BNAM", mSleepList);
+        esm.writeHNOCString("BNAM", mSleepList);
 
-    esm.writeHNT("CNAM", mMapColor);
+        esm.writeHNT("CNAM", mMapColor);
-    for (std::vector<SoundRef>::const_iterator it = mSoundList.begin(); it != mSoundList.end(); ++it)
+        for (std::vector<SoundRef>::const_iterator it = mSoundList.begin(); it != mSoundList.end(); ++it)
-    {
+        {
-        esm.writeHNT<SoundRef>("SNAM", *it);
+            esm.writeHNT<SoundRef>("SNAM", *it);
+        }
     }
-}
 
     void Region::blank()
     {

components/esm/loadregn.hpp

@@ -53,6 +53,8 @@ struct Region
 
     bool mIsDeleted;
 
+    Region();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadrepa.cpp

@@ -9,62 +9,66 @@ namespace ESM
 {
     unsigned int Repair::sRecordId = REC_REPA;
 
-void Repair::load(ESMReader &esm)
+    Repair::Repair()
-{
+        : mIsDeleted(false)
-    mId = esm.getHNString("NAME");
+    {}
-    if (mIsDeleted = readDeleSubRecord(esm))
-    {
-        return;
-    }
 
-    bool hasData = true;
+    void Repair::load(ESMReader &esm)
-    while (esm.hasMoreSubs())
     {
-        esm.getSubName();
+        mId = esm.getHNString("NAME");
-        uint32_t name = esm.retSubName().val;
+        if (mIsDeleted = readDeleSubRecord(esm))
-        switch (name)
         {
-            case ESM::FourCC<'M','O','D','L'>::value:
+            return;
-                mModel = esm.getHString();
-                break;
-            case ESM::FourCC<'F','N','A','M'>::value:
-                mName = esm.getHString();
-                break;
-            case ESM::FourCC<'R','I','D','T'>::value:
-                esm.getHT(mData, 16);
-                hasData = true;
-                break;
-            case ESM::FourCC<'S','C','R','I'>::value:
-                mScript = esm.getHString();
-                break;
-            case ESM::FourCC<'I','T','E','X'>::value:
-                mIcon = esm.getHString();
-                break;
-            default:
-                esm.fail("Unknown subrecord");
         }
-    }
-    if (!hasData)
-        esm.fail("Missing RIDT subrecord");
-}
 
-void Repair::save(ESMWriter &esm) const
+        bool hasData = true;
-{
+        while (esm.hasMoreSubs())
-    esm.writeHNCString("NAME", mId);
+        {
-    if (mIsDeleted)
+            esm.getSubName();
+            uint32_t name = esm.retSubName().val;
+            switch (name)
+            {
+                case ESM::FourCC<'M','O','D','L'>::value:
+                    mModel = esm.getHString();
+                    break;
+                case ESM::FourCC<'F','N','A','M'>::value:
+                    mName = esm.getHString();
+                    break;
+                case ESM::FourCC<'R','I','D','T'>::value:
+                    esm.getHT(mData, 16);
+                    hasData = true;
+                    break;
+                case ESM::FourCC<'S','C','R','I'>::value:
+                    mScript = esm.getHString();
+                    break;
+                case ESM::FourCC<'I','T','E','X'>::value:
+                    mIcon = esm.getHString();
+                    break;
+                default:
+                    esm.fail("Unknown subrecord");
+            }
+        }
+        if (!hasData)
+            esm.fail("Missing RIDT subrecord");
+    }
+
+    void Repair::save(ESMWriter &esm) const
     {
-        writeDeleSubRecord(esm);
+        esm.writeHNCString("NAME", mId);
-        return;
+        if (mIsDeleted)
+        {
+            writeDeleSubRecord(esm);
+            return;
+        }
+
+        esm.writeHNCString("MODL", mModel);
+        esm.writeHNOCString("FNAM", mName);
+
+        esm.writeHNT("RIDT", mData, 16);
+        esm.writeHNOString("SCRI", mScript);
+        esm.writeHNOCString("ITEX", mIcon);
     }
 
-    esm.writeHNCString("MODL", mModel);
-    esm.writeHNOCString("FNAM", mName);
-
-    esm.writeHNT("RIDT", mData, 16);
-    esm.writeHNOString("SCRI", mScript);
-    esm.writeHNOCString("ITEX", mIcon);
-}
-
     void Repair::blank()
     {
         mData.mWeight = 0;

components/esm/loadrepa.hpp

@@ -29,6 +29,8 @@ struct Repair
 
     bool mIsDeleted;
 
+    Repair();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadscpt.cpp

@@ -9,9 +9,12 @@
 
 namespace ESM
 {
-
     unsigned int Script::sRecordId = REC_SCPT;
 
+    Script::Script()
+        : mIsDeleted(false)
+    {}
+
     void Script::loadSCVR(ESMReader &esm)
     {
         int s = mData.mStringTableSize;

components/esm/loadscpt.hpp

@@ -52,6 +52,8 @@ public:
 
     bool mIsDeleted;
 
+    Script();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadsndg.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int SoundGenerator::sRecordId = REC_SNDG;
 
+    SoundGenerator::SoundGenerator()
+        : mIsDeleted(false)
+    {}
+
     void SoundGenerator::load(ESMReader &esm)
     {
         mId = esm.getHNString("NAME");

components/esm/loadsndg.hpp

@@ -38,6 +38,8 @@ struct SoundGenerator
 
     bool mIsDeleted;
 
+    SoundGenerator();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadsoun.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Sound::sRecordId = REC_SOUN;
 
+    Sound::Sound()
+        : mIsDeleted(false)
+    {}
+
     void Sound::load(ESMReader &esm)
     {
         mId = esm.getHNString("NAME");

components/esm/loadsoun.hpp

@@ -25,6 +25,8 @@ struct Sound
 
     bool mIsDeleted;
 
+    Sound();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadspel.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Spell::sRecordId = REC_SPEL;
 
+    Spell::Spell()
+        : mIsDeleted(false)
+    {}
+
     void Spell::load(ESMReader &esm)
     {
         mEffects.mList.clear();

components/esm/loadspel.hpp

@@ -47,6 +47,8 @@ struct Spell
 
     bool mIsDeleted;
 
+    Spell();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;
 

components/esm/loadstat.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Static::sRecordId = REC_STAT;
 
+    Static::Static()
+        : mIsDeleted(false)
+    {}
+
     void Static::load(ESMReader &esm)
     {
         mId = esm.getHNString("NAME");

components/esm/loadstat.hpp

@@ -30,6 +30,8 @@ struct Static
 
   bool mIsDeleted;
 
+  Static();
+
   void load(ESMReader &esm);
   void save(ESMWriter &esm) const;
 

components/esm/loadweap.cpp

@@ -9,6 +9,10 @@ namespace ESM
 {
     unsigned int Weapon::sRecordId = REC_WEAP;
 
+    Weapon::Weapon()
+        : mIsDeleted(false)
+    {}
+
     void Weapon::load(ESMReader &esm)
     {
         mId = esm.getHNString("NAME");

components/esm/loadweap.hpp

@@ -71,6 +71,8 @@ struct Weapon
 
     bool mIsDeleted;
 
+    Weapon();
+
     void load(ESMReader &esm);
     void save(ESMWriter &esm) const;