diff --git a/apps/openmw/mwgui/trainingwindow.cpp b/apps/openmw/mwgui/trainingwindow.cpp index 5ed22df487..2b5e64adf0 100644 --- a/apps/openmw/mwgui/trainingwindow.cpp +++ b/apps/openmw/mwgui/trainingwindow.cpp @@ -64,21 +64,37 @@ namespace MWGui const MWWorld::Store& gmst = store->get(); const MWWorld::Store& skillStore = store->get(); - // NPC can train you in his best 3 skills + // NPC can train you in their best 3 skills + constexpr size_t maxSkills = 3; std::vector> skills; + skills.reserve(maxSkills); - MWMechanics::NpcStats const& actorStats(actor.getClass().getNpcStats(actor)); + const auto sortByValue + = [](const std::pair& lhs, const std::pair& rhs) { + return lhs.second > rhs.second; + }; + // Maintain a sorted vector of max maxSkills elements, ordering skills by value and content file order + const MWMechanics::NpcStats& actorStats = actor.getClass().getNpcStats(actor); for (const ESM::Skill& skill : skillStore) { float value = getSkillForTraining(actorStats, skill.mId); - - skills.emplace_back(&skill, value); + if (skills.size() < maxSkills) + { + skills.emplace_back(&skill, value); + std::stable_sort(skills.begin(), skills.end(), sortByValue); + } + else + { + auto& lowest = skills[maxSkills - 1]; + if (lowest.second < value) + { + lowest.first = &skill; + lowest.second = value; + std::stable_sort(skills.begin(), skills.end(), sortByValue); + } + } } - std::sort(skills.begin(), skills.end(), [](const auto& left, const auto& right) { - return std::tie(right.second, left.first->mId) < std::tie(left.second, right.first->mId); - }); - MyGUI::EnumeratorWidgetPtr widgets = mTrainingOptions->getEnumerator(); MyGUI::Gui::getInstance().destroyWidgets(widgets); @@ -86,7 +102,7 @@ namespace MWGui const int lineHeight = Settings::gui().mFontSize + 2; - for (int i = 0; i < 3; ++i) + for (size_t i = 0; i < skills.size(); ++i) { const ESM::Skill* skill = skills[i].first; int price = static_cast(