mirror/openmw
1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-03-03 17:09:40 +00:00
Code Issues Releases Wiki Activity

Fix coverity issues

Browse source
This commit is contained in:
Petr Mikheev 2021-07-12 11:01:32 +02:00
parent 08d6ec5b84
commit 8ff8ec4abd
3 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
apps/openmw/engine.cpp
View file

@ -407,6 +407,7 @@ OMW::Engine::Engine(Files::ConfigurationManager& configurationManager)
, mExportFonts(false) , mExportFonts(false)
, mRandomSeed(0) , mRandomSeed(0)
, mScriptContext (nullptr) , mScriptContext (nullptr)
, mLuaManager (nullptr)
, mFSStrict (false) , mFSStrict (false)
, mScriptBlacklistUse (true) , mScriptBlacklistUse (true)
, mNewGame (false) , mNewGame (false)
@ -899,7 +900,7 @@ private:
Engine* mEngine; Engine* mEngine;
std::mutex mMutex; std::mutex mMutex;
std::condition_variable mCV; std::condition_variable mCV;
bool mUpdateRequest; bool mUpdateRequest = false;
double mDt = 0; double mDt = 0;
bool mIsGuiMode = false; bool mIsGuiMode = false;
std::optional<std::thread> mThread; std::optional<std::thread> mThread;

14
apps/openmw/mwbase/luamanager.hpp
View file

@ -42,14 +42,14 @@ namespace MWBase
struct ActorControls struct ActorControls
{ {
bool mDisableAI; bool mDisableAI = false;
bool mControlledFromLua; bool mControlledFromLua = false;
bool mJump; bool mJump = false;
bool mRun; bool mRun = false;
float mMovement; float mMovement = 0;
float mSideMovement; float mSideMovement = 0;
float mTurn; float mTurn = 0;
}; };
virtual ActorControls* getActorControls(const MWWorld::Ptr&) const = 0; virtual ActorControls* getActorControls(const MWWorld::Ptr&) const = 0;

4
components/lua/luastate.cpp
View file

@ -82,7 +82,9 @@ namespace LuaUtil
sol::table LuaState::getMutableFromReadOnly(const sol::userdata& ro) sol::table LuaState::getMutableFromReadOnly(const sol::userdata& ro)
{ {
sol::stack::push(mLua, ro); sol::stack::push(mLua, ro);
lua_getmetatable(mLua, -1); int ok = lua_getmetatable(mLua, -1);
assert(ok);
(void)ok;
sol::table res = sol::stack::pop<sol::table>(mLua); sol::table res = sol::stack::pop<sol::table>(mLua);
lua_pop(mLua, 1); lua_pop(mLua, 1);
return res; return res;