mirror/openmw
1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-01-20 13:23:52 +00:00
Code Issues Releases Wiki Activity

SearchVisitor copy a new std::string everytime CellsStore::search is

Browse source 
called. Use a reference instead
This commit is contained in:
fredzio 2019-03-01 23:12:45 +01:00
parent 3b8b0b5dd7
commit 93ffdc915d
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
apps/openmw/mwworld/cellstore.cpp
View file

@ -382,10 +382,10 @@ namespace MWWorld
struct SearchVisitor
{
PtrType mFound;
std::string mIdToFind;
const std::string *mIdToFind;
bool operator()(const PtrType& ptr)
{
if (ptr.getCellRef().getRefId() == mIdToFind)
if (ptr.getCellRef().getRefId() == *mIdToFind)
{
mFound = ptr;
return false;
@ -397,7 +397,7 @@ namespace MWWorld
Ptr CellStore::search (const std::string& id)
{
SearchVisitor<MWWorld::Ptr> searchVisitor;
searchVisitor.mIdToFind = id;
searchVisitor.mIdToFind = &id;
forEach(searchVisitor);
return searchVisitor.mFound;
}
@ -405,7 +405,7 @@ namespace MWWorld
ConstPtr CellStore::searchConst (const std::string& id) const
{
SearchVisitor<MWWorld::ConstPtr> searchVisitor;
searchVisitor.mIdToFind = id;
searchVisitor.mIdToFind = &id;
forEachConst(searchVisitor);
return searchVisitor.mFound;
}