fixed inconsistent handling of deleted records in dialogue; general cleanup

apps/opencs/view/world/dialoguesubview.cpp

@@ -764,12 +764,21 @@ void CSVWorld::DialogueSubView::viewRecord ()
 
 void CSVWorld::DialogueSubView::switchToRow (int row)
 {
-    getEditWidget().remake (row);
+    int idColumn = getTable().findColumnIndex (CSMWorld::Columns::ColumnId_Id);
+    std::string id = getTable().data (getTable().index (row, idColumn)).toString().toUtf8().constData();
+
+    int typeColumn = getTable().findColumnIndex (CSMWorld::Columns::ColumnId_RecordType);
+    CSMWorld::UniversalId::Type type = static_cast<CSMWorld::UniversalId::Type> (
+        getTable().data (getTable().index (row, typeColumn)).toInt());
 
-    setUniversalId (CSMWorld::UniversalId (static_cast<CSMWorld::UniversalId::Type> (getTable().data (getTable().index (row, 2)).toInt()),
-                            getTable().data (getTable().index (row, 0)).toString().toUtf8().constData()));
+    setUniversalId (CSMWorld::UniversalId (type, id));
+    changeCurrentId (id);
+    
+    getEditWidget().remake (row);
 
-    changeCurrentId(std::string (getTable().data (getTable().index (row, 0)).toString().toUtf8().constData()));
+    int stateColumn = getTable().findColumnIndex (CSMWorld::Columns::ColumnId_Modification);
+    CSMWorld::RecordBase::State state = static_cast<CSMWorld::RecordBase::State> (
+        getTable().data (getTable().index (row, stateColumn)).toInt());
 
-    getEditWidget().setDisabled (isLocked());
+    getEditWidget().setDisabled (isLocked() || state==CSMWorld::RecordBase::State_Deleted);
 }

apps/opencs/view/world/recordbuttonbar.cpp

@@ -121,16 +121,13 @@ void CSVWorld::RecordButtonBar::cloneRequest()
 {
     if (mBottom)
     {
-        int typeColumn = mTable.searchColumnIndex (CSMWorld::Columns::ColumnId_RecordType);
-
-        if (typeColumn!=-1)
-        {
-            QModelIndex typeIndex = mTable.getModelIndex (mId.getId(), typeColumn);
-            CSMWorld::UniversalId::Type type = static_cast<CSMWorld::UniversalId::Type> (
-                mTable.data (typeIndex).toInt());
-            
-            mBottom->cloneRequest (mId.getId(), type);
-        }
+        int typeColumn = mTable.findColumnIndex (CSMWorld::Columns::ColumnId_RecordType);
+
+        QModelIndex typeIndex = mTable.getModelIndex (mId.getId(), typeColumn);
+        CSMWorld::UniversalId::Type type = static_cast<CSMWorld::UniversalId::Type> (
+            mTable.data (typeIndex).toInt());
+
+        mBottom->cloneRequest (mId.getId(), type);
     }
 }