mirror/openmw
1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-10-16 06:46:33 +00:00
Code Issues Releases Wiki Activity

Reuse quest name

Browse source
This commit is contained in:
Evil Eye 2025-08-23 11:00:49 +02:00
parent 15eecec196
commit 9d63c34c47
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
apps/openmw/mwgui/journalviewmodel.cpp
View file

@ -205,21 +205,21 @@ namespace MWGui
// Unfortunately Morrowind.esm has no quest names, since the quest book was added with tribunal. // Unfortunately Morrowind.esm has no quest names, since the quest book was added with tribunal.
// Note that even with Tribunal, some quests still don't have quest names. I'm assuming those are not // Note that even with Tribunal, some quests still don't have quest names. I'm assuming those are not
// supposed to appear in the quest book. // supposed to appear in the quest book.
if (quest.getName().empty()) const std::string_view questName = quest.getName();
if (questName.empty())
continue; continue;
// Don't list the same quest name twice // Don't list the same quest name twice
if (!visitedQuests.insert(quest.getName()).second) if (!visitedQuests.insert(questName).second)
continue; continue;
bool isFinished = std::ranges::find_if(journal->getQuests(), [&](const auto& pair) { bool isFinished = std::ranges::find_if(journal->getQuests(), [&](const auto& pair) {
return pair.second.isFinished() return pair.second.isFinished() && Misc::StringUtils::ciEqual(questName, pair.second.getName());
&& Misc::StringUtils::ciEqual(quest.getName(), pair.second.getName());
}) != journal->getQuests().end(); }) != journal->getQuests().end();
if (activeOnly && isFinished) if (activeOnly && isFinished)
continue; continue;
visitor(quest.getName(), isFinished); visitor(questName, isFinished);
} }
} }