From 9d8f6064a171aaeb908913706db05b3d28a68b2f Mon Sep 17 00:00:00 2001 From: Alexei Dobrohotov Date: Sun, 3 Apr 2022 22:35:29 +0300 Subject: [PATCH] Detail the unused parts of controlled.cpp defs --- components/nif/controlled.cpp | 31 ++++++++++++++----------------- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/components/nif/controlled.cpp b/components/nif/controlled.cpp index c8116ce74e..73359aeb2a 100644 --- a/components/nif/controlled.cpp +++ b/components/nif/controlled.cpp @@ -34,11 +34,12 @@ namespace Nif mipmap = nif->getUInt(); alpha = nif->getUInt(); - nif->getChar(); // always 1 + // Renderer hints, typically of no use for us + /* bool mIsStatic = */nif->getChar(); if (nif->getVersion() >= NIFStream::generateVersion(10,1,0,103)) - nif->getBoolean(); // Direct rendering + /* bool mDirectRendering = */nif->getBoolean(); if (nif->getVersion() >= NIFStream::generateVersion(20,2,0,4)) - nif->getBoolean(); // NiPersistentSrcTextureRendererData is used instead of NiPixelData + /* bool mPersistRenderData = */nif->getBoolean(); } void NiSourceTexture::post(NIFFile *nif) @@ -99,22 +100,21 @@ namespace Nif NiParticleModifier::read(nif); mBounceFactor = nif->getFloat(); - if (nif->getVersion() >= NIFStream::generateVersion(4,2,2,0)) + if (nif->getVersion() >= NIFStream::generateVersion(4,2,0,2)) { // Unused in NifSkope. Need to figure out what these do. - /*bool spawnOnCollision = */nif->getBoolean(); - /*bool dieOnCollision = */nif->getBoolean(); + /*bool mSpawnOnCollision = */nif->getBoolean(); + /*bool mDieOnCollision = */nif->getBoolean(); } } void NiPlanarCollider::read(NIFStream *nif) { NiParticleCollider::read(nif); - - /*unknown*/nif->getFloat(); - - for (int i=0;i<10;++i) - /*unknown*/nif->getFloat(); + /* osg::Vec2f mExtents = */nif->getVector2(); + /* osg::Vec3f mPosition = */nif->getVector3(); + /* osg::Vec3f mXVector = */nif->getVector3(); + /* osg::Vec3f mYVector = */nif->getVector3(); mPlaneNormal = nif->getVector3(); mPlaneDistance = nif->getFloat(); @@ -124,12 +124,9 @@ namespace Nif { NiParticleModifier::read(nif); - /* - byte (0 or 1) - float (1) - float*3 - */ - nif->skip(17); + /* bool mRandomInitialAxis = */nif->getChar(); + /* osg::Vec3f mInitialAxis = */nif->getVector3(); + /* float mRotationSpeed = */nif->getFloat(); } void NiSphericalCollider::read(NIFStream* nif)