From fbd99583ca6cb120ebfd67cce7d38848529dc4ae Mon Sep 17 00:00:00 2001
From: Andrei Kortunov <andrei.kortunov@yandex.ru>
Date: Tue, 9 Jan 2024 16:11:44 +0400
Subject: [PATCH] Move local variables in GUI code

---
 apps/openmw/mwgui/alchemywindow.cpp       | 4 +++-
 apps/openmw/mwgui/bookpage.cpp            | 2 +-
 apps/openmw/mwgui/console.cpp             | 2 +-
 apps/openmw/mwgui/formatting.cpp          | 2 +-
 apps/openmw/mwgui/spellcreationdialog.cpp | 2 +-
 apps/openmw/mwgui/spellicons.cpp          | 2 +-
 apps/openmw/mwgui/tooltips.cpp            | 2 +-
 7 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/apps/openmw/mwgui/alchemywindow.cpp b/apps/openmw/mwgui/alchemywindow.cpp
index 4215782e2f..5a6245fca0 100644
--- a/apps/openmw/mwgui/alchemywindow.cpp
+++ b/apps/openmw/mwgui/alchemywindow.cpp
@@ -395,8 +395,10 @@ namespace MWGui
     {
         std::string suggestedName = mAlchemy->suggestPotionName();
         if (suggestedName != mSuggestedPotionName)
+        {
             mNameEdit->setCaptionWithReplacing(suggestedName);
-        mSuggestedPotionName = suggestedName;
+            mSuggestedPotionName = std::move(suggestedName);
+        }
 
         mSortModel->clearDragItems();
 
diff --git a/apps/openmw/mwgui/bookpage.cpp b/apps/openmw/mwgui/bookpage.cpp
index 5d9256b20d..1966442513 100644
--- a/apps/openmw/mwgui/bookpage.cpp
+++ b/apps/openmw/mwgui/bookpage.cpp
@@ -1065,7 +1065,7 @@ namespace MWGui
                 {
                     createActiveFormats(newBook);
 
-                    mBook = newBook;
+                    mBook = std::move(newBook);
                     setPage(newPage);
 
                     if (newPage < mBook->mPages.size())
diff --git a/apps/openmw/mwgui/console.cpp b/apps/openmw/mwgui/console.cpp
index 504ea560b2..b430e08142 100644
--- a/apps/openmw/mwgui/console.cpp
+++ b/apps/openmw/mwgui/console.cpp
@@ -440,7 +440,7 @@ namespace MWGui
         // If new search term reset position, otherwise continue from current position
         if (newSearchTerm != mCurrentSearchTerm)
         {
-            mCurrentSearchTerm = newSearchTerm;
+            mCurrentSearchTerm = std::move(newSearchTerm);
             mCurrentOccurrenceIndex = std::string::npos;
         }
 
diff --git a/apps/openmw/mwgui/formatting.cpp b/apps/openmw/mwgui/formatting.cpp
index 7f62bbf49c..b2d9415897 100644
--- a/apps/openmw/mwgui/formatting.cpp
+++ b/apps/openmw/mwgui/formatting.cpp
@@ -221,7 +221,7 @@ namespace MWGui::Formatting
                 }
             }
 
-            mAttributes[key] = value;
+            mAttributes[key] = std::move(value);
         }
     }
 
diff --git a/apps/openmw/mwgui/spellcreationdialog.cpp b/apps/openmw/mwgui/spellcreationdialog.cpp
index bb97ccb82f..d668db1dec 100644
--- a/apps/openmw/mwgui/spellcreationdialog.cpp
+++ b/apps/openmw/mwgui/spellcreationdialog.cpp
@@ -472,7 +472,7 @@ namespace MWGui
 
         ESM::EffectList effectList;
         effectList.mList = mEffects;
-        mSpell.mEffects = effectList;
+        mSpell.mEffects = std::move(effectList);
         mSpell.mData.mCost = int(y);
         mSpell.mData.mType = ESM::Spell::ST_Spell;
         mSpell.mData.mFlags = 0;
diff --git a/apps/openmw/mwgui/spellicons.cpp b/apps/openmw/mwgui/spellicons.cpp
index 5337e2f798..aa29dfc156 100644
--- a/apps/openmw/mwgui/spellicons.cpp
+++ b/apps/openmw/mwgui/spellicons.cpp
@@ -172,7 +172,7 @@ namespace MWGui
                 w += 16;
 
                 ToolTipInfo* tooltipInfo = image->getUserData<ToolTipInfo>();
-                tooltipInfo->text = sourcesDescription;
+                tooltipInfo->text = std::move(sourcesDescription);
 
                 // Fade out
                 if (totalDuration >= fadeTime && fadeTime > 0.f)
diff --git a/apps/openmw/mwgui/tooltips.cpp b/apps/openmw/mwgui/tooltips.cpp
index 9ee7d08f31..0a0343831d 100644
--- a/apps/openmw/mwgui/tooltips.cpp
+++ b/apps/openmw/mwgui/tooltips.cpp
@@ -251,7 +251,7 @@ namespace MWGui
                     if (!cost.empty() && cost != "0")
                         info.text
                             += MWGui::ToolTips::getValueString(MWMechanics::calcSpellCost(*spell), "#{sCastCost}");
-                    info.effects = effects;
+                    info.effects = std::move(effects);
                     tooltipSize = createToolTip(info);
                 }
                 else if (type == "Layout")